Checking Strings

[Lynux-Penguin]

#include <stdio.h>
int main(int argc, char* argv[])
{
	if(argv[1] == "mytext")
		printf("argv[1] Correct\n");
	else if(argv[1])
		printf("argv[1] found but not correct\n");
	else
		printf("argv[1] not found\n");
	return 0;
}

With this code, no matter what I type in I can never get "Correct"
why is this and what can I do?

Here is what the array looks like if I type in mytext:
[m][y][t][e][x][t][\0]

right?

[ihsir]

instead of if(argv[1] == "mytext") use strcmp/strncmp for comparisions between strings

[Monster]

Always check your number of arguments (argc). Your program can crash if you do don't give any arguments (argc = 1) and you try to check argv[1] (second argument).

int main(int argc, char *argv[])
{
    if(argc < 2)
    {
        printf("argv[1] not found\n");
    }
    else
    {
        /* check argv[1] */
    }
    return 0;
}

[Shiro]

#include <stdio.h>
int main(int argc, char* argv[])
{
    int retval = 0;

    if (argc < 2)
    {
        printf ("Not enough arguments\n");
        retval = 1;
    }
    else
    {
        if (strcmp (argv [1], "mytext") == 0)
            printf ("argv [1] Correct\n");
        else
        {
            printf ("argv [1] Found but not correct\n");
            retval = 1;
        }
    }

    return retval;      
}

Note that your last "else" is not necessary if you check the number arguments before checking the arguments.