Thread: searching linked lists

>if(libry.code=&libry.code)
I believe you want == here, not =. Also, you're testing the address of libry.code with the contents of libry.code, what is this test supposed to accomplish?

>found=libry.code;
The found variable is a pointer to a struct book, libry.code is an int. This is just a little off. Perhaps a key variable that is defined as an int to hold the user's choice.

>if (found == NULL)
Since you always walk to the end of this list this will be true every time. Declare an explicit iterator for the list and if you find the key then point found to where the iterator is. Or declare the function to return a struct book * and return the iterator.

>found != NULL && found->next!= found
This test confuses me a bit. What are you testing for with found->next != found?

This code is a bit nasty and the goal could be accomplished more easily if you gave more responsibility to the calling function such as checking if the item was found by seeing if a returned value is NULL:

Code:

struct book *search(struct book *head)
{
  int key;
  struct book *iter;

  printf("\t\t\tTusket Municipal Library\n\n\n");
  printf("Which book code do you want to search for?: ");
  scanf("%d",&key);

  for(iter=head; iter!=NULL; iter=iter->next)
    if(iter->code == key) return iter;
  return NULL;
}

-Prelude