Thread: Help keeping a count of distinct values

So this code I'm trying to calculate the number of distinct values entered into an array. If i enter the followings
"3,4,5,6,7,7,6,e (anything that's not a number)"


i get a total of 7 but in reality it should be a 5. can anyone help out?

Code:

#include <stdio.h>






//---------function to find the distinct values----
//------ need help here----------


int find_distinct(int list[], int size)
    {
     int i, j,size2, distinct = 0;
     for(i = 0; i < size; i++)
     {
           
           for(j=i+1;j<size;j++)
           {
            if(list[i] == list[j])
            {
            continue;
            }
            else
            {
            distinct++;
            }
      
           }
      return distinct;      
     }


    }
 
    
     
       


int main()
{
   //-------variables------------------ 
    int list[1000];  // can hold 1000 items
    int i, element, distinct;
    int ret;
         
    printf("Enter in as much number as you want and it'll calculate:\nthe number of distinct values. \n");
    printf("Type in a non integer when you're done\n");
 
 
    //------ user puts in array 1000 times or until they press a non integar
    for (i = 0; i < 1000; ++i)
    {
      ret = scanf("%i", &list[i]);
      if(ret == 0)
      {
       element = i++;
      
          
       distinct = find_distinct(list, element);
       printf("\nThe distinct value: %i", distinct);      
 
       
       getch();  
       }
      
      
     }
     
 
}

If the array is sorted, then no, you don't need a second array if you only want a count of distinct elements. Rather, instead of copying the distinct element, increment the count.

If the array is not sorted, then sort it, and the answer becomes the same as above. If you are not permitted to sort it, then yes, you need a second array (or other data structure).

> Here's what i have
It would be a hell of a lot easier for us if you also posted a main, and the test array that your using.

You can't count the distinct values at the same time you're sorting the array.

First sort the array, then loop through it and increment your counter every time the value changes.

heres what i have so far if i type in "3,4,5,4,4,5,6,6,e(to finish inputting numbers)" the distinct values should be 4, but i got 5. so im still off by 1.

Code:

#include <stdio.h>



//---------function to find the distinct values-------




int find_distinct(int list[], int size)
{
int i, j, distinct = 0, temp;
for(i=0;i<size;i++)
{ //sorts array
for(j=i;j<size;j++)
{
temp = list[i];
list[i] = list[j];
list[j] = temp;
}
}
for(i=0;i<size-1;i++)
{
if(list[i]==list[i-1])
continue;
else
distinct++;
}
return distinct;
}


int main()
{
//-------variables------------------
int list[1000]; // can hold 1000 items
int i, element, distinct;
int ret;


printf("Enter in as much number as you want and it'll calculate:\nthe  total of distinct value. \n");
printf("\nType in a non integer and it'll end the number input\n");




//------ user puts in array 1000 times or until they press a non integar
for (i = 0; i < 1000; ++i)
{
ret = scanf("%i", &list[i]);
if(ret == 0)
{
element = i++;






distinct = find_distinct(list, element);
printf("\nThe number of distinct value: %i", distinct);









return 0;
}




}




}