Thread: Adding Arrays

Code:

#include <stdio.h>


#define MAXNUMBER 11




void addfloat(float * array1, float * array2);




int main( )
{
    float array1[MAXNUMBER] = {10.2,12.8,11.9,18.3,19.5,29.8,19.4,15.4,13.6,13.8};
    float array2[MAXNUMBER] = {11.2,17.5,12.6,13.1,11.3,19.3,9.4,5.4,3.6,3.8};


    addfloat(array1, array2);


   return 0;
}




void addfloat(float * array1,float * array2)
{
    int i;
    float sum[MAXNUMBER];


    for (i=1; i < MAXNUMBER; i++)
    {
        sum[i] = array1[i] + array2[i];
        printf("Array1 + Array2 = %4.2f\n",sum[i]);
    }
}

I'll get to what I did here in a few minutes.

Originally Posted by jocdrew21

I have done this very simple program a few times and it worked. Now its not and I cannot figure it out.

Code:

 #include <stdio.h>

#define MAXNUMBER 11


void addfloat(float *, float *);


int main(int argc, const char * argv[])
{


float array1[MAXNUMBER] = {10.2,12.8,11.9,18.3,19.5,29.8,19.4,15.4,13.6,13.8};
float array2[MAXNUMBER] = {11.2,17.5,12.6,13.1,11.3,19.3,9.4,5.4,3.6,3.8};

   addfloat(&array1[MAXNUMBER], &array2[MAXNUMBER]);

   return 0;
}


void addfloat(float array1[],float array2[])
{
   int i;
   float sum[MAXNUMBER];

   for (i=1; i < MAXNUMBER; i++) {

       sum[i] = array1[i] + array2[i];

printf("Array1 + Array2 = %4.2f\n",sum[i]);
}
}

Step 1 : Fixed all of the indentation that was off in your code.

Step 2 : Changed the function prototype to include the proper variable names instead of just a type like you probably did by mistake.

Step 3 : You over-complicated the calling of the addfloat function. You just needed to pass a float pointer to it and you didn't need to include the types or anything.

Step 4 : Fixed the addfloat function to just use float pointers instead of pointers to float pointers.

Step 5 : Ran the program.

Originally Posted by jimblumberg

There is nothing technically wrong with his function prototype. However many people consider it a good practice to add the names, but it's not a requirement. The compiler doesn't actually use the variable names in the prototype, it's the names in the implementation that are important.


Do you realize that the following are equivalent?

Code:

void addfloat(float *, float *);
void addfloat(float[], float[]);

Also unless you're going to actually use the parameters to main() you shouldn't use that version. And the argv[][] argument should not be declared const.

Jim

1) I didn't know that, I've always been taught to add names in prototypes.
2) I do, but I'm used to using pointers instead of arrays.

Originally Posted by HelpfulPerson

1) I didn't know that, I've always been taught to add names in prototypes.

You do it (as a lot of other things like indentation) for programmer reading the code, not for compiler.

Originally Posted by jimblumberg

Do you know a pointer is designated with a *, the [] denote arrays.

Jim

I know that? Why are you asking me that?

Originally Posted by HelpfulPerson

Code:

#include <stdio.h>


#define MAXNUMBER 11




void addfloat(float * array1, float * array2);




int main( )
{
    float array1[MAXNUMBER] = {10.2,12.8,11.9,18.3,19.5,29.8,19.4,15.4,13.6,13.8};
    float array2[MAXNUMBER] = {11.2,17.5,12.6,13.1,11.3,19.3,9.4,5.4,3.6,3.8};


    addfloat(array1, array2);


   return 0;
}




void addfloat(float * array1,float * array2)
{
    int i;
    float sum[MAXNUMBER];


    for (i=1; i < MAXNUMBER; i++)
    {
        sum[i] = array1[i] + array2[i];
        printf("Array1 + Array2 = %4.2f\n",sum[i]);
    }
}

I'll get to what I did here in a few minutes.

Originally Posted by jimblumberg

Because you don't seem to understand the concept.

Code:

// His original.
void addfloat(float * array1,float * array2)
{
// Your modification.
void addfloat(float array1[],float array2[])

And then your statement:

His original code is using pointer notation, your's is using array notation.

Jim

Ummm, no. If you looked at where I posted the code that I fixed, then you would see that I didn't modify any of his functions in the way you are suggesting. I did leave the way he accessed the pointer as an array inside the function the same.

total shouldn't be an array. Are there many totals or only one? I assume only one. And it of course needs to be initialized to 0.