I cannot find the error...

[catasturslykid]

Hi guys!

I've got the following problem with my program:

While opening a file to read, something happens and nothing appears at the screen.

I ask the user the filename and the program opens it.

If the filename is wrong, the program says: "Error!" and returns to the main menu.

BUT, if the filename is correct, nothing happens.

Here is the code:

#include "total.h" //All the functions and xxx.h are included

void carregaPersonatge(FILE *h, Classe *classes, int nClas, int nEnemics, Enemic *enemics){

Personatge personatge;
char strNom[50], strNomc[50],strOmet[100];
int nVida, nAtac, nExp, nNivell, nQuina;

printf("FILE name?");
scanf("%s",strNom);
h = fopen(strNom,"r");

printf("HELLO!"); //THAT HELLO DOES NOT APPEAR.

if(h == NULL){
printf("Error!\n");
menuPrincipal(nClas, nEnemics, classes, enemics);
}
else{

printf("NICE"); //DOES NOT APPEAR.

//NOW I READ ALL THE INFORMATION FROM THE FILE

fscanf(h,"%s",strOmet);
fscanf(h,"%s",strNomc);
fscanf(h,"%d",&nNivell);
fscanf(h,"%d",&nExp);
personatge.nExperiencia = nExp;
personatge.nNivell = nNivell;
strcpy(personatge.strNom, strNom);
nQuina = dadesClasse(strNomc,nClas,classes);

personatge.vida = classe[nQuina].nVida + nNivell*50;
personatge.nAtac = classe[nQuina].nAtac + nNivell*10;
personatge.nDefensa = classe[nQuina].nDefensa + nNivell*5;
strcpy(personatge.classe.strNom, classes[nQuina].strNom);
menuPersonatge(personatge, enemics, h ,nEnemics,nClas,classes);

}
fclose(h);
}

And that's what appears (NOTHING!):

[Adak]

Line 13, add a newline \n to the end of the string you're printing. It appears to be buffering it, which you don't want.

Ditto line 21.

Then recompile it and check your compiler's warnings. Run it and see what happens, just to help narrow it down.

Why do I want you to debug it a bit? Because debugging skills must be practiced, and I don't see that you've done much, yet.

[oogabooga]

You need to post your entire program since the error is presumably somewhere else.

And if you're using printf as a debug tool you should probably use fprintf(stderr, ...) and make sure you have a newline at the end of the string.
Otherwise the buffered nature of stdout may cause the output not to appear even though the line was executed.

Of course, a debugger is better.

[catasturslykid]

Hi guys. I added the \n at the end of all the printf and it worked, but not at all.

Let me explain:

Everything works until I arrive to the function dadesClasse.

That function returns and INT that shows the position of the array Classe that the program needs.

The code is:

int dadesClasse(char strNomc[50], int nClas, Classe *classes){

int i = 0, nTrobat = 0, nQuina; 

    while(i < nClas && !nTrobat){
        if(strcmp(classes[i].strNom, strNomc) == 0){
            nTrobat = 1;
            nQuina = i;
        }
    }
    return nQuina;
}

And, as I said in my last post, nothing happens.

I add

printf("%d\n", &nQuina);

under the function

nQuina = dadesClasse(...);

to check if nQuina is correct, but nothing happens.

Where is the error?

[grumpy]

You also need to provide the main() function that is calling carregaPersonatge(). And the contents of total.h.

What about the notion of "post your entire program" is eluding you?

The reason others have requested your entire program is that, most of the time, code that people choose not to post is a contributor to their problem. Forum members are not mindreaders. Since your code is reading a file, it is a good idea to provide a sample input file. Mismatches between the contents of a file, and the code which reads it, are another common cause of problems.

If your "entire program" is too big to post (i.e. it will be too big to expect people to sift through, unless you pay them hard cash) then provide a small and complete sample of code that accurately exhibits your problem.

[stach]

What about the notion of "post your entire program" is eluding you?
.

how did you get the nickname 'grumpy' ?

[stahta01]

int i = 0, nTrobat = 0, nQuina;

Change above to

int i = 0, nTrobat = 0, nQuina = -1;

Then check for -1 if it is -1 DO NOT use nQuina because the value is bad.

Tim S.

[grumpy]

how did you get the nickname 'grumpy' ?

By having a low tolerance for rampant stupidity, those who ignore reasonable requests for clarifying information, those who think they are entitled to have others do their homework for them, and those who ask silly questions about my handle. Ignorance I accept (as everyone is ignorant of something, and they can address that through honest effort).

[catasturslykid]

You also need to provide the main() function that is calling carregaPersonatge(). And the contents of total.h.

What about the notion of "post your entire program" is eluding you?

The reason others have requested your entire program is that, most of the time, code that people choose not to post is a contributor to their problem. Forum members are not mindreaders. Since your code is reading a file, it is a good idea to provide a sample input file. Mismatches between the contents of a file, and the code which reads it, are another common cause of problems.

If your "entire program" is too big to post (i.e. it will be too big to expect people to sift through, unless you pay them hard cash) then provide a small and complete sample of code that accurately exhibits your problem.

Excuse me, sir.

I do not post the entire program because is quite big. And the function carregaPersonatge is an "in-function". Another problem is that I'm using "putty" to conect to my university computer and I can't copy-paste.

Here's the "total.h":

#ifndef TOTAL_H
#define TOTAL_H

#include "tipus.h"
#include "cua.h"

//I'm going to write only the important functions.

void main(int argc, char* argv[]);
void menuPrincipal(int nClas, int nEnemics, Classe *classes, Enemic *enemics);
.
.
.
void carregaPersonatge(FILE *h, Classe *classes, int nClas, int nEnemics, Enemic *enemics);
int dadesClasse(char strNomc[50], int nClas, Classe *classes);

#endif

MAIN

#include "total.h"

void main(int argc, char* argv[]){

FILE *f,*g;
int nCorrecte = 0, nOpcio, nEnemics, nClas;
Classe *classes;
Enemic *enemics;

srand(time(NULL));

f = fopen(argv[1],"r");
if (f == NULL){
    printf("Error!(1)\n");
}
else{
    g = fopen(argv[2],"r");
    if( g == NULL){
         printf("Error!(2)\n);
    }
    else{
       carregaClasses(f,&classes,&nClas);
       carregaEnemics(g,&enemics,&nEnemics);
       menuPrincipal(nClas, nEnemics, classes, enemics);
    }
}
fclose(f);
fclose(g);
}

menuPrincipal

void menuPrincipal(int nClas, int nEnemics, Classe *classes, Enemic *enemics){

FILE *h;
int nCorrecte = 0, nOpcio;

while(nCorrecte == 0){

printf("  Menu Principal\");
printf("1- New character\n");
printf("2- LOAD CHARACTER\n");
printf("3- Exit\n");
printf("Option?");
scanf("%d",&nOpcio);
if(nOpcio == 1 || nOpcio == 2 || nOpcio == 3){
    nCorrecte = 1;
}
else{
    printf("Error!\n");
}

if(nCorrecte == 1){
switch(nOpcio){
    case 1: creaPersonatge(classes, nClas, &h, nEnemics, enemics);
               break;
    case 2: carregaPersonatge (&h,classes,nClas,nEnemics,enemics);
               break;
    default: exit(1);
               break;
   }
}
}
}

[rags_to_riches]

Another problem is that I'm using "putty" to conect to my university computer and I can't copy-paste.

Fight your ignorance: PuTTY FAQ

[catasturslykid]

Thanks!

Our teachers said that we cannot copy-paste from PuTTY to Windows... Thanks again!


Let's paste all the code:

   #include "total.h"
  
  
  
   void main(int argc, char* argv[]){ //S'executa possant: practica3 fitxer_classes fitxer_enemics
  
   FILE *f, *g;
   int nCorrecte = 0, nOpcio, nEnemics, nClas;
   Classe *classes;
  Enemic *enemics;
 
 
      srand(time(NULL));
 
      f = fopen (argv[1],"r");
      if (f == NULL){
          printf("Error!(1)\n");
      }
      else{
 
         g = fopen (argv[2],"r");
          if( g == NULL){
              printf("Error!(2)\n");
          }
          else{
              carregaClasses(f,&classes,&nClas);
              carregaEnemics(g,&enemics,&nEnemics);
              printf("%s", enemics[5].strNom);
              menuPrincipal(nClas, nEnemics, classes, enemics);
 
          }
      }
      fclose(f);
      fclose(g);
  }

 #include "total.h"
  
  
   void menuPrincipal(int nClas, int nEnemics, Classe *classes, Enemic *enemics){
   FILE *h;
   int nCorrecte = 0, nOpcio;
  
  
  
      while (nCorrecte == 0){
          printf("   Menu Principal\n");
          printf("1- Crear Personatge Nou\n");
          printf("2- Carregar Personatge\n");
          printf("3- Sortir\n\n");
          printf("Opcio? ");
          scanf("%d",&nOpcio);
          if( nOpcio == 1 || nOpcio == 2 || nOpcio ==3){
              nCorrecte = 1;
          }
          else{
              printf("Error! Escull una opcio correcta!\n");
          }
          if( nCorrecte == 1){
              switch(nOpcio){
                  case 1: creaPersonatge(classes, nClas, &h, nEnemics, enemics);
                          break;
                  case 2: carregaPersonatge(&h,classes,nClas,nEnemics,enemics);
                          break;
                  default: exit(1);
                          break;
                  }
          }
      }
  }

  #include "total.h"
  
  
  
   void carregaPersonatge(FILE *h, Classe *classes, int nClas,int nEnemics, Enemic *enemics){
  
   Personatge personatge;
   char strNom[50], strNomc[50], strOmet[100];
   int nVida, nAtac, nExp, nNivell, nQuina = 0;
 
 
      printf("Nom del personatge?:  ");
      scanf("%s",strNom);
      h = fopen(strNom,"r"); 
      printf("HOLA\n");
      if( h == NULL){
          printf("Error!\n");
          menuPrincipal(nClas, nEnemics, classes, enemics);//Return to the main menu.
      }
      else{
 
          printf("NICE\n");
 
          fscanf(h,"%s",strOmet); 
          printf("%s\n",strOmet); //Only to check
          fscanf(h,"%s", strNomc); 
          printf("%s\n",strNomc); //Only to check
          fscanf(h,"%d",&nNivell); 
          fscanf(h,"%d",&nExp); 
          personatge.nExperiencia = nExp;
          personatge.nNivell = nNivell;
          strcpy(personatge.strNom, strNom);
          printf("%d\n",personatge.nNivell); //Only to check
          nQuina = dadesClasse(strNomc,nClas,classes); 
          printf("%d\n",&nQuina); //Only to check -> Nothing happens.
          personatge.nVida = classes[nQuina].nVida + nNivell*50;
          personatge.nAtac = classes[nQuina].nAtac + nNivell*10;
          personatge.nDefensa = classes[nQuina].nDefensa + nNivell*5;
          strcpy(personatge.classe.strNom, classes[nQuina].strNom);
          printf("%s\n",personatge.classe.strNom); //Only to check
          menuPersonatge(personatge, enemics, h, nEnemics, nClas, classes);


 
      }
      fclose(h);
 }

And as I said, after print personatge.nNivell nothing appears on the screen.

[stahta01]

Once again Initialize all local variables!!

FILE *f, *g;
 int nCorrecte = 0, nOpcio, nEnemics, nClas;
 Classe *classes;
Enemic *enemics;

[catasturslykid]

Once again Initialize all local variables!!

FILE *f, *g;
 int nCorrecte = 0, nOpcio, nEnemics, nClas;
 Classe *classes;
Enemic *enemics;

Done! But still not working.

One more question?

Why is important to initialize all the local variables?

[stahta01]

Done! But still not working.

One more question?

Why is important to initialize all the local variables?

Because they can have random values if not initialized.

Tim S.

[HelpfulPerson]

Because they can have random values if not initialized.

Tim S.

To add to that, usually when a computer gives you memory to store values in, it doesn't zero out the memory. That means you get whatever values left over from any number of sources on your computer.