Format String is not a string literal

[Lazvaz]

Hi everyone,

This is really my first time posting and I'm a newcomer to programming. I'm wondering if someone can point out what i am doing wrong in the if and for loop with choice 2.

#include <stdio.h>
#include <stdlib.h>


struct employeedatabase
{
    char firstname[ 20 ];
    char lastname[ 20 ];
    char dateofbirth[ 10 ];
    char ssn[ 11 ];
    char contactnumber[ 13 ];
    unsignedint age[ 2 ];
    char gender[ 6 ];
    double hourlysalary[ 10 ];
}employees[10];


//Function prototype
int choice = 0;
int quit = 3;
int counter = 0;
int i = 0;


int main( )
{
    printf("\n********** MENU **********\n\n"
           "Enter your choice:\n"
           "1: Add a New Employee to the list.\n"
           "2: Print Current Employees.\n"
           "3: Quit.\n\n" );

    printf("Your choice is: ");
    scanf( "%d", &choice);

    while(choice !=3)
    {
        if( choice == 1)

        {
            printf("\n***** New Employee *****\n");
            printf("\nPlease fill in all information below:\n\n");

            printf("First Name: ");
            scanf("%s", employees[counter].firstname);         //input for First Name

            printf("Last Name: ");
            scanf("%s", employees[counter].lastname);          //input for Last Name

            printf("DOB (MM/DD/YYYY): ");
            scanf("%s", employees[counter].dateofbirth);       //Input for DOB

            printf("SSN: ");
            scanf("%s", employees[counter].ssn);               //Input for Social

            printf("Telephone Number: ");
            scanf("%s", employees[counter].contactnumber);     //Input for Phone Number

            printf("Gender: ");
            scanf("%s", employees[counter].gender);            //Input for Gender

            printf("Hourly Salary: $");
            scanf("%lf", employees[counter].hourlysalary);     //Input for Salary

            printf("\nEnter your choice:\n"
                   "1: Add a New Employee to the list.\n"
                   "2: Print Current Employees.\n"
                   "3: Quit.\n\n" );

            printf("Your choice is: ");
            scanf( "%d", &choice);

            if( choice == 1) counter++;// Increments employees by one

        }//End of Choice 1


        if(choice == 2)

        {
            printf("\n***** List of Employees *****\n");
            {
                for(i = 0;i <= 10; i++)
                {
                    printf(employees[counter].firstname);
                    printf(employees[counter].lastname);
                    printf(employees[counter].dateofbirth);
                    printf(employees[counter].ssn);
                    printf(employees[counter].contactnumber);
                    printf(employees[counter].gender);
                    printf(employees[counter].hourlysalary);
                }//End of for loop
            }

        }//End of Choice 2



    }// End of While Loop



}// End main

[vart]

printf("%s",employees[counter].firstname);

To prevent hacking of your code with names like "%p %d" etc

[Elkvis]

if you just want to print a string with no formatting, try puts().

[Adak]

You should have your global variables, changed to local (automatic) variables, declared inside the functions they're used in. These are not function prototypes, and shouldn't be outside functions:

//Function prototype
int choice = 0;
int quit = 3;
int counter = 0;
int i = 0;

Avoiding most if not all global variables, is a big improvement.


In your for loop for choice == 2, you are using the counter variable as your index, when you should be using the i variable.

[hk_mp5kpdw]

struct employeedatabase
{
    char firstname[ 20 ];
    char lastname[ 20 ];
    char dateofbirth[ 10 ];
    char ssn[ 11 ];
    char contactnumber[ 13 ];
    unsignedint age[ 2 ];
    char gender[ 6 ];
    double hourlysalary[ 10 ];
}employees[10];

...

for(i = 0;i <= 10; i++)
{
    printf(employees[counter].firstname);
    printf(employees[counter].lastname);
    printf(employees[counter].dateofbirth);
    printf(employees[counter].ssn);
    printf(employees[counter].contactnumber);
    printf(employees[counter].gender);
    printf(employees[counter].hourlysalary);
}//End of for loop

Adak already mentioned the "i vs counter" issue but... your loop condition should not ever allow entry into the body when the loop/index variable is more than what is valid for the array in question.


Also, when you are inputting the data you'd better make sure that counter is 0-9... anything else and you should not allow input into that employees array.

[Lazvaz]

Thanks for the help everyone, I believe i have fixed the issues that you pointed out.

I just have one more question, for some reason when i run the project and choose option 2 the code runs endlessly until i stop it or it quits unexpectedly.

Any thoughts?

[Matticus]

You scan in "choice" before you enter the loop. That variable is only updated within the loop when you run choice 1, so when you enter two, it continuously executes choice 2 each iteration.