Thread: Command line argc and argv help.

I'm building a command line interface for a program and the program doesn't seem to be reading the functions inside the "else if" statements. The program compiles and everything but nothing happens when I type the arguments into the command line. I think there might be something wrong with my argc and argv code but I'm not sure. Any help would be much appreciated. Thanks guys!

Code:

int main(int argc, char *argv[])
{
    FILE   *ISP_file;
    FILE   *SP_file;
    //FILE   *TempFile;
 
    int i = 0;

    for(i = 0;i < argc; i++)
  
    {
 
        if(0 == stricmp("Interrogator", argv[i]))
        {
            InterrogatorProtocol1553Flag = TRUE;
        }
  
       else if(0 == stricmp("MLV_PLV_179", argv[i]))
        {
           Interrogator_OFP_Select = INT_OFP_DMV_179;
           DirectFlashProgFlag = FALSE;
           //ISP_file = fopen(FopISP_DataFile, "rb");
           SP_file  = fopen(FopSP_DataFile, "rb");
           //TempFile = fopen(TempFilePath, "wb");
           Execute1553();
         }
  
       else if(0 == stricmp("MLV_PLV_183", argv[i]))
        {
            Interrogator_OFP_Select = INT_OFP_DMV_183;
            DirectFlashProgFlag = FALSE;
            //ISP_file = fopen(FopISP_DataFile, "rb");
            SP_file  = fopen(FopSP_DataFile, "rb");
            //TempFile = fopen(TempFilePath, "wb");
            Execute1553();
        }
  
       else if(0 == stricmp("DirectFlash", argv[i]))
        {
             Interrogator_OFP_Select = INT_OFP_DMV_179;
             DirectFlashProgFlag = TRUE;
             ISP_file = fopen(FopISP_DataFile, "rb");
             SP_file  = fopen(FopSP_DataFile, "rb");
            //TempFile = fopen(TempFilePath, "wb");
             Execute1553();
        }
  
        else if(0 == stricmp("SRecord", argv[i]))
        {
             Interrogator_OFP_Select = INT_OFP_DMV_183;
             DirectFlashProgFlag = TRUE;
             ISP_file = fopen(FopISP_DataFile, "rb");
             SP_file  = fopen(FopSP_DataFile, "rb");
             //TempFile = fopen(TempFilePath, "wb");
             Execute1553();
        }
  
        else
        {
            fprintf(stderr, "Unknown parameter: %s", argv[i]);
        }
    }

Originally Posted by HelpfulPerson

Why do you do 0 == value.

It is done so the erroneous construction

Code:

0 = value

will cause the compilation error on any compiler, not a warning on smart one.

The only mistake I see in your program is that you start your for loop at 0 whereas it should start at 1.
argv[0] contains the program name (or possibly an empty string).

EDIT:
When you way that nothing happens, what do you expect to happen?
It's hard to see how the files will be read from since the FILE*'s are local to main.
(Could they be shadowing global FILE*'s?)

you should first determine - which part of your code is at fault

So start by

Code:

int main(int argc, char *argv[])
{
    FILE   *ISP_file;
    FILE   *SP_file;
    //FILE   *TempFile;

    int i = 0;

    for(i = 0;i < argc; i++)

    {

        if(0 == stricmp("Interrogator", argv[i]))
        {
            printf ("Parameter %d read - Interrogator", i);
        }

        else if(0 == stricmp("MLV_PLV_179", argv[i]))
        {
            printf ("Parameter %d read - MLV_PLV_179", i);
            SP_file  = fopen(FopSP_DataFile, "rb");
            if(!SP_file)
            {
                printf ("Could not open file %s", FopSP_DataFile);
            }
        }
        etc

And run such program with different combination of parameters

Do you close your files somewhere?

Why don't you pass the handles to the open files to the function which should process them?

When you check that your parameter parsing code works as desired - add calls to your processing function - making just debugging prints inside it making sure that all passed parameters are correct.

And only then add the code which actually does the work.

you declare function like this

Code:

int Execute1553(FILE   *ISP_f, FILE   *SP_f);

and call it like this

Code:

if(Execute1553(ISP_file,SP_file) != 0)
   printf("Calculation failed\n");

Originally Posted by jwernig

Can I do that inside the strcmp parameter brackets?

Calling? yes
Declaring - better do it in h file of before main in the c-file (depends where the function body is located)

You should start looping at i = 1 because the first arguments argv[0] is the program name as you write at the terminal

Code:

int  i = 1;
for ( i = 1 ; i < argc ; i++ ){
//code
}