Is it okay to remove preprocessor #ifs in linux header?

[Syscal]

for one reason or another, part of the arp header fields were excluded using a "#if 0" statement... I went in and changed the 0 to a 1 so I could compile my program. Do you guys see anything wrong with doing this?

Specifically, I'm talking about the "#if 0" thats in "net/if_arp.h" which excludes some members of the arp header structure. I understand that if the code is distributed to someone else I'd have to have them remove that as well. Anything else wrong with doing this? I've read that It's used as sorta a shortcut to comment out large blocks of code. Maybe I'll start doing this too. I like it.

[jimblumberg]

No, you shouldn't modify this header, or any other system header file for that matter.

Jim

[Syscal]

No, you shouldn't modify this header, or any other system header file for that matter.

Jim

Then what do you recommend? Cause that's definitely what I have done. I could define this header myself I suppose.

[laserlight]

Generally, no, unless you actually understand why those were "commented out". A somewhat safer solution might be to copy them into a header of your own, so your change to the header won't affect code that does not belong to you.

I've read that It's used as sorta a shortcut to comment out large blocks of code. Maybe I'll start doing this too. I like it.

Yes.