Thread: Mysterious number is being printed.

Indeed - calm down It'd be very helpful to see an example that will compile and run. Or at least an example which shows your fopen, fscanf, fprintf calls and all the variables they use.

Originally Posted by arti

Code:

fscanf(inputFILE, "%s%s", s, c)// scan file and find sabre corporation
fprintf(inputFILE, COMPANYNAME, s, c) //COMPANYNAME contains the formatting "%s%s"

Is that meant to be an fprintf to stdout? You can't fprintf to inputFILE if you've opened it for reading. I guess that's just a typo?

My guess would be that your fscanf isn't reading anything and the garbage in s and c is just uninitialised stuff, rather than garbage being read from the file. If you initialise c and s to a known value:

Code:

char s[30] = "Nothing";
char c[30] = "Nothing";

Then you can see if fscanf is reading garbage or reading nothing. That's not very "proper" but it's easy to understand.

If it's reading nothing, you can check feof() and ferror() to find out if end of file was reached or if an error occured.

There doesn't seem to be anything fundamentally wrong with what you posted -- that fscanf should read the file two words at a time. So the problem must be in some code you've not posted yet!

Originally Posted by smokeyangel

Indeed - calm down It'd be very helpful to see an example that will compile and run. Or at least an example which shows your fopen, fscanf, fprintf calls and all the variables they use.



Is that meant to be an fprintf to stdout? You can't fprintf to inputFILE if you've opened it for reading. I guess that's just a typo?

My guess would be that your fscanf isn't reading anything and the garbage in s and c is just uninitialised stuff, rather than garbage being read from the file. If you initialise c and s to a known value:

Code:

char s[30] = "Nothing";
char c[30] = "Nothing";

Then you can see if fscanf is reading garbage or reading nothing. That's not very "proper" but it's easy to understand.

If it's reading nothing, you can check feof() and ferror() to find out if end of file was reached or if an error occured.

There doesn't seem to be anything fundamentally wrong with what you posted -- that fscanf should read the file two words at a time. So the problem must be in some code you've not posted yet!

Code:

#define CHECK         "************************************************************\n" 
#define CHECKBORDER   "*                                    Check No. %3d         *\n"
#define CHECKFORMAT   "*                                                          *\n"
#define COMPANYNAME   "*      %7s%9s                                                    *\n"

#define CHECKFORMAT1  "*      Pay to the Order of                                 *\n"
#define CHECKNAME     "*      %s                                        *\n"
My defines that have to do with the file

Code:

char s[30] = "Nothing";
char c[30] = "Nothing";

Then you can see if fscanf is reading garbage or reading nothing. That's not very "proper" but it's easy to understand.

If it's reading nothing, you can check feof() and ferror() to find out if end of file was reached or if an error occured.

There doesn't seem to be anything fundamentally wrong with what you posted -- that fscanf should read the file two words at a time. So the problem must be in some code you've not posted yet![/QUOTE]

Actually it wasn't a typo; it is the end of the semester and I am struggling to pass this problem so i foolishly thought that maybe that was the problem....knowing full well it wouldn't work. I have put

Code:

s[30]="Sabre" 
c[30]="Corporation"

I then compiled the program and ran it and this is what I got...nothing
Attachment 12744


I then just fixed the "typo" and I put "fprintf(stdout, COMPANYNAME, s, c)

Code:

fprintf(stdout, CHECK);
fprintf(stdout, CHECKBORDER, number);
fprintf(stdout,CHECKFORMAT);
fscanf(inputFILE, "%s%s", s, c);

fprintf(stdout, COMPANYNAME, s, c);

I got this output :/
Attachment 12745

Originally Posted by Matticus

Can you post the updated code? It's a lot easier to help with something to reference.



Try to remain calm - you'll get nowhere good being frantic.

Will do Matticus. Sorry for responding late...just got online

Originally Posted by arti

Will do Matticus. Sorry for responding late...just got online

This is what i currently have in my code. I have provided the output

Code:

/*   Program: Assign2c
     Course: CISP360
     Author: Arturo
     Purpose: Payroll Program
     Date: 03/20/13

     Software   Change    Record
     Date       Who       What
     03/20      Arturo    Second Program
*/

#include<stdio.h>
#include<string.h>
#include<stdlib.h>

void printReport( FILE **inputFILE);


#define CHECK         "************************************************************\n"
#define CHECKBORDER   "*                                    Check No. %3d         *\n"
#define CHECKFORMAT   "*                                                          *\n"
#define COMPANYNAME   "*      %7s%9s                                                    *\n"

#define CHECKFORMAT1  "*      Pay to the Order of                                 *\n"
#define CHECKNAME     "*      %s                                        *\n"

int main(void)
{
  char S_name[12+10];
 
  char s[30]="Sabre";
  char c[30]="Corporation";
  
  int number=100;
  FILE * inputFILE;
  printReport( &inputFILE);



  fprintf(stdout, CHECK);
  fprintf(stdout, CHECKBORDER, number);
  fprintf(stdout,CHECKFORMAT);
  fscanf(inputFILE, "%s%s", s, c);

  fprintf(stdout, COMPANYNAME, s, c);


  fprintf(stdout,CHECKFORMAT1);
  fprintf(stdout,CHECKNAME, S_name);
  
  fclose(inputFILE);
 

  while(getchar()!= '\n');
  getchar;
  return 0;
}


void printReport( FILE **inputFILE)
{
 
  *inputFILE=fopen("./check.txt","r");
  if(*inputFILE==NULL)
  { 
    printf("File cannot be accessed");
    exit(-80);
  }
}

Code:

fscanf(inputFILE, "%s%s", s, c);

How does the first line of your text file look like?
You should always check the return value of fscanf(). In your case it should be 2.

Bye, Andreas

Originally Posted by AndiPersti

Code:

fscanf(inputFILE, "%s%s", s, c);

How does the first line of your text file look like?
You should always check the return value of fscanf(). In your case it should be 2.

Bye, Andreas

I found out the problem. See I was hard coding "check no" but i was also putting "check no" in the file so it was only picking that up. I don't know how I could have missed that.

Code:

#define CHECKBORDER   "*                                    Check No. %3d         *\n"

I have a question though because there is spacing between Sabre Corporation in the file and also I have formatted it in, why does the output on the screen look like this "SabreCorporation"?

Code:

#define COMPANYNAME   "*      %8s%10s                                                    *\n"

10 characrters is not enough for "Corporation" and alignement is right
use "%-6s%11s"
Kurt

Originally Posted by ZuK

10 characrters is not enough for "Corporation" and alignement is right
use "%-6s%11s"
Kurt

Thank you Kurt!!

Originally Posted by arti

Thank you Kurt!!

I want to read from the file then print to the screen the city and the state "New Corio, New Mexico"; however, I can't store the city or the state in a single variable?
My variables for those two are

Code:

city[30];
state[30];

If city and state is on a single line in the inputfile then you could use fgets() to read the line and split the strings at the comma using strtok().
Kurt

Originally Posted by ZuK

10 characrters is not enough for "Corporation" and alignement is right
use "%-6s%11s"
Kurt

This is an updated code that gets the city and state and zip code. I'm doinv everything that I did but now it isn't working

Code:

/*   Program: Assign2c
     Course: CISP360
     Author: Arturo
     Purpose: Payroll Program
     Date: 03/20/13
 
     Software   Change    Record
     Date       Who       What
     03/20      Arturo    Second Program
*/
 
#include<stdio.h>
#include<string.h>
#include<stdlib.h>
 
void printReport( FILE **inputFILE);
 
 
#define CHECK         "************************************************************\n"
#define CHECKBORDER   "*                                    Check No. %3d         *\n"
#define CHECKFORMAT   "*                                                          *\n"
#define COMPANYNAME   "*      %7s%9s                                                    *\n"
#define CITYSTATE         "*       %s%s%d           *\n" 
#define CHECKFORMAT1  "*      Pay to the Order of                                 *\n"
#define CHECKNAME     "*      %s                                        *\n"
 
int main(void)
{
  char S_name[12+10];
  
  char s[30];
  char c[30];
  char h[30];
  char w[30];
  char state[30];
  char city[30];
  int zipcode;
  int address;
  int number=100;
  FILE * inputFILE;
  printReport( &inputFILE);
 
  fprintf(stdout, CHECK);
  fprintf(stdout, CHECKBORDER, number);
  fprintf(stdout,CHECKFORMAT);
  fscanf(inputFILE,"%s%s", s, c);
  fprintf(stdout,COMPANYNAME, s, c);
  fscanf(inputFILE, "%d%s%s", &address, h, w);
  fprintf(stdout, COMPANYADDRESS, address, h, w);
  fscanf(inputFILE, "%s%s%d", city, state, &zip_code);
  fprintf(stdout, CITYSTATE, city, state, zip_code);

 
   fclose(inputFILE);
  
 
  while(getchar()!= '\n');
  getchar;
  return 0;
}
 
 
void printReport( FILE **inputFILE)
{
  
  *inputFILE=fopen("./check.txt","r");
  if(*inputFILE==NULL)
  { 
    printf("File cannot be accessed");
    exit(-80);
  }
}

Originally Posted by ZuK

If city and state is on a single line in the inputfile then you could use fgets() to read the line and split the strings at the comma using strtok().
Kurt

Ahh okay but I have tried to use fgets other times and it doesn't print to the screen; I have seen it done by fprintf and printf and other forums it has been suggested i use fputs or puts, but none have worked. THe line of code i would put would be

Code:

#define MAXLINE 250;
char line3[MAXLINE];
fgets(line3, MAXLINE, inputFILE);
puts(line3);

but it wouldn't work.

Code:

#define MAXLINE 250
char line3[MAXLINE];
fgets(line3, MAXLINE, inputFILE);
gets(line3);

this didn't work....the command line didn't even show up

Originally Posted by arti

but it wouldn't work.

How doesn't it work ?
Kurt

Originally Posted by arti

...the command line didn't even show up

That's because a previous scanf() left a '\n' in the input buffer.
It's never a good idea to mix scanf() and fgets.
Kurt