Thread: Code review needed

Hello there. This is a small program that reads a line from the screen, takes the ASCII values from the entered text, and edits it. Next, the ASCII values are reintepreted(am i misspelling?) as text, and displayed. However, my final output has (allways?) at least 7 characters, even if you enter only one. I'm allso trying to accomplish, that the part of the string which isn't filled, will be printed empty. In spaces.

compiled with -std=c99.

Code:

#include <stdio.h>

int main(){
    int maxsize;
    printf("How long is your message?\n");
    scanf("%d",&maxsize);
    int iinput[maxsize], ioutput[maxsize], key, c;
    char cinput[maxsize], coutput[maxsize];
    
    printf("What is the message you want to (de)code?\n");
    scanf("%s",cinput);
    for(int i=0;i<maxsize;i++){
        iinput[i]=(int)cinput[i];
    }
    printf("Thank you. ");
    printf("What is your key?\n");
    scanf("%d",&key);
    lchoice:
    printf("1 for coding, 2 for decoding.\n");
    scanf("%d",&c);
    switch (c)
    {
        case 1:
            for(int j=0;j<maxsize;j++){
                ioutput[j]=iinput[j]+key;
            }
            for(int k=0;k<maxsize;k++){
                coutput[k]=(char)ioutput[k];
            }
            break;
        case 2:
            for(int j=0;j<maxsize;j++){
                ioutput[j]=iinput[j]-key;
            }
            for(int k=0;k<maxsize;k++){
                coutput[k]=(char)ioutput[k];
            }
            break;
        default:
            printf("You did not enter 1 or 2.\n");
            goto lchoice;
    }
    printf("This is the coded message:\n");
    printf("%s\n",coutput);
    system("pause");
    return(0);
}

I would really appreciate some help. Thanks in advance.

Your loops are running from zero to maxsize. If maxsize exceeds the number of characters input, you need to output less than maxsize characters.

ASCII values are text. The character 'A' ALSO has a numeric (integral) value of 65 (at least in the ASCII character set - the value is different in other character sets). Your "reinterpreting" suggests you don't understand that principle.

Plenty of people will suggest you need to wash your mouth out with soap and water for using a goto as well.

When you use the %s format to input a string, the data is stored to an array of char with a terminating character that has value zero. So, given the code "scanf("%s",cinput)" if the user enters "AB" followed by the enter key, the array cinput receives the characters 'A', 'B', and '\0' (a character with value zero). Two characters entered, three into the array. You can detect that zero to find the end of the string. Rather than do it manually, use functions from <string.h> (eg strlen()) which work with strings like that.

That is a convention in C. A "string" is an array of char with a zero marker appended.

An aside: it is not a good idea to use an unadorned %s format in scanf(). Let's say cinput is an array of five characters, and the user enters "ABCDEFG". That will result in eight characters (the 7 letters plus terminating zero) being written to an array that can only hold five characters. You can't stop a user misbehaving, but can cope with that by using the %4s format, which causes scanf() to stop reading the string if the user has entered too much.

To avoid the goto, loop up thing like "loops". There are various types of looping constructs in C, such as the while loop. For example;

Code:

int continuing = 1;
while (continuing)
{
     stuff_you_want_to_do_more_than_once();
     if (want_to_exit()) continuing = 0;   /*  cause the looping to stop */
}

There are other ways of looping, each suited to some circumstances better than others.

Originally Posted by BramvandenH

I was wondering: if you declare a string like this:

Code:

char string[5]

will the NULL character be in string[4], or string[5]? or in string[5] and string[6]?

If you declare an array to have 5 elements, then the valid indices for the array are from 0 to 4, inclusive. Therefore, string[5] is out of bounds, as is string[6]. The null character can thus be in string[0] (i.e., the string is empty), or string[1], or string[2], or string[3], or string[4], as the case may be.