Thread: Linked List with CHAR

And one forum
Leaving this one open, as the code is marginally more readable.

Code:

}/*end of display() */

No no no, that's not how you make the end of a function obvious.
What you are supposed to do is to use correct indentation.
I'm not helping you out with such horribly formatted code.

Here, this is what code is supposed to look like with indentation.

Code:

#include<stdio.h>
#include<stdlib.h>

struct node {
  int priority;
  int info;
  struct node *link;
} *front = NULL;

void insert(char person[20], int person_priority);
int del();
void display();
int isEmpty();

int main() //!! fixed
{
  int choice, person_priority;
  char person[20];

  while (1) {
    printf("1.Insert Person\n");
    printf("2.Attend Client\n");
    printf("3.Show Queue\n");
    printf("4.Exit\n");
    printf("Type choice : ");
    scanf("%d", &choice);

    switch (choice) {
    case 1:
      printf("Type persons name:");
      scanf("%s", &person);
      printf("Its Priority:\n1 Pregnant\n2 Older\n3 Standard: ");
      scanf("%d", &person_priority);
      insert(person, person_priority);
      system("cls");
      break;
    case 2:
      system("cls");
      printf("Person was attended", del());
      break;
    case 3:
      system("cls");
      display();
      break;
    case 4:
      exit(1);
    default:
      printf("Invalid Choice\n");
    }                           /*end of switch */
  }                             /*end of while */
  return 0;   //!! fixed
}                               /*end of main() */


void insert(char person[20], int person_priority)
{
  struct node *tmp, *p;

  tmp = (struct node *) malloc(sizeof(struct node));

  if (tmp == NULL) {
    printf("No Memory available\n");
    return;
  }

  tmp->info = person;
  tmp->priority = person_priority;
/*Starting list*/
  if (isEmpty() || person_priority < front->priority) {
    tmp->link = front;
    front = tmp;
  }
  else {
    p = front;
    while (p->link != NULL && p->link->priority <= person_priority)
      p = p->link;
    tmp->link = p->link;
    p->link = tmp;
  }
}                               /*end of insere() */

int del()
{
  struct node *tmp;
  int person;

  if (isEmpty()) {
    printf("Empty Queue\n");
    exit(1);
  }
  else {
    tmp = front;
    person = tmp->info;
    front = front->link;
    free(tmp);
  }

  return person;
}                               /*end of del() */

int isEmpty()
{
  if (front == NULL)
    return 1;
  else
    return 0;
}                               /*end of emtpy verification (isEmpty()) */

void display()
{
  struct node *ptr;
  ptr = front;
  if (isEmpty())
    printf("Empty Queu\n");
  else {
    printf("Line :\n");
    printf("Priority       Name\n");
    while (ptr != NULL) {
      printf("%5d        %5s\n", ptr->priority, ptr->info);
      ptr = ptr->link;
    }
    printf("\n\n\n");
  }
}                               /*end of display() */

Next, get a better compiler, turn up the warning level, and pay attention to what it says.

Code:

$ gcc -Wall bar.c
bar.c: In function ‘main’:
bar.c:31:7: warning: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘char (*)[20]’ [-Wformat]
bar.c:39:7: warning: too many arguments for format [-Wformat-extra-args]
bar.c: In function ‘insert’:
bar.c:66:13: warning: assignment makes integer from pointer without a cast [enabled by default]
bar.c: In function ‘display’:
bar.c:119:7: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘int’ [-Wformat]

One problem seems to be that you only have "int person" in your struct, yet everywhere else in your code, person is a char array.

You need to fix the info field so it's an array of characters. I also prefer to keep the link pointers at the start of structures or classes, since you can use generic code for handling linked list by casting to a generic struct or class that only has the link pointers (or use inhertiance from a class with only the link pointer(s)).

Code:

struct node {
    struct node *link; 
    int priority; 
    char info[20]; 
} *front = NULL;

or perhaps use typedefs:

Code:

typedef struct node {
    struct node *link; 
    int priority; 
    char info[20]; 
}node_t;
node_t *front = NULL;