Thread: i have infinite loops. why?

Try make answer a char instead of an int.

I wasn't going to get involved, as I normally skip over code postings that lack [code] tags, but here are some hints:[list=1][*]If the user indicates s/he wants another run, reinitialize your count variable (it still holds the value from the last run).[*]scanf() is leaving a carriage return in the input buffer when you ask the user if they want another turn. This carriage return causes the next scanf() ("Enter an integer") to return early.[/list=1]If that helps in any way, you can thank me by using [code] tags in the future ;)

Originally posted by Salem
Oh what a mish-mash of half truths we have here....

That is my biggest problem with this board. There is alot of people answearing things they don't really know. As a rule of thumb "Always check the replies you get in here with a book or some reliable source" There is only a hand full of people I really trust to know what they are talking about in here.

>There is alot of people answearing things they don't really know.
That I can tolerate, that is why these are called discussion forums. Anyone can answer and if they are wrong they will be corrected in short order.

>Oh what a mish-mash of half truths we have here....
Quite.

>>scanf("%i", &num);
>Shouldn't this be
>scanf("%d", &num);
Why? In actual practice %i and %d can be used the same way, though %i is a bit more generic as it can be used to scan in non-decimal values whereas %d doesn't have that feature.

-Prelude

#include <stdio.h>
#include <conio.h>

int main()
{
char answer;
int num, count, total, max;
float average;

clrscr();
do
{
count=0, total=0, num=0;
printf("\n");
printf("Enter an integer: ");
scanf("%d", &num);


while ( count < 3 && num > 0 )
{
count=count + 1;
total += num;
if ( num > max )
{
max = num;

}

printf("Enter next integer: ");
scanf("%d", &num);
}

if ( count > 0 )
{
printf("\n");
printf("The maximum number is %i\n", max);
printf("the count is %i\n", count);
printf("the total is %i\n", total);
average= (float)total / count;
printf("the average in two decimal point is %.2f\n", average);
printf("\n");


}

else
{
printf("No valid number were entered\n");
}

printf("End of run. Another run? Y/N: ");
answer=getchar();

}while ( answer !='N' || answer != 'n');

return(0);
}


Problems: the loops is soft of working, but can read char,
once i read char, i have an infinite loops . .

thanks deckard u got me thinking a little, i set count =0, max=0, and total =0

Here is a working code:

#include <stdio.h>
#include <conio.h>

int main()
{
char answer;
int num, count, total, max;
float average;

clrscr();
do
{
count=0, total=0, num=0;
printf("\n");
printf("Enter an integer: ");
scanf("%d", &num);


while ( count < 9 && num > 0 )
{
count += 1;
total += num;
if ( num > max )
{
max = num;

}

printf("Enter next integer: ");
scanf("%i", &num);

}

if ( count > 0 )
{
printf("\n");
printf("The maximum number is %i\n", max);
printf("the count is %i\n", count);
printf("the total is %i\n", total);
average= (float)total / count;
printf("the average in two decimal point is %.2f\n", average);
printf("\n");


}

else
{
printf("No valid number were entered\n");
}

printf("End of run. Another run? Y/N: ");
answer=getchar();

}while ( (answer=getchar()) != 'n' && (answer=getchar()) != 'N');

return(0);
}


Thanks to those that helped me out, getchar() do work
why scanf dont work in getting a character?

Here is how to get scanf working to read a single character, in a single line of code:

scanf("%c%*c", &mychar );

Or:

scanf("%c%*[^\n]", &mychar );

I think the second one will work also. That one should be "buffer safe".

Quzah.