Thread: Null pointer asignement in turbo C on DOSBOX

The code is as follows.

Code:

struct encrypt
{
	unsigned int signature;
	unsigned long hash;
	unsigned start_offset;
	unsigned long long length;
} encfile;


void main()
{
	unsigned long crchash;
  //	unsigned long long adlerhash;

	char filename[25];
	char filename2[25] ="enc";
	char password[20];
	unsigned long long len;
	unsigned int *sig;
	FILE *file1, *file2;
	char *buffer;
	char *buffer2;	//buffer to hold the file data.
	clrscr();
	fflush(stdin);

	printf("\n\n\t\t\t\tFILE ENCRYPTER V 0.1B");
	printf("\\n\nEnter Filename: ");
	gets(filename);
	if(file1 = fopen(filename,"rb") == NULL)
	{
		printf("\n\n\n\n\t\t\tError: Cannot open File. ");
		exit(-1);
	}
	fseek(file1, 0, SEEK_END);
	len = ftell(file1);
	fseek(file1, 0, SEEK_SET);

	if((buffer = (char *) malloc(len+1)) == NULL)
	{
		clrscr();
		printf("Cannot allocate memory...in first malloc");
		fclose(file1);
		exit(-2);
	}

	fread(buffer, len, 1, file1);

	memcpy(sig, buffer, 2);
	if(*sig != 0x0E1C)
	{


		clrscr();
		printf("Enter password to encrypt the file: ");
		gets(password);
		crchash = crc32(password, strlen(password));
		encfile.signature = 0x0E1C;
		encfile.hash = crchash;
		encfile.start_offset = 0x06;
		encfile.length = len;

		if((buffer2 = (char *) malloc(sizeof(encfile)+len+1)) == NULL)
		{
			clrscr();
			printf("Cannot allocate memory...in second malloc");
			fclose(file1);
			exit(-2);
		}

		memcpy(buffer2, &encfile, sizeof(encfile));
		memcpy(buffer2, buffer, len);

		strcat(filename2, filename);

		if(fopen(filename2, "wb") == NULL)
		{
			printf("\n\n\n\t\tCannot create file...");
			fclose(file1);
			exit(-1);
		}

		fwrite(buffer, sizeof(encfile)+len+1, 1, file2);

		printf("\n\nFile encrypted....");
		getch();
	}



}

Pls take note that i have only done the encrypting conditon . but the error is on the fairst malloc call to allocate memeory to the buffer..
Can you please guide me what am i doing wrong.

Can you please guide me what am i doing wrong.

Start with
void main()
gets()
fflush(stdin)

but the error is on the fairst malloc call

What first malloc call? I don't see malloc anywhere.

But probably the biggest mistake is:

turbo C

Jim

@jim, i cant use any other compile bcoz its for my college project and i cant use other compilers that 16 bit turbo c compiler. I think malloc shouldnt fail on small files but is failing so to my knowledge i must be doing some wrong pointer operations there, but cant figure out myself.. Can someone elaborate it..

Have you tried printing the value of "len" to the screen (after line 35) to verify it is a valid value?

You might need another way to find the size of the file:

Setting the file position indicator to end-of-file, as with fseek(file, 0, SEEK_END), has
undefined behavior for a binary stream (because of possible trailing null characters) or for any stream
with state-dependent encoding that does not assuredly end in the initial shift state.

7.19.3

Yes like matticus said, i tried printing len and it returned to be -1. so that means i am not getting the file size correctly.
So how can i get file size correctly... and pls take note that i am doing this on a binary file not a plain text file. if it would had been a plain text i could have counted till EOF.

if it would had been a plain text i could have counted till EOF.

Just because the file is opened in binary mode there is no reason you can't count each character until you reach the end of file.

Jim

@jim is there a EOF character on the end of binary file, no not possible, to my knowledge i dont see that there are any marks or signs of file ending in binary files. The ends are calculated as per the entry in FAT.

EOF is not a character. Have you tried?

Jim

NO not yet!! its already 2:09 AM and my eyes are not helping me, i will come tomorrow after trying. time for some good sleep now. GOOD NIGHT.

After you get some rest, here's our FAQ on EOF: FAQ > Definition of EOF and how to use it effectively - Cprogramming.com

Also note I am not saying that counting characters in a binary file is the only way, or even the best way, to find the size of your file. But it will work.

Jim

Code:

for(length = 0; fread(&temp, sizeof(char), 1, filehandle) != EOF; len++);

So, i did this itertion till EOF and i think it should return length in length.
but it not working..