Thread: argv shell execvp

Well you could post your real code.

Originally Posted by Salem

Well you could post your real code.

I'd rather not post the exact code but I will describe it.

Code:

char stream[STORAGE]; 

for(;;) {                                   /* repeat until done         */
	(void) printf("p2: ");                  /* display a prompt          */
	parse(stream);                          /* parse the line            */
	
	if(fork() == 0) {
	    
	    execvp(newargv[0], newargv);
	    perror("exec");
	}

	break;
    }

the parse() function will delimites words and single metacharacters with a null. . . "hello there" will turn into "hellow\0there" and point each newargv accordingly so newargv[0] points to the h in this example. . . i know this part works but i keep getting an error on execvp "no file found . . . " even when the first word in the stream is a legit command like "echo something something"

Maybe you should do this until you get it right.

Code:

char stream[STORAGE];
 
for(;;) {                                   /* repeat until done         */
    (void) printf("p2: ");                  /* display a prompt          */
    parse(stream);                          /* parse the line            */
  
    for ( int i = 0 ; newargv[i] != NULL ; i++ ) {
        printf("Arg %d = >>%s<<\n", i, newargv[i] );
    }
//    if(fork() == 0) {
//         
//        execvp(newargv[0], newargv);
//        perror("exec");
//    }
 
    break;
    }

We can't tell you how your parser is broken without you posting it.