Trying to count vowels in a string assignment

**NCCMelissa** · 04-15-2002

Could someone look at this code and tell me what I'm doing wrong? I'm sure it's something simple...I just can't stare at it any longer. I'm using a function to count the number of vowels in a string input by the user. When I print the results, I get zero.

int numvowels (char line[], int length)
{ int b, count = 0;

for (b = 0; b <= length; b++)
{ if (line[b] == 'A')
count++;
if (line[b] == 'E')
count++;
if (line[b] == 'I')
count++;
if (line[b] == 'O')
count++;
if (line[b] == 'U')
count++;
if (line[b] == 'Y')
count++;
}
return count;
}

Thanks!

**xds4lx** · 04-15-2002

You have the right idea but you need to test for lower case also. So change it to this:

Code:

int numvowels(char line[],int length)
{    int count = 0;
     for(int b = 0; b < length; b++)
     {    if((line[b] == 'a' || line[b] == 'A') || 
             (line[b] == 'e' || line[b] == 'E') || 
             (line[b] == 'i' || line[b] == 'I') || 
             (line[b] == 'o' || line[b] == 'O') ||
             (line[b] == 'u' || line[b] == 'U') ||
             (line[b] == 'y' || line[b] == 'Y'))
           {    count++;
           }
     }
     return(count);
}

**NCCMelissa** · 04-15-2002

Thanks, it works perfectly!

**Salem** · 04-15-2002

It would be a lot easier (and perhaps more useful) is you had two functions

isvowel(c)
Returns true if c is a vowel, false otherwise. See all the other 'is' functions in ctype.h for inspiration.

numvowels
Which just calls isvowel in a loop, and counts the number of times it returns true

**NCCMelissa** · 04-15-2002

Thanks for your thoughts. Part of the assignment was to only use the function strlen() and do it the hard way. I will definitely keep the other functions handy in the future.

**xds4lx** · 04-15-2002

Well for something this simple that is a good idea, but why involve the overhead of function calls if you dont need to? I know this is something simple and it shouldnt matter, but you should never do more than what you are asked for in an assignment (im speaking from experience), some teachers really dont like that and will actually mark you down.

**Bull** · 04-16-2002

Think it depends on the lecturer, but if they specifically say to do it a specifc way then ya probly right with that, but most of my lecturer's when I was at uni gave extra marks for doing extra onto the requirements, but that was second year in the subject with asm.

**xds4lx** · 04-16-2002

While that is true, most teachers dont want you to do more than what you are asked. I had a few prof's that were sticklers for the rules and if you did anything not specified by the assigment implicity or explicity you would be marked down. But then again I had some teachers that were just amazed that you went beyond the requirements. But for safety's sake just do what you are asked and add the more in for your self, just turn in the required work, and expand the problem if you like it. My teacher really didnt like me adding AI into the tic-tac-toe program that we mad for our data structures class so just stick to what your told.

**Bull** · 04-16-2002

he probly couldnt work out how it worked and felt stupid so he marked ya down just to show you that hes the one marking.

Thread: Trying to count vowels in a string assignment

Thread Tools

Search Thread

Display

Trying to count vowels in a string assignment

Similar Threads

Menu

String issues

A mini-compilier I made stuck in an infinite loop (lots of code)

String editor for a sentence inputted by a user - any suggestions or ideas?

"Operator must be a member function..." (Error)