Thread: Cprogram for grades.....pls help

input
.grade
.equivalent
.remarks

output
...grade
...equivalent remarks
1- 95- 91
2- 90-86
3- 85-81
4 80-76
5- 75-70
above 95 notin range
below 69 mot in range



......remarks passed or failed
75-95 passed
74-70 failed

Code:

#include<stdio.h>
#define s scanf
#define p printf

main()
{
    char fn[25],sn[25];
    char tf[25],sf[25];
    char sec[25],sub[25];
    float gr;
    char answer;

    clrscr();



        p("Enter your Name: ");
        s("%s %s",&fn,sn);

        p("Enter your Section: ");
        s("%s",&sec);

        p("Enter your Subject: ");
        s("%s",&sub);

        p("Enter Name of your teacher: ");
        s("%s %s ",&tf,sf);

        p("Enter your Grade:");
        s("%f",&gr);

        clrscr();
    do
    {
        if (95>=gr && gr>=91)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 1\n");
            p("REMARKS: PASSED \n");
        }

        else if (90>=gr || gr>=86)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 2\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr<=85 || gr>=81)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 3\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr<=80 || gr>=76)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 4\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr<=75 || gr>=70)
        {
           if (gr>=70 || gr<75)
            {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 5\n");
            p("REMARKS: FAILED \n");
            }
            else
            {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: 5\n");
            p("REMARKS: PASSED \n");
             }
        }
        else
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,sf);
            p("Grade : %0.f\n",gr);
            p("Equivalent Remarks: Not in Range\n");
            p("REMARKS: Not in Range \n");
         }

        clrscr();

    p("Would your like to try again? [y/n]");
    answer=getch();
    }
    while (answer=='Y' || answer=='y');
    exit();
    getch();

getch();
}

--this is not working--

example
if grade was 95 the
grade:95
equvalent: 5
remarks: passed

if grade was 74 the
grade:74
equvalent: 5
remarks: failed

if grade was 96 the
grade:96
equvalent: nto in range
remarks: not in range

Well you might want to start fixing the following warnings and errors:

Code:

mingw32-gcc.exe -Wall  -g  -pedantic -Wextra -Wall -g    -c C:\Users\Josh2\Documents\bar\main.c -o obj\Debug\main.o
C:\Users\Josh2\Documents\bar\main.c:5:1: warning: return type defaults to 'int' [-Wreturn-type]
C:\Users\Josh2\Documents\bar\main.c: In function 'main':
C:\Users\Josh2\Documents\bar\main.c:13:5: warning: implicit declaration of function 'clrscr' [-Wimplicit-function-declaration]
C:\Users\Josh2\Documents\bar\main.c:18:9: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'char (*)[25]' [-Wformat]
C:\Users\Josh2\Documents\bar\main.c:21:9: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'char (*)[25]' [-Wformat]
C:\Users\Josh2\Documents\bar\main.c:24:9: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'char (*)[25]' [-Wformat]
C:\Users\Josh2\Documents\bar\main.c:27:9: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'char (*)[25]' [-Wformat]
C:\Users\Josh2\Documents\bar\main.c:119:5: warning: implicit declaration of function 'getch' [-Wimplicit-function-declaration]
C:\Users\Josh2\Documents\bar\main.c:122:5: warning: implicit declaration of function 'exit' [-Wimplicit-function-declaration]
C:\Users\Josh2\Documents\bar\main.c:122:5: warning: incompatible implicit declaration of built-in function 'exit' [enabled by default]
C:\Users\Josh2\Documents\bar\main.c:122:5: error: too few arguments to function 'exit'
C:\Users\Josh2\Documents\bar\main.c:126:1: warning: control reaches end of non-void function [-Wreturn-type]
Process terminated with status 1 (0 minutes, 0 seconds)
1 errors, 10 warnings

These are rather important errors that could contribute to it "not working".

getch(), clrscr(), exit() ... do you even know where these functions come from? You need to include the relevant headers.

#define s scanf
#define p printf

You do not understand how hard I want you to hit the delete key for these two statements. I want you to hit it so hard, that can't be typed ever again in that particular arrangement.

I l I d t w a w s w o c.
(It's like I decided to write a whole sentence with one character)

Code:

#include<stdio.h>
#define s scanf
#define p printf

main()
{
    char fn,sn;
    char tf,sf;
    char sec,sub;
    float gr;

    clrscr();

    do
    {
        p("Enter your Name: ");
        s("%s %s ",&fn,sn);
        
        p("Enter your Section: ");
        s("%s",&sec);

        p("Enter your Subject: ");
        s("%s",&sub);

        p("Enter Name of your teacher: ");
        s("%s %s ",&tf,ts);

        p("Enter your Grade:");
        s("%f",&gr);

        clrscr();

        If (gr=<95 || gr>=91)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 1\n");
            p("REMARKS: PASSED \n");
        }

        else if (gr=<90 || gr>=86)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 2\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr=<85 || gr>=81)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 3\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr=<80 || gr>=76)
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 4\n");
            p("REMARKS: PASSED \n");
        }


        else if (gr=<75 || gr>=70)
        {
           if (gr>=70 || gr<75)
            {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 5\n");
            p("REMARKS: FAILED \n");
            }
            else
            {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: 5\n");
            p("REMARKS: PASSED \n");
             }            
        }
        else 
        {
            p("Student Name: %s %s\n",fn,sn);
            p("Section: %s\n",sec);
            p("Subject: %s\n",sub);
            p("Teacher Name: %s %s\n",tf,ts);
            p("Grade : %0.f\n",gr)
            p("Equivalent Remarks: Not in Range\n");
            p("REMARKS: Not in Range \n");
         }
        
        clrscr();
        
    p("Would your like to try again? [y/n]")
    answer=getch();
    }
    while (answer=='Y' || anwer=='y')
    exit();
    getch();    
        
getch();
}

Concerning the code in #6 I would like to know if you even thought about what you did, or tried it. Because it should crash.

scanf requires an address to store information from the user in, just like all versions of scanf. Now, since an array decays to a pointer to the first element, which contains said address, you do not need to use the & operator on a character array. The proper response was NOT to nerf all of your arrays, as if to get the program to work by magic.

Code:

#include<stdio.h>

main()
{
    char firstname,surname;
    char teachername,teachersurname;
    char section,subject;
    float grade;

    clrscr();

    do
    {
        printf("Enter your Name: ");
        scanf("%s %s ",&firstname,surname);
        
        printf("Enter your section ");
        scanf("%s",&section);

        printf("Enter your subject: ");
        scanf("%s",&subject);

        printf("Enter Name of your teacher: ");
        scanf("%s %s ",&teachername,ts);

        printf("Enter your grade:");
        scanf("%f",&grade);

        clrscr();

        If (95>=grade || grade>=91)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %0.f\n",grade)
            printf("Equivalent Remarks: 1\n");
            printf("REMARKS: PASSED \n");
        }

        else if (grade=<90 || grade>=86)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %0.f\n",grade)
            printf("Equivalent Remarks: 2\n");
            printf("REMARKS: PASSED \n");
        }


        else if (grade=<85 || grade>=81)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %0.f\n",grade)
            printf("Equivalent Remarks: 3\n");
            printf("REMARKS: PASSED \n");
        }


        else if (grade=<80 || grade>=76)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %0.f\n",grade)
            printf("Equivalent Remarks: 4\n");
            printf("REMARKS: PASSED \n");
        }


        else if (grade=<75 || grade>=70)
        {
           if (grade>=70 || grade<75)
            {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %0.f\n",grade)
            printf("Equivalent Remarks: 5\n");
            printf("REMARKS: FAILED \n");
            }
            else
            {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("Grade : %0.f\n",grade)
            printf("Equivalent Remarks: 5\n");
            printf("REMARKS: PASSED \n");
             }            
        }
        else 
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("Grade : %0.f\n",grade)
            printf("Equivalent Remarks: Not in Range\n");
            printf("REMARKS: Not in Range \n");
         }
        
        clrscr();
        
    printf("Would your like to try again? [y/n]")
    answer=getch();
    }
    while (answer=='Y' || anwer=='y')
    exit();
    getch();    
        
getch();
}

no display output!!!

Code:

Code:

#include<stdio.h>
 
int main()
{
    char firstname[25],surname[23];
    char teachername[12],teachersurname[21];
    char section,subject;
    float grade;
 
//    clrscr();
 
    do
    {
        printf("Enter your Name: ");
        scanf("%s %s ",&firstname,surname);
         
        printf("Enter your section ");
        scanf("%s",&section);
 
        printf("Enter your subject: ");
        scanf("%s",&subject);
 
        printf("Enter Name of your teacher: ");
        scanf("%s %s ",&teachername,ts);
 
        printf("Enter your grade:");
        scanf("%f",&grade);
 
//        clrscr();
 
        if (95>=grade || grade>=91) //!! capitalised If
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 1\n");
            printf("REMARKS: PASSED \n");
        }
 
        else if (grade=<90 || grade>=86)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 2\n");
            printf("REMARKS: PASSED \n");
        }
 
 
        else if (grade=<85 || grade>=81)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 3\n");
            printf("REMARKS: PASSED \n");
        }
 
 
        else if (grade=<80 || grade>=76)
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 4\n");
            printf("REMARKS: PASSED \n");
        }
 
 
        else if (grade=<75 || grade>=70)
        {
           if (grade>=70 || grade<75)
            {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 5\n");
            printf("REMARKS: FAILED \n");
            }
            else
            {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("Grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: 5\n");
            printf("REMARKS: PASSED \n");
             }            
        }
        else
        {
            printf("Student Name: %s %s\n",firstname,surname);
            printf("section %s\n",section);
            printf("subject: %s\n",subject);
            printf("Teacher Name: %s %s\n",teachername,ts);
            printf("Grade : %.0f\n",grade); //!! missing ;
            printf("Equivalent Remarks: Not in Range\n");
            printf("REMARKS: Not in Range \n");
         }
         
        //clrscr();
         
    printf("Would your like to try again? [y/n]"); //!! missing ;
    answer=getchar(); //!! not getch
    }
    while (answer=='Y' || anwer=='y')
//     exit();
//     getch();    
//         
// getch();
    return 0; //!! added
}

Instead of continuing posting code which is full of errors I suggest to either ask specific questions or dump your garbage somewhere else.

Bye, Andreas