Hey Everyone
I am new to this forum
I have an issue with my C programming assignment
there are some error in simple C program
PLEASE !
If I paste the code here can anybody can help me that what mistake i have made ? while coding !
Hey Everyone
I am new to this forum
I have an issue with my C programming assignment
there are some error in simple C program
PLEASE !
If I paste the code here can anybody can help me that what mistake i have made ? while coding !
Welcome to the forum!!
Of course, here there are many very good programmers, who, for sure, can say something about every code they see!
Post your code in code tags
[key]/*your program*/[/key]
replace key with code in order this to work
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
Code:#include<stdio.h>#include<conio.h> void main() { /* Getting Inital Values */ int english,electronics,programming,itc,calculus; int sum,roll; //char grade_total[]; char grade_english[1]; char grade_electronics[1]; char grade_programming[1]; char grade_itc[5];char grade_calculus[5]; float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus; float percentage; char name[20]; //char remarks_total; char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10]; /* Getting User Personal Info */ printf("\n Please Enter Your Name : "); scanf("%d",&name); printf("\n Please Enter Your Roll Number : "); scanf("%d",&roll); /* Getting User Academic Record */ printf("\n Please Enter Your Marks in Programming : "); scanf("%d",&programming); printf("\n Please Enter Your Marks in Electronics : "); scanf("%d",&electronics); printf("\n Please Enter Your Marks in I.T.C : "); scanf("%d",&itc); printf("\n Please Enter Your Marks in Calculus : "); scanf("%d",&calculus); printf("\n Please Enter Your Marks in English : "); scanf("%d",&english); /* If Condition - Programming Marks - for GPA and Grade and Remarks */ if(programming>=85) { grade_programming="A+"; gpa_programming=4.0; grade_programming="Exceptional"; } if(programming>=80&&programming<=84) { grade_programming='A'; gpa_programming=3.7; remarks_programming="Outstanding"; } if(programming>=75&&programming<=79) { grade_programming="B+"; gpa_programming=3.4; remarks_programming="Excellent"; } if(programming>=70&&programming<=74) { grade_programming='B'; gpa_programming=3.0; remarks_programming="Very Good"; } if(programming>=65&&programming<=69) { grade_programming="B-"; gpa_programming=2.5; remarks_programming="Good"; } if(programming>=60&&programming<=64) { grade_programming="C+"; gpa_programming=2.0; remarks_programming="Average"; } if(programming>=55&&programming<=59) { grade_programming='C'; gpa_programming=1.5; remarks_programming="Satisfactory"; } if(programming>=50&&programming<=54) { grade_programming='D'; gpa_programming=1.0; remarks_programming="Pass"; } if(programming<=49) { grade_programming='F'; gpa_programming=0.0; remarks_programming="Fail"; } /* If Condition - English Marks - for GPA and Grade and Remarks */ if(english>=85) { grade_english='A'; gpa_english=4.0; remarks_english="Exceptional"; } if(english>=80&&english<=84) { grade_english='A'; gpa_english=3.7; remarks_english="Outstanding"; } if(english>=75&&english<=79) { grade_english="B+"; gpa_english=3.4; remarks_english="Excellent"; } if(english>=70&&english<=74) { grade_english='B'; gpa_english=3.0; remarks_english="Very Good"; } if(english>=65&&english<=69) { grade_english="B-"; gpa_english=2.5; remarks_english="Good"; } if(english>=60&&english<=64) { grade_english="C+"; gpa_english=2.0; remarks_english="Average"; } if(english>=55&&english<=59) { grade_english='C'; gpa_english=1.5; remarks_english="Satisfactory"; } if(english>=50&&english<=54) { grade_english='D'; gpa_english=1.0; remarks_english="Pass"; } if(english<=49) { grade_english='F'; gpa_english=0.0; remarks_english="Fail; } /* If Condition - Electronics Marks - for GPA and Grade and Remarks */ if(electronics>=85) { grade_electronics='A'; gpa_electronics=4.0; remarks_electronics="Exceptional"; } if(electronics>=80&&electronics<=84) { grade_electronics='A'; gpa_electronics=3.7; remarks_electronics="Outstanding"; } if(electronics>=75&&electronics<=79) { grade_electronics="B+"; gpa_electronics=3.4; remarks_electronics="Excellent"; } if(electronics>=70&&electronics<=74) { grade_electronics='B'; gpa_electronics=3.0; remarks_electronics="Very Good"; } if(electronics>=65&&electronics<=69) { grade_electronics="B-"; gpa_electronics=2.5; remarks_electronics="Good"; } if(electronics>=60&&electronics<=64) { grade_electronics="C+"; gpa_electronics=2.0; remarks_electronics="Average"; } if(electronics>=55&&electronics<=59) { grade_electronics='C'; gpa_electronics=1.5; remarks_electronics="Satisfactory"; } if(electronics>=50&&electronics<=54) { grade_electronics='D'; gpa_electronics=1.0; remarks_electronics="Pass"; } if(electronics<=49) { grade_electronics='F'; gpa_electronics=0.0; remarks_electronics="Fail; } /* If Condition - I.T.C Marks - for GPA and Grade and Remarks */ if(itc>=85) { grade_itc='A'; gpa_itc=4.0; remarks_itc="Exceptional"; } if(itc>=80&&itc<=84) { grade_itc='A'; gpa_itc=3.7; remarks_itc="Outstanding"; } if(itc>=75&&itc<=79) { grade_itc="B+"; gpa_itc=3.4; remarks_itc="Excellent"; } if(itc>=70&&itc<=74) { grade_itc='B'; gpa_itc=3.0; remarks_itc="Very Good"; } if(itc>=65&&itc<=69) { grade_itc="B-"; gpa_itc=2.5; remarks_itc="Good"; } if(itc>=60&&itc<=64) { grade_itc="C+"; gpa_itc=2.0; remarks_itc="Average"; } if(itc>=55&&itc<=59) { grade_itc='C'; gpa_itc=1.5; remarks_itc="Satisfactory"; } if(itc>=50&&itc<=54) { grade_itc='D'; gpa_itc=1.0; remarks_itc="Pass"; } if(itc<=49) { grade_itc='F'; gpa_itc=0.0; remarks_itc="Fail; } /* If Condition - Calculus Marks - for GPA and Grade and Remarks */ if(calculus>=85) { grade_calculus='A'; gpa_calculus=4.0; remarks_calculus="Exceptional"; } if(calculus>=80&&calculus<=84) { grade_calculus='A'; gpa_calculus=3.7; remarks_calculus="Outstanding"; } if(calculus>=75&&calculus<=79) { grade_calculus="B+"; gpa_calculus=3.4; remarks_calculus="Excellent"; } if(calculus>=70&&calculus<=74) { grade_calculus='B'; gpa_calculus=3.0; remarks_calculus="Very Good"; } if(calculus>=65&&calculus<=69) { grade_calculus="B-"; gpa_calculus=2.5; remarks_calculus="Good"; } if(calculus>=60&&calculus<=64) { grade_calculus="C+"; gpa_calculus=2.0; remarks_calculus="Average"; } if(calculus>=55&&calculus<=59) { grade_calculus='C'; gpa_calculus=1.5; remarks_calculus="Satisfactory"; } if(calculus>=50&&calculus<=54) { grade_calculus='D'; gpa_calculus=1.0; remarks_calculus="Pass"; } if(calculus<=49) { grade_calculus='F'; gpa_calculus=0.0; remarks_calculus="Fail; } /* Finalizing the Conditions */ sum=english+electronics+programming+itc+calculus; percentage=(sum*100)/500; gets(name); printf("\n Roll Number : %d ",roll); printf("\n English %d %f %s %s ",english,gpa_english,remarks_english,grade_english); printf("\n Electronics %d %f %s %s ",electronics,gpa_electronics,remarks_electronics,grade_electronics); printf("\n Programming %d %f %s %s ",programming,gpa_programming,remarks_programming,grade_programming); printf("\n ITC %d %f %s %s ",itc,gpa_itc,remarks_itc,grade_itc); printf("\n Calculus %d %f %s %s ",calculus,gpa_calculus,remarks_calculus,grade_calculus); printf("\n \n \t The Total Marks You got are %d" and your Percentage is %f,sum,percentage); getch(); }
Hope My issue will be solved !
Ok, beginner's tips about to come
- We write
and notCode:int main(void)Code:void main()- When you want to read a string into a char array you do it like this
This is just ok for startCode:scanf("%s", name);- When reporting a problem, it would be very nice and helpful if you provided the reason you post (which are the errors you get, etc.)
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
Lvalue required in 46 48 and .................................( 25 LINES)
I guess there is a simple error which i have made in all the lines
Please help me
i have to submit this assignment in few hours to professor !
Did you change what I said?
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
Yeah !
but still problem
Please check and open it in your Tubo c
than check the errors
and than tell me boss !
What is your current code? And no, I don't use Turbo C.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
laserlight
Code:#include<stdio.h> #include<conio.h> int main(void) { /* Getting Inital Values */ int english,electronics,programming,itc,calculus; int sum,roll; //char grade_total[]; char grade_english[1]; char grade_electronics[1]; char grade_programming[1]; char grade_itc[5];char grade_calculus[5]; float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus; float percentage; char name[20]; //char remarks_total; char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10]; /* Getting User Personal Info */ printf("\n Please Enter Your Name : "); scanf("%d",&name); printf("\n Please Enter Your Roll Number : "); scanf("%d",&roll); /* Getting User Academic Record */ printf("\n Please Enter Your Marks in Programming : "); scanf("%d",&programming); printf("\n Please Enter Your Marks in Electronics : "); scanf("%d",&electronics); printf("\n Please Enter Your Marks in I.T.C : "); scanf("%d",&itc); printf("\n Please Enter Your Marks in Calculus : "); scanf("%d",&calculus); printf("\n Please Enter Your Marks in English : "); scanf("%d",&english); /* If Condition - Programming Marks - for GPA and Grade and Remarks */ if(programming>=85) { grade_programming="A+"; gpa_programming=4.0; grade_programming="Exceptional"; } if(programming>=80&&programming<=84) { grade_programming='A'; gpa_programming=3.7; remarks_programming="Outstanding"; } if(programming>=75&&programming<=79) { grade_programming="B+"; gpa_programming=3.4; remarks_programming="Excellent"; } if(programming>=70&&programming<=74) { grade_programming='B'; gpa_programming=3.0; remarks_programming="Very Good"; } if(programming>=65&&programming<=69) { grade_programming="B-"; gpa_programming=2.5; remarks_programming="Good"; } if(programming>=60&&programming<=64) { grade_programming="C+"; gpa_programming=2.0; remarks_programming="Average"; } if(programming>=55&&programming<=59) { grade_programming='C'; gpa_programming=1.5; remarks_programming="Satisfactory"; } if(programming>=50&&programming<=54) { grade_programming='D'; gpa_programming=1.0; remarks_programming="Pass"; } if(programming<=49) { grade_programming='F'; gpa_programming=0.0; remarks_programming="Fail"; } /* If Condition - English Marks - for GPA and Grade and Remarks */ if(english>=85) { grade_english='A'; gpa_english=4.0; remarks_english="Exceptional"; } if(english>=80&&english<=84) { grade_english='A'; gpa_english=3.7; remarks_english="Outstanding"; } if(english>=75&&english<=79) { grade_english="B+"; gpa_english=3.4; remarks_english="Excellent"; } if(english>=70&&english<=74) { grade_english='B'; gpa_english=3.0; remarks_english="Very Good"; } if(english>=65&&english<=69) { grade_english="B-"; gpa_english=2.5; remarks_english="Good"; } if(english>=60&&english<=64) { grade_english="C+"; gpa_english=2.0; remarks_english="Average"; } if(english>=55&&english<=59) { grade_english='C'; gpa_english=1.5; remarks_english="Satisfactory"; } if(english>=50&&english<=54) { grade_english='D'; gpa_english=1.0; remarks_english="Pass"; } if(english<=49) { grade_english='F'; gpa_english=0.0; remarks_english="Fail; } /* If Condition - Electronics Marks - for GPA and Grade and Remarks */ if(electronics>=85) { grade_electronics='A'; gpa_electronics=4.0; remarks_electronics="Exceptional"; } if(electronics>=80&&electronics<=84) { grade_electronics='A'; gpa_electronics=3.7; remarks_electronics="Outstanding"; } if(electronics>=75&&electronics<=79) { grade_electronics="B+"; gpa_electronics=3.4; remarks_electronics="Excellent"; } if(electronics>=70&&electronics<=74) { grade_electronics='B'; gpa_electronics=3.0; remarks_electronics="Very Good"; } if(electronics>=65&&electronics<=69) { grade_electronics="B-"; gpa_electronics=2.5; remarks_electronics="Good"; } if(electronics>=60&&electronics<=64) { grade_electronics="C+"; gpa_electronics=2.0; remarks_electronics="Average"; } if(electronics>=55&&electronics<=59) { grade_electronics='C'; gpa_electronics=1.5; remarks_electronics="Satisfactory"; } if(electronics>=50&&electronics<=54) { grade_electronics='D'; gpa_electronics=1.0; remarks_electronics="Pass"; } if(electronics<=49) { grade_electronics='F'; gpa_electronics=0.0; remarks_electronics="Fail; } /* If Condition - I.T.C Marks - for GPA and Grade and Remarks */ if(itc>=85) { grade_itc='A'; gpa_itc=4.0; remarks_itc="Exceptional"; } if(itc>=80&&itc<=84) { grade_itc='A'; gpa_itc=3.7; remarks_itc="Outstanding"; } if(itc>=75&&itc<=79) { grade_itc="B+"; gpa_itc=3.4; remarks_itc="Excellent"; } if(itc>=70&&itc<=74) { grade_itc='B'; gpa_itc=3.0; remarks_itc="Very Good"; } if(itc>=65&&itc<=69) { grade_itc="B-"; gpa_itc=2.5; remarks_itc="Good"; } if(itc>=60&&itc<=64) { grade_itc="C+"; gpa_itc=2.0; remarks_itc="Average"; } if(itc>=55&&itc<=59) { grade_itc='C'; gpa_itc=1.5; remarks_itc="Satisfactory"; } if(itc>=50&&itc<=54) { grade_itc='D'; gpa_itc=1.0; remarks_itc="Pass"; } if(itc<=49) { grade_itc='F'; gpa_itc=0.0; remarks_itc="Fail; } /* If Condition - Calculus Marks - for GPA and Grade and Remarks */ if(calculus>=85) { grade_calculus='A'; gpa_calculus=4.0; remarks_calculus="Exceptional"; } if(calculus>=80&&calculus<=84) { grade_calculus='A'; gpa_calculus=3.7; remarks_calculus="Outstanding"; } if(calculus>=75&&calculus<=79) { grade_calculus="B+"; gpa_calculus=3.4; remarks_calculus="Excellent"; } if(calculus>=70&&calculus<=74) { grade_calculus='B'; gpa_calculus=3.0; remarks_calculus="Very Good"; } if(calculus>=65&&calculus<=69) { grade_calculus="B-"; gpa_calculus=2.5; remarks_calculus="Good"; } if(calculus>=60&&calculus<=64) { grade_calculus="C+"; gpa_calculus=2.0; remarks_calculus="Average"; } if(calculus>=55&&calculus<=59) { grade_calculus='C'; gpa_calculus=1.5; remarks_calculus="Satisfactory"; } if(calculus>=50&&calculus<=54) { grade_calculus='D'; gpa_calculus=1.0; remarks_calculus="Pass"; } if(calculus<=49) { grade_calculus='F'; gpa_calculus=0.0; remarks_calculus="Fail; } /* Finalizing the Conditions */ sum=english+electronics+programming+itc+calculus; percentage=(sum*100)/500; gets(name); printf("\n Roll Number : %d ",roll); printf("\n English %d %f %s %s ",english,gpa_english,remarks_english,grade_english); printf("\n Electronics %d %f %s %s ",electronics,gpa_electronics,remarks_electronics,grade_electronics); printf("\n Programming %d %f %s %s ",programming,gpa_programming,remarks_programming,grade_programming); printf("\n ITC %d %f %s %s ",itc,gpa_itc,remarks_itc,grade_itc); printf("\n Calculus %d %f %s %s ",calculus,gpa_calculus,remarks_calculus,grade_calculus); printf("\n \n \t The Total Marks You got are %d" and your Percentage is %f,sum,percentage); getch(); }
Welcome Raja!
I'm afraid almost no one here has turbo C anymore. I was one of the last "hold outs" to use it, and i stopped over a year ago. (I *love* Pelles C x64, btw.) Still, we can test your code, as long as it doesn't use the special functions that turbo C had: graphics, far pointers, especially. Conio.h is non-standard, but some of us can use it, (Pelles C allows it). Others can't.
I'll take a peek, but i believe STD has me beat on this.
Edit:
In your remarks string, you have "Fail
What you need is to have "Fail"
With the closing double quotes on the end of the word. You have that in several places. Use your editor to find the word Fail, and you'll get right to them.
Last edited by Adak; 01-12-2013 at 10:29 AM.
One more beginner's tip :
Read the whole posts. The words are there, because they have something to say.
When you are asked about something, answer honestly!
You said you changed what I said, but obviously you didn't read about scanf...
Adak, at least nothing sounds Greek to my now! (so everything cool)
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
Adak,
I am a beginner so In Uni, we start from this
Please tell me what mistake I have made
It takes many hour for a beginner like me to code that
I have to submit it to sir sooner
can anyone can reply me with the correct code after resolving erros from this and tell me what mistakes i have made !
std10093
That's not an array!
I havent use a single array ! Thats char size !
As far as I know, this
is an array of 20 characters.Code:char name[20];
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
I am new here myself but I think you could be more helpful by saying exactly the what problem is/what error message you are receiving.