Thread: Capitalize first Character in word.

Hii all,
I need your help. I want to do programming that requires:
Input: my friend or My friend
Output: My friend Or My Friend
My code just can print output: my Friend Or My Friend
I dont know how to capitalize the first character of word in sentence. From 2th word to end of sentence is OK.
I'm using plain C

Code:

//Count character, words, space, line,count capital, count lowcase,convert capital <-> lowercase
//Capitalize in first character of word
#include<stdio.h>
#include<string.h>
int main(void)
{
   char name[200], name1[200],name2[200];
   int i,j, count = 0, end = 0, line = 0, word = 0, flag = 0,wspace=0,capital=0,lowcase=0;
   printf ( "Enter the strings\n" );
   printf("\n");
   gets ( name );
   for ( i = 0; name[i] != '\0'; i++ )
   {

      if (name[i]==' ')
          wspace++;

      if (name[i] == '\t' )
         printf (" ");
          count++;

      if ( name[i] == '\0' )
         end = 0;

      else if ( end == 0 )
      {
         end = 1;
         line++;
      }

      if ( name[i] == ' ' || name[i] == '\t' || name[i] == '\n' )
         flag = 0;

      else if ( flag == 0 )
      {
         flag = 1;
         word++;
      }
      if (name[i]>='A'&& name[i]<='Z')
          capital++;


      if (name[i]>='a'&& name[i]<='z')
          lowcase++;

      if (name[i]>=97 && name[i]<=122)
          if (name[i]==32)
              name[i]=name[i];
            else
              name[i]=name[i]-32;
      else
          if (name[i]==32)
              name[i]=name[i];
            else
              name[i]=name[i]+32;

     name1[i] = toupper(name[i]);
      for (j=0;j<strlen(name);j++)
          if (name[j]==' '||name[j]=='\0' || name[j]=='\n')
              name1[j+1]=toupper(name[j+1]);

     name2[i] = tolower(name[i]);
      for (j=0;j<=strlen(name);j++)
          if (name[j]==' ' || name[j]=='\0' || name[j]=='\n')
              name2[j+1]=toupper(name[j+1]);

   }
   printf("\n");
   printf ( "Total number of characters %d\n", count-wspace );
   printf("\n");
   printf ( "Total number of word %d\n", word );
   printf("\n");
   printf ( "Total number of line %d\n", line );
   printf("\n");
   printf ( "Total number of space %d\n", wspace );
   printf("\n");
   printf ( "Total number of capital %d\n", capital );
   printf("\n");
   printf ( "Total number of lowcase %d\n", lowcase );
   printf("\n");
   printf ( "Exchanged case %s\n",name);
   printf("\n");
   printf ( "Exchanged case into capital always %s\n",name1);
   printf("\n");
   printf ( "Exchanged case into capital in the first character %s\n",name2);
   printf("\n");

}

Originally Posted by duongducthieniu

I want to do programming that requires:
Input: my friend or My friend
Output: My friend Or My Friend

I am guessing that you actually mean that the output should be: My Friend Or My Friend

Anyway, at the moment you have code that goes over the string character by character to count them. My suggestion is this: take advantage of the fact that when you count a word, you toggle a flag. At that point, the current character should be capitalised (using toupper), so you just need to capitalise it and move on. Thus, you can discard your inner for loops that call strlen.

By the way, instead of comparing with 'A' and 'Z', make use of isupper. Likewise, make use of islower. Also, instead of having variables named word and line, rename them to word_count and line_count. It would be easier to understand.

Oh, and do not use gets as it is inherently vulnerable to buffer overflow. fgets would be an alternative here, but you should note that fgets reads in the newline character at the end if there is enough space.

Thanks for your reply leserlight.
1) Yes, you are right. My opinion is: My Friend Or My Friend
2) You mean erase

Code:

name2[i] = tolower(name[i]);
      for (j=0;j<=strlen(name);j++)
          if (name[j]==' ' || name[j]=='\0' || name[j]=='\n')
              name2[j+1]=toupper(name[j+1]);

and change a litle bit after "count a word" and "toggle a flag"?
3) Variables name can be change easily
4) I tried to use "fgets" replace "gets" as mentioned but program did not run. Appear: "to few arguments to function fgets"

I need some more details from you.

Originally Posted by duongducthieniu

2) You mean erase (...) and change a litle bit after "count a word" and "toggle a flag"?

Yes. Not only the loop for name1, but also for name2. name should probably be renamed to text, name1 should probably be renamed fully_capitalized_text and name2 should probably be renamed to word_capitalized_text.

Originally Posted by duongducthieniu

3) Variables name can be change easily

Then make the changes and post your updated code.

Originally Posted by duongducthieniu

4) I tried to use "fgets" replace "gets" as mentioned but program did not run. Appear: "to few arguments to function fgets"

That is because you made no effort to find out how to call fgets correctly.

Originally Posted by Barney McGrew

You're making it way too complicated.

You're making it way too simplified though, but yeah, your code implements the core of my suggestion.

Originally Posted by Barney McGrew

I was referring to the overall design of his program, particularly how he was storing sequences of characters into arrays then operating on them (instead of operating on them one-by-one)

I actually think that is necessary here though: apparently there is a requirement to print various transformed versions of the input string after doing the various counting. In that sense, reading and processing one by one is not very different from reading the whole string first then processing one by one: in the end, the entire string still needs to be stored.

Originally Posted by Barney McGrew

I was referring to the overall design of his program, particularly how he was storing sequences of characters into arrays then operating on them (instead of operating on them one-by-one), rather than your responses. Sorry for the miscommunication.

By working directly on streams you can produce very succinct, efficient C programs.
However the programs are also harder to modify. For instance my name has a capital that doesn't follow a space, as does yours for that matter. How would you patch the program to handle Scots surnames correctly?

Prefix trees are quite useful for that.

Code:

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>

struct letter {
    int letter;
    struct letter *leaf;
    struct letter *next;
};

static struct letter *maketrie(char *const *prefixes);

static struct letter *lookup(struct letter *trie, int c);

static int blah(struct letter **cp, int c)
{
    struct letter *lp;

    if ((lp = lookup(*cp, '\0'))) {
        *cp = lp->leaf;
        return 1;
    }
    *cp = (lp = lookup(*cp, c)) ? lp->leaf : 0;
    return 0;
}

int main(void)
{
    static char *prefixes[] = {
        "mc", "o'", 0
    };
    struct letter *trie = maketrie(prefixes);
    struct letter *tp;
    int inspace, c;

    for (inspace = 1; (c = getchar()) != EOF; inspace = isspace(c))
        if (inspace) {
            tp = trie;
            blah(&tp, tolower(c));
            putchar(toupper(c));
        } else {
            putchar(blah(&tp, tolower(c)) ? toupper(c) : c);
        }
}

struct letter *lookup(struct letter *tp, int c)
{
    while (tp && tp->letter != c)
        tp = tp->next;
    return tp;
}

static struct letter *add(struct letter *trie, const char *str)
{
    struct letter *tp;

    if ((tp = lookup(trie, *str))) { 
        tp->leaf = !*str ? 0 : add(tp->leaf, str + 1);
        return trie;
    }
    if (!(tp = malloc(sizeof *tp))) {
        fputs("memory error\n", stderr);
        exit(EXIT_FAILURE);
    }
    tp->letter = *str;
    tp->next = trie;
    tp->leaf = !*str ? 0 : add(0, str + 1);
    return tp;
}

struct letter *maketrie(char *const *prefixes)
{
    struct letter *tp;

    for (tp = 0; *prefixes; prefixes++)
        tp = add(tp, *prefixes);
    return tp;
}