Thread: My loops not working and dont know what to do

Basically this is my program, a person enters an integer which is the height of a half pyramid. It then generates the pyramid using spaces and hashes, it looks something like this



so far my program looks something like this:

Code:

#include <cs50.h>#include <stdio.h>


int main(void)


{


int height = GetInt();
int integer = 1;
//int spaces = height - integer;
int integer2 = 2;
int numberOfHashes = height - (height - integer2);
int loopcount = 0;


while (loopcount < height)
{
    while (integer < height)
    {
        printf(" ");
        integer++;
    }
    
    while (numberOfHashes > 0)
    {
        printf("#");
        numberOfHashes--;
    }
    printf("\n");
    loopcount++;
}
return 0;
}

i dont get why it doesn't work. Someone please help. I would also like to add that i am totally new to programming and am still going over the basics, this is just a training program.

Thanks

How does it not work?

In what way is the output wrong?

What output is expected? What really happens?

Edit: The thing I wonder about is how the values of "integer" and "numberOfHashes" are reset after the first time thru the while loops.

Decided my edit 2 was maybe to harsh.

Tim S.

when i execute the file, enter an integer and it makes a pyramid with the height of the number entered. It just does the first line of the pyramid, 7 spaces and 2 hashes, its supposed to show a whole half pyramid.

like this

it only shows the first line of hashes

Edit: So what should i do?

Edit2: Is there an equivalent of GetInt() that is not in that library?

How do you reset the values of "integer" and "numberOfHashes" inside the while (loopcount < height) loop?

Hint: You are NOT resetting the values.

Tim S.

numberOfHashes = value; /* where you pick the value */

My reformatted version of your code.

Output is not right; but, is closer in my view to correct.

Code:

6
      ###
      ###
      ###
      ###
      ###
      ###

Code:

#include <stdio.h>

#include "cs50.h"

int main(void)
{
    int height = GetInt();
    int integer = 1;
    //int spaces = height - integer;
    int integer2 = 2;
    int numberOfHashes = height - (height - integer2);
    int loopcount = 0;

    while (loopcount < height)
    {
        integer = 0;
        while (integer < height)
        {
            printf(" ");
            integer++;
        }

        numberOfHashes = 3;
        while (numberOfHashes > 0)
        {
            printf("#");
            numberOfHashes--;
        }
        printf("\n");
        loopcount++;
    }
    return 0;
}

Originally Posted by ziggy786

where do i add that?

Do NOT plan on being a professional programmer.

Edit: I am now adding you to my ignore list; you do not seem to have been smart enough to write the original code.

Tim S.

PS: I edited my prior post.