A function program to calculate the factorial value of an integer.
Code:main() { int a,fact; printf("Enter an integer"); scanf("%d",&a); fact=facto(a); printf("The Factorial of the integer is%d",fact); } facto(x) { int i=1; for(i=1;i<=x-1;i++) { x=x*i; } return(x); }
Start by:
- Indenting your code properly.
- Including the relevant headers.
- Declaring your functions before use.
- Declaring your functions with the appropriate return types and parameter types.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
After fixing up the code per laserlight's suggestion, try printing the values of 'x' and 'i' in your "for()" loop. This is the simplest form of troubleshooting, and should be well within your capabilities.
So should I declare the function like this?
Also what do you mean by declaring functions with the appropriate return types and parameter types?Code:int facto();
No, declare it to be a prototype like this:
Code:int facto(int x);
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Thanks but still ain't getting the output.
eg. when I type 3,I get the factorial something like -1011......?
What is your current code? (Note that we have not yet started on your actual problem.)
Look up a C++ Reference and learn How To Ask Questions The Smart Way
I take it you didn't try my advice in post #3?
Code:main() { int a,fact; printf("Enter an integer"); scanf("%d",&a); fact=facto(a); printf("The Factorial of the integer is%d",fact); } int facto(int x) { int i=1; for(i=1;i<=x-1;i++) { x=x*i; } return(x); }
Why should I print x and i?I just want to return the value of x into fact.If you mean to say use 'return' within 'for' then it will print every multiplication in the calling function but I just want the factorial.
No, that is still poorly formatted and incomplete. This is what I had in mind:
Notice the header that is included and the declaration of facto before it is used in main. Notice that main now has its return type explicitly stated. Since you omitted to explicitly return a value from main, I have done the same since it just means "return 0;" at the end of main in the 1999 edition of the C standard and later.Code:#include <stdio.h> int facto(int x); int main(void) { int a, fact; printf("Enter an integer"); scanf("%d", &a); fact = facto(a); printf("The Factorial of the integer is%d", fact); } int facto(int x) { int i = 1; for (i = 1; i <= x - 1; i++) { x = x * i; } return(x); }
Now, onto your problem: as Matticus suggested, you need to observe what is going on in the loop in facto. Use a debugger, print the variables, whatever. You need to see what is happening to understand what is going wrong and hence fix it.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Because if the function isn't working as expected, then that might give you a giant clue as to why. It will show you the values for each iteration of the loop, and might show you something very interesting.Why should I print x and i?
I don't mean "put it in and keep it in," I just mean so you can get a sense of what's happening in your code.
That's the beauty of programming - it's easy to add temporary code for troubleshooting purposes.
It is also easy to forget and leave it in, hence it is usually better to use a debugger if one is available.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
@laseslight,still getting the same output with your code.........-10112
@matticus-I printed the value of x and i within for but still getting the same output.
Is there a problem with my Turbo C or something?
Very true - however, my advice was gauged on the simplistic level of the given program, and the presumed lack of experience by the OP. Those who are just starting out might be easily intimidated by such tools. Based on that, and the actual problem at hand, I thought recommending the "printf()" method in this case had more value.
But you're right - getting used to debuggers early in the game would be a very valuable asset.
