Hey. Just look at the codes and give an advice please.
and here is problem...Code:BOOL checkPortNum(U32 port) { if(port < 0 || port > 4) { return (ERROR); } else{ return (SUCCESS); } } BOOL checkPinNum(U32 pin) { if(pin < 0 || pin > 0xFFFFFFFF) { return (ERROR); } else{ return (SUCCESS); }
Code:PUBLIC void drvGpioDirection(U32 port, U32 pin, PinDirection direction) { if (checkPort(port) && checkPin(pin)) { GPIO_SetDir(port, pin, direction); } else WHAT??? }
I mean that how can I stop the func (drvGpioDirection) in WHAT line???
Last edited by Salem; 12-02-2012 at 01:24 AM. Reason: font colour adds nothing, except my headache
return?Originally Posted by ahmetalncak
First, the code is C++, not C, so you're in the wrong forum.
Second, your description is isn't really clear.
Last edited by Salem; 12-02-2012 at 01:24 AM. Reason: font colour adds nothing, except my headache
The code is neither C nor C++.
Granted it's missing a closing brace and the #defines for several things, but it looks perfectly feasible that this is C to me. I'm baffled why anyone is saying otherwise.
Do whatever you want to do: return, exit, nothing... those are the three most obvious choices right there.
My homepage
Advice: Take only as directed - If symptoms persist, please see your debugger
Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"
I wouldn't have commented, except for Adak's incorrect assertion that it was C++ rather than C. Yes, it is feasible it is C (or C++), if the points you've described are addressed.
Although there aren't many feasible meanings of that "PUBLIC" in front of one function other than nothing, or a compiler-specific extension.
The question seems to be about how to handle errors. If the condition
(checkPort(port) && checkPin(pin))
is true, then all is well and the program proceeds. If it's not, then it's up to you to decide what's appropriate. For example, it might be appropriate to delay for some short time and then check the pin and port again - maybe that device was momentarily unavailable. If this strategy continues to fail then at some point you have to give up.
Since it's a void function, you have the option of doing nothing, as was mentioned. This means that any error (like when the port and pin are not both returning SUCCESS) would just be ignored.
Understood.
I would guess that PUBLIC is defined as extern, and/or something like a dllexport specification.
My homepage
Advice: Take only as directed - If symptoms persist, please see your debugger
Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"
I base this on nothing, because you have not given sufficient information about your problem
It seems like you are setting up a data-direction register, and if checkPort(port) && checkPin(pin), you don't want to change the data-direction.
Depending on what checkPort(port) && checkPin(pin) is checking determines what you want to do.
If the device is detecting a signal on the input pin, and the if statement is to protect against the microchip driving the line high/low when the input differs, you want to make sure that it remains an input
Maybe something like this is what you want...
Where GPIO_INPUT has been defined as the default value for an inputCode:PUBLIC void drvGpioDirection(U32 port, U32 pin, PinDirection direction) { if (checkPort(port) && checkPin(pin)) { GPIO_SetDir(port, pin, direction); } else { GPIO_SetDir(port, pin, GPIO_INPUT); }
Fact - Beethoven wrote his first symphony in C
