Thread: Trouble finding error in code

While writing my code, I checked to see if it would run and got a pop-up window saying that my project (Final Project.exe) has stopped working. This tells me that there is an error in it, but I wasn't sure where. Here is my code:
Code.c

And the file I'm reading from:
Car.txt

After adding printf("Hello\n"); a couple of times in my code, I've narrowed down to that my while loop has an error in it because it's printing the first 4 Hello's but not the last two. I'm still not sure what the error is though after looking through several sites. Help please

ok, I've made that fix but it keeps saying that it has stopped working.

Code:

#include <stdio.h>
#include <stdlib.h>
#define FILENAME "Car.txt"
struct CarData
{
       char Driver[6];
       char Type[12];
       int CarNumber;
       char Colour[7];
};
int main(void)
{
  printf("Hello\n"); //Testing to see if it prints
  
  FILE *Car = fopen(FILENAME, "r");
  int i;
  
  printf("Hello\n"); //Testing to see if it prints
  struct CarData Veh[5];
 
  printf("Hello\n"); //Testing to see if it prints
  
  //Determining if file contains info
  if(Car == NULL)
  {
     printf("File does not exist.\n");
     system("PAUSE");
     exit (1);
  }
  printf("Hello\n"); //Testing to see if it prints
  
  while (!feof(Car))
  {
        fscanf(Car, "%s %s %d %s", Veh[i].Driver, Veh[i].Type, Veh[i].CarNumber, Veh[i].Colour);
        i++;
  }
  
  printf("Hello\n"); //Testing to see if it prints
  
  printf("%s %s %d %s",Veh[i].Driver, Veh[i].Type,
        Veh[i].CarNumber, Veh[i].Colour);
        
  printf("Hello\n"); //Testing to see if it prints
  
  system("PAUSE"); 
  return 0;
}

lol thanks. unfortunately it still isn't working even after initializing i. :/

Ok, it runs and prints now but all I get is gibberish:

Ðþ( -2 Ú˜ruú suȤ
Ðþ( -2 Ú˜ruú suȤ
Ðþ( -2 Ú˜ruú suȤ

Code:

#include <stdio.h>
#include <stdlib.h>
#define FILENAME "Car.txt"
struct CarData
{
       char Driver[6];
       char Type[12];
       int CarNumber;
       char Colour[7];
};
int main(void)
{
  FILE *Car = fopen(FILENAME, "r");
  int i=0;
  int j=0;
  struct CarData Veh[5];
  
  //Determining if file contains info
  if(Car == NULL)
  {
     printf("File does not exist.\n");
     system("PAUSE");
     exit (1);
  }
  
  while ( i < 5 &&      
   fscanf(Car, "%s %s %d %s", Veh[i].Driver, Veh[i].Type, &Veh[i].CarNumber, Veh[i].Colour) == 4 ) 
   {
    i++;
   } 
  
  while (j < 5)
  {
  printf("%s %s %d %s\n",Veh[i].Driver, Veh[i].Type,
        Veh[i].CarNumber, Veh[i].Colour);
  j++;
 }
  system("PAUSE"); 
  return 0;
}

Ouch, fail on my part. Thank you guys so much, it works now.

Code:

#include <stdio.h>
#include <stdlib.h>
#define FILENAME "Car.txt"
struct CarData
{
       char Driver[6];
       char Type[12];
       int CarNumber;
       char Colour[7];
};
int main(void)
{
  FILE *Car = fopen(FILENAME, "r");
  //FILE *Output = fopen("Output.txt", "w");
  int i=0;
  struct CarData Veh[5];
  
  //Determining if file contains info
  if(Car == NULL)
  {
     printf("File does not exist.\n");
     system("PAUSE");
     exit (1);
  }
  
  while ( i < 3 &&      
   fscanf(Car, "%s %s %d %s", Veh[i].Driver, Veh[i].Type, &Veh[i].CarNumber, Veh[i].Colour) == 4 ) 
   {
    i++;
   } 
  
  for(i=0; i<3; i++)
  {
  printf("%s %s %d %s\n",Veh[i].Driver, Veh[i].Type,
        Veh[i].CarNumber, Veh[i].Colour);
 }
  system("PAUSE"); 
  return 0;
}

Since the "3" part of your code can only serve to wreck it, I'd delete that part.

Make your second for loop work with j=0;j<i;j++, instead of i.

Originally Posted by Adak

Since the "3" part of your code can only serve to wreck it, I'd delete that part.

Make your second for loop work with j=0;j<i;j++, instead of i.

huh?

Ooooh, gotcha.