Thread: Help - Collect data from Switch loop inside While loop

Hi all,

First time using these board so my apologies if i don't post correctly! (i have read the posting rules so hopefully should be ok!

The problem i've got is that I need to display the wages entered in the correct order at the end of the loop. For a reason i can't find it will only display the last data entered. If anyone could help me with where i've gone wrong that would be great thanks!

Code:

#include<stdio.h>#include<windows.h>
#include<windowsx.h>


/* Author James King, Wages1 Version 3.1 (Option A) for Caroline Cripps CORC1067*/


int main()
{
     /*variables and objects here*/


     char dept,exit,name[40];
     float totWage [40],wage,hours,overtime,com,wklyWage,avgGross;
     int count=0,index=0;




        system("cls");


     /*Executable instructions here*/


     printf("Welcome to the Wages1 program.");


     while (exit!='n'&&exit!='N')
     {


     printf("\n\nEnter Employee Code: ");
     scanf("%s",&dept);




         switch (dept)
         {                   /*START of FACTORY code*/
             case 'F':
             case 'f':


                  printf("\nEnter name: ");
                  scanf("%s",&name);
                  printf("Enter hours worked: ");
                  scanf("%f",&hours);
                  printf("Enter rate of pay: œ");
                  scanf("%f",&wage);


                  /*Displayed outputs*/


                  printf("\n-----Factory Dept-----");
                  printf("\nName: %s",name);
                  printf("\nEmployee Position: %d",count+1);


                          if (hours>35)
                           {
                               overtime=(wage*1.5)*(hours-35);
                           printf("\nTotal Overtime: œ%0.2f",overtime);
                           }


                      totWage[index]=(35*wage)+overtime;
                      printf("\nWages earned for employee %d: œ%0.2f",count+1,totWage[index]);
                      count++;




                      break;


           /*end of Factory dept code*/


               case 'S':      /*START of SALES code*/
               case 's':


                    printf("\nEnter name: ");
                    scanf("%s",&name);
                    printf("Enter hours worked: ");
                    scanf("%f",&hours);
                    printf("Enter rate of pay: œ");
                    scanf("%f",&wage);
                    printf("Enter Commission Earned: œ");
                    scanf("%f",&com);


                    /*Displayed outputs*/


                    printf("\n-----Sales Dept-----");
                    printf("\nName: %s",name);
                    printf("\nEmployee Position: %d",count+1);
                    totWage[index]=(hours*wage)+com;
                    printf("\nWages earned for employee %d: œ%0.2f",count+1,totWage[index]);
                    count++;




                    break;


          /*end of Sales dept code*/


                  case 'A':         /*START of ADMIN code*/
                  case 'a':
                       printf("\nEnter name: ");
                       scanf("%s",&name);
                       printf("Enter hours worked: ");
                       scanf("%f",&hours);
                       printf("Enter rate of pay: œ");
                       scanf("%f",&wage);


                       /*Displayed outputs*/


                       printf("\n-----Administration Dept-----");
                       printf("\nName: %s",name);
                       printf("\nEmployee Position: %d",count+1);
                       totWage[index]=hours*wage;
                       printf("\nWages earned for employee %d: œ%0.2f",count+1,totWage[index]);
                       count++;




                       break;


          /*end of Administration dept code*/


          default:
                  printf("\n-----UNKNOWN ENTRY-----");
                  printf("\nPress 'Y' to continue");




        }
        /*end of SWITCH loop*/


        wklyWage=wklyWage+totWage[index];
        avgGross=(float)(wklyWage/count);


            printf("\n\n\nAre there more employee's? ");


            printf("\nEnter 'y' to continue or 'n' to finish.");
            printf("\n\n: ");
            scanf("%s",&exit);
        }




        /*end of WHILE loop*/


        printf("\n\nThe average pay is œ%0.2f",avgGross);
        printf("\nThe Wage bill for this week is œ%0.2f",wklyWage);


/*THIS LOOP WONT DISPLAY ARRAY IN A LIST ONLY THE LAST DATA ENTERED THEN RANDOM DATA
---It should display the wages entered in order next to the number of the employee who entered it----*/


        for (index = 0; index < count; index++)
                     {


                     printf("\nEmployee no%d earned %0.2f",count+1, totWage[index]);


                     }






     getchar();
     getchar();
     return 0;


}

Thanks for looking! Only started using C a month ago, so there may well be a few problems. If there are I'm sorry!

Brilliant thank you very much for the quick reply! Wasn't sure if i'd posted to much code as i know its quite long !

Originally Posted by Salem

totWage[index]=(35*wage)+overtime;
printf("\nWages earned for employee %d: œ%0.2f",count+1,totWage[index]);
count++;
You're using two different variables.
index is never anything other than 0.


Try totWage[count]

> float totWage [40]
Initialise them all to 0 with

Code:

float totWage [40] = { 0 };

Other than that, it's a good first post.

I tried using count as the variable but i found i had no way of recalling whree it was saved because i'd have to initialize to 0 for the FOR loop at the end?

again, newbie so please explain if my logic doesn't work (fairly likely)

Originally Posted by rogster001

by the way did you notice 'exit' ? - you have to be careful when naming variables which 'might' be keywords

Wasn't aware it could've been a keyword! thanks for the heads up ill change it!

system() is declared in <stdlib.h> which you didn't #include. Always #include the appropriate headers for the Standard library functions you use.
Once you #include <stdlib.h>, "exit" is a identifier used for a function. You must not use "exit" as an identifier for your own purposes.

Don't use objects (variables) of type float. Prefer objects of type double in almost all occasions (exceptions are when teacher insisted on float even after you tried to dissuade her; and when you want an array with some million elements).

In line 29, you're using exit (you should rename this variable!) without having initialized it. It may begin life with a 'N' and your loop will never run. Initialize it (at line 13) to something reasonable.

To read one single character with scanf() use the specifier "%c". The specifier you use at line 34 is invalid for char objects. You may also want to get rid of whitespace before the character: use a space before the conversion: scanf(" %c", &dept);

To scanf an object of type double (after you replace your floats) use the specifier "%lf"

Your immediate problem, I think
I didn't see any change of the variable index inside your main loop. Isn't that supposed to index the array?

Ok, all recommendations added. It now adds up the wages perfectly! thanks!, Except now my original totals and average calculations have gone insane... any idea's?

Originally Posted by qny

system() is declared in <stdlib.h> which you didn't #include. Always #include the appropriate headers for the Standard library functions you use.
Once you #include <stdlib.h>, "exit" is a identifier used for a function. You must not use "exit" as an identifier for your own purposes.

Don't use objects (variables) of type float. Prefer objects of type double in almost all occasions (exceptions are when teacher insisted on float even after you tried to dissuade her; and when you want an array with some million elements).

In line 29, you're using exit (you should rename this variable!) without having initialized it. It may begin life with a 'N' and your loop will never run. Initialize it (at line 13) to something reasonable.

To read one single character with scanf() use the specifier "%c". The specifier you use at line 34 is invalid for char objects. You may also want to get rid of whitespace before the character: use a space before the conversion: scanf(" %c", &dept);

To scanf an object of type double (after you replace your floats) use the specifier "%lf"

Your immediate problem, I think
I didn't see any change of the variable index inside your main loop. Isn't that supposed to index the array?

Thanks for the reply!

i've changed variable 'exit' to just 'ex' now, How do i initialise a char? just initialise it to a random letter like this?

Code:

 char dept,ex='a',name[40];

..?

Originally Posted by James King

How do i initialise a char? just initialise it to a random letter like this?

Code:

 char dept,ex='a',name[40];

Yes, that is correct.

Originally Posted by James King

... why the avgGross and wklyWage are displaying a long string of numbers?
... i'm not sure whats wrong with it...

You need to initialize wklyWage (to 0).

Thank you! you are a life-saver!