Hello, I've completed my program but there seems to be some minor issue which I've been trying hard to figure out. Here's the code:
Code:
#include<stdio.h>
#include<conio.h>
#include<stdlib.h>
typedef struct node
{
int data;
struct node *left;
struct node *right;
}NODE;
typedef struct
{
int count;
NODE *root;
}TREE;
TREE *createTree(void)
{
TREE *tree;
tree = (TREE *)malloc(sizeof(TREE));
if(tree)
{
tree->count = 0;
tree->root = NULL;
}
return tree;
}
NODE *addNode(TREE *tree, NODE *node, int dataIn)
{
if(node == NULL)
{
NODE *newNode;
newNode = (NODE *)malloc(sizeof(NODE));
if(newNode)
{
newNode->data = dataIn;
newNode->left = NULL;
newNode->right = NULL;
node = newNode;
(tree->count)++;
}
}
else
{
if(dataIn < node->data)
{
node->left = addNode(tree, node->left, dataIn);
return node;
}
else
{
node->right = addNode(tree, node->right, dataIn);
return node;
}
}
return node;
}
void inOrder(NODE *node)
{
if(node != NULL)
{
inOrder(node->left);
printf("%d\t", node->data);
inOrder(node->right);
}
}
void preOrder(NODE *node)
{
if(node != NULL)
{
printf("%d\t", node->data);
preOrder(node->left);
preOrder(node->right);
}
}
void postOrder(NODE *node)
{
if(node != NULL)
{
postOrder(node->left);
postOrder(node->right);
printf("%d\t", node->data);
}
}
int findNode(NODE *node, int findData)
{
if(node == NULL)
return 0;
if(findData == node->data)
return 1;
else if(findData < node->data)
findNode(node->left, findData);
else
findNode(node->right, findData);
}
NODE *findNewRoot(TREE *tree, NODE *node, int delData, int *success)
{
NODE *dltPtr;
NODE *exchPtr;
NODE *newRoot;
int temp;
if(!node)
{
*success = 0;
return NULL;
}
if(delData < node->data)
node->left = findNewRoot(tree, node->left, delData, success);
else if(delData > node->data)
node->right = findNewRoot(tree, node->right, delData, success);
else
{
dltPtr = node;
if(!node->left)
{
newRoot = node->right;
free(dltPtr);
*success = 1;
return newRoot;
}
else if(!node->right)
{
newRoot = node->left;
free(dltPtr);
*success = 1;
return newRoot;
}
else
{
exchPtr = node->left;
while(exchPtr)
exchPtr = exchPtr->right;
temp = node->data;
node->data = exchPtr->data;
exchPtr->data = temp;
node->left = findNewRoot(tree, node->left, exchPtr->data, success);
}
}
return node;
}
int main(void)
{
TREE *tree;
tree = createTree();
int value;
while(1)
{
printf("\n1. Insert");
printf("\n2. Delete");
printf("\n3. Find");
printf("\n4. InOrder");
printf("\n5. PreOrder");
printf("\n6. PostOrder");
printf("\nChoice: ");
scanf("%d", &value);
if(value == 1)
{
int data;
printf("\nEnter data to be inserted: ");
scanf("%d", &data);
tree->root = addNode(tree, tree->root, data);
}
else if(value == 2)
{
int delData;
printf("\nEnter node to be deleted: ");
scanf("%d", &delData);
if(findNode(tree->root, delData) == 1)
{
int success;
NODE *newRoot;
newRoot = findNewRoot(tree, tree->root, delData, &success);
if(success == 1)
{
tree->root = newRoot;
(tree->count)--;
if(tree->count == 0)
tree->root = NULL;
printf("\n\nNode deleted successfully. . .");
}
else
{
printf("\n\nNode not deleted. . .");
}
}
else
{
printf("\n\nNode %d not found. . .", delData);
}
}
else if(value == 3)
{
int findData;
printf("\nEnter value to be found: ");
scanf("%d", &findData);
if(findNode(tree->root, findData) == 1)
{
printf("\n\nNode %d found\n\n", findData);
}
else
{
printf("\n\nNode %d not found\n\n", findData);
}
}
else if(value == 4)
{
printf("\n\n");
printf("---------------InOrder Traversal--------------\n\n");
inOrder(tree->root);
printf("\n\n");
printf("-----------------------------------------------\n");
}
else if(value == 5)
{
printf("\n\n");
printf("---------------PreOrder Traversal--------------\n\n");
preOrder(tree->root);
printf("\n\n");
printf("-----------------------------------------------\n");
}
else if(value == 6)
{
printf("\n\n");
printf("---------------PostOrder Traversal--------------\n\n");
postOrder(tree->root);
printf("\n\n");
printf("-----------------------------------------------\n");
}
else
exit(1);
}
getch();
return 0;
}
After using option 1 to insert three nodes - "20", "10" and "30" when I try to find "10" using option 3, it says "Node 10 not found" even though the node is present. Even the print options show that the node is present.
I did a little debug and figured out that findNode() function does return a 1, but the if condition doesn't catch it. What could be the issue?
Originally Posted by Salem
