Can some one check this code for me?!

[Gareth Morgan]

I have an assignment due and the lecturer gave me this code to add to the end of it. however I think Ive written it down wrong as its doesnt compile.

#include <stdio.h>
#include <ctype.h>
#include <stdlib.h>

void main (void)
{
    char ch;
    
    printf("\n\n\nAnother Go? (y/n)");
    do
    {
         ch=getch();
         ch=toupper(ch);
     }
    while (ch!='Y' && ch!='N');
}

[std10093]

void main(void)

write it as

int main(void)

[anduril462]

It would help if you explained how it doesn't compile, i.e. the exact error message(s) you get along with any line numbers. Copy-paste them from your terminal/IDE.

Also, getch is not a standard function. Perhaps you should be using getchar(), which returns an int. That means ch should be declared as an int, to handle all possible return values (all chars, plus EOF).

[AndiPersti]

however I think Ive written it down wrong as its doesnt compile.

And why don't you tell us the errors you get?

$ make foo
cc -ggdb3 -Wall -Wextra    foo.c   -o foo
foo.c:5:6: warning: return type of ‘main’ is not ‘int’ [-Wmain]
foo.c: In function ‘main’:
foo.c:12:10: warning: implicit declaration of function ‘getch’ [-Wimplicit-function-declaration]
/tmp/cc3YI3U1.o: In function `main':
/home/andreas/Code/foo.c:12: undefined reference to `getch'
collect2: ld returned 1 exit status
make: *** [foo] Error 1

There is no standard function called getch(). You're probably on Windows/DOS and want to use a function with that name declared in <conio.h>, so you have to include this header.

Bye, Andreas

[Eulogy]

Do you mean to use getchar();?

ch = getchar();

[Gareth Morgan]

Thanks for your comments. Its working now. Used a different compiler and used your changes.