Thread: Assignment Help (II)

Hi, a while ago I posted here for help on an assignment for school, and the help I received was invaluable and helped me figure out how to complete my assignment!

This is my final assignment now, and it is programming a game of Hangman. It requires a function in addition to main, and uses strings.

I think I have the majority done, the rest is just finding and correcting mistakes (along with a few other questions that will likely arise later)..

I'm not very good with strings, so there may be some pretty stupid errors..

And for some reason it crashes after inputting the word... My compiler (and I) must be missing something..

Here's my code:

Code:

#include <stdio.h>#include <string.h>


int draw_guess(int length, char guess, char word[]) //the function draws the unguessed letters (dashes) and updates it when guessed correctly
{
    //Draws the dashes
    int i, startup = 0;
    char display[i];
    
    
    //Updates the dashes with the properly guessed letters 
    if(startup = 1)//only goes after the initial dashes are printed
        for(i=0; i<length; i++)
        {
            if(word[i] == guess)
            {
                display[i] = guess;
                
                printf("%s", display[i]);
            }
        
            else return 1; //if an incorrect letter is guessed, the function returns 1
        }
    else//this is just to print the initial dashes
    {
        for(i=0; i<length; i++)
        {
            display[i] = 'i';
            
            printf("%s", display[i]);
        }
    }
    startup = 1;
    
}
   


int main(void)
{
    int length, wrong, position;
    char guess;
    char word[7], prevguess[17];
    
    wrong = 0;
    
    printf("Welcome to HANGMAN!\n");
    printf("Please pick a word (2 to 6 letters): ");
    scanf("%s", word);
    
    length = strlen(word); //just takes the length of the word entered
    
    printf("You are guessing a word that is %d letters long.\n", length);
    
    while(wrong != 10) //keeps going for 10 incorrect guesses
    {
        draw_guess(length, guess, word); //SHOULD draw the initial dashes once, than afterwards begin printing the updated ones
        
        printf("Make a guess (1 letter): ");
        scanf("%c", guess);
    
        position = strlen(prevguess); //this just sets up the string containing guesses
    
    if(draw_guess(length, guess, word) == 1)//when the function returns 1, the guess was wrong
        wrong = wrong + 1; //adds to the incorrect guess count
    
        prevguess[position] = guess;//adds the guess into the string
                
        printf("Your guesses: %s", prevguess);//shows the previous guesses
        printf("Incorrect guesses: %d", wrong);//tells user how many times they have guessed wrong
    }
    
    return 0;
}

Just one thing I noticed first was this piece of code.

Code:

 int i, startup = 0;
    char display[i];

what is the value of i?

What are you trying to accomplish ? Can you explain ?

The whole thing is still unclear to me. What is a wordlist ?
I just created a sample code :

Code:

#include <stdio.h>
#include <string.h>
 
int draw_guess(int length, char guess, char word[]) 
{
    
    int i, k=0;
    for(i=0; i<length; i++)
    {
        if(word[i] == guess)
        k=1;
    }
    if(k==1)
    {
        for(i=0; i<length; i++)
        {
            if(word[i] == guess)
            printf("%c", guess);
            else if (word[i]!=guess)
            printf("%c", '-');
        }  
        return 0;
    }  
    else if (k==0)
    return 1;
}
 
int main(void)
{
    int length, wrong, j;
    char guess;
    char word[20];     
    wrong = 0;     
    printf("Welcome to HANGMAN!\n");
    printf("Please pick a word (2 to 6 letters): ");
    scanf("%s", word);     
    length = strlen(word);
    printf("You are guessing a word that is %d letters long.\n", length);
    while (wrong<=9)
    {
         printf("Make a guess (1 letter): ");
         scanf(" %c", &guess);
         draw_guess(length, guess, word);
         j=draw_guess(length, guess, word);     
         if(j==1)
         wrong++;
         else if(j==0)
         wrong=100;
    }
    return 0;
}

It displays two time the result if guess is true. But it may not be the actual program which is not clear to me.
Why it display two time the result ?
Thanks.

Our TA's showed us this exactly. The value of i is in the for loop im pretty sure.

The for loop comes after your declaration of your array, so how could it possibly know the value of i? Either your TA's made a mistake or they are testing you and waiting on you to catch it on your own.

Originally Posted by camel-man

The for loop comes after your declaration of your array, so how could it possibly know the value of i? Either your TA's made a mistake or they are testing you and waiting on you to catch it on your own.

They demonstrated and it worked fine.. Unless it should be declared as dashes[7] (since there can only be 6 dashes maximum) and my mind conveniently swapped that out with "i"

Originally Posted by ADH94

.. Unless it should be declared as dashes[7] (since there can only be 6 dashes maximum) and my mind conveniently swapped that out with "i"

That seems more likely.

for your printf Errors

Code:

printf("%s", display[i])

display[i] is a character, you either need to change %s to %c or change display[i] to display.

I need it to be a string though..

Then change

Code:

printf("%s", display[i])

to

Code:

 printf("%s", display)