Thread: str length of int array

If I change up my code a bit to something like this I get junk too

Code:

#include <stdio.h>
#include <string.h>


int vertPrint(int array[5]);
int main()
{
int array[5];
printf("Enter in a String of Numbers to Print Vertically");
scanf("%s", &array);



vertPrint(array, length);

}

int vertPrint(int array[5])
{
static int i = 0;

if (array[i] != '\0'){
printf("%d\n", array[i]);
i++;
return (vertPrint(array));
}
else
return;

}

>"Enter in a String of Numbers to print vertically"
Except a string is not the data structure you use in vertPrint(int array[5])
Neither is scanf() is being called correctly to fill in a string: &array is not how you pass arrays to scanf().

I suggest you read this -- FAQ > How do I get a number from the user (C) - Cprogramming.com -- and fill in an integer array, one element at a time.

Originally Posted by Sorinx

Huh a string is just an array of values, I can do the same exact code as char, and it will work correctly

A char is just one byte. You can definitely use chars to store small numbers, but in any case, you should not treat integer type variables the same as character types. For example, you're wrong about what a string is. A string is a concept formally defined in the C language as an array of bytes terminated by a zero byte. It is not just an array of values of any kind, like you imply.

Originally Posted by whiteflags

A char is just one byte. You can definitely use chars to store small numbers, but in any case, you should not treat integer type variables the same as character types. For example, you're wrong about what a string is. A string is a concept formally defined in the C language as an array of bytes terminated by a zero byte. It is not just an array of values of any kind, like you imply.

Really guy, that definition is mind blowing different than my understanding. Thanks for all the help and greatly changing my understanding of what a string is! Also thanks for the solid advice on the problem at hand, your dedication to making an effort instead of a smug response truly helped me! Thanks again guy you are a credit to this site.

Unfortunately this code still presents a lot of issues. I don't know what compiler you are using, but it absolutely blows.

Code:

mingw32-gcc.exe -Wall -ansi  -g  -pedantic -Wextra -Wall -ansi -g -std=c99    -c C:\Users\Josh2\Documents\foo\main.c -o obj\Debug\main.o
C:\Users\Josh2\Documents\foo\main.c: In function 'main':
C:\Users\Josh2\Documents\foo\main.c:12: warning: format '%s' expects type 'char *', but argument 2 has type 'char (*)[100]'
C:\Users\Josh2\Documents\foo\main.c: In function 'vertPrint':
C:\Users\Josh2\Documents\foo\main.c:33: warning: 'return' with no value, in function returning non-void
mingw32-g++.exe  -o bin\Debug\foo.exe obj\Debug\main.o    
Output size is 59.96 KB
Process terminated with status 0 (0 minutes, 0 seconds)
0 errors, 2 warnings

Both of these are things you should have been told about by the compiler, and things you ought to fix. I already told you that using & is not how you pass arrays to the scanf() function, and reading the warning tells you why. The type of the argument made is not appropriate.

Not all recursive functions have meaningful return values, so they don't have return statements, and opt to return nothing. I suspect you did not know this, so you forced the recursion to happen in a return statement. A function calling the same function in a definition is what makes it recursive. Don't force yourself to use return values.

Try this:

Code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>
 
void vertPrint(int array[5], int length);
int main()
{
int array[5], length=5, i;
printf("Enter in a String of Numbers to Print Vertically");
for (i=0;i<=4;i++)
scanf("%d", &array[i]);
 
 
 
vertPrint(array, length);
 return 0;
}
 
void vertPrint(int array[5], int length)
{
int i = 0; 
while (i <= length-1)
{
printf("%d\n", array[i]);
i++;
}
}

@laserlight
Sorry, I didn't notice that, I am a beginner.
Can I ask Is op's question is valid ?

Thanks.

Originally Posted by justine

Can I ask Is op's question is valid ?

Thanks.

What?