Thread: what am i missing?

Step 1, learn how to indent code.

Code:

#include <stdio.h>
main()
{
  char answer1, answer2, answer3;

  printf("*** QUIZ *** \n\n");

  printf("Enter the letter of the correct answer.\n\n");
  printf("Question 1: Choose the correct spelling.\n\n");
  printf("\tA) Mississippi , B) Missisippi , C) Misissippi = ");
  scanf("%c", &answer1);
  if (answer1 == 'a' || answer1 == 'A') {
    printf("\nCorrect!\n\n");
  } else if (answer1 == 'b' || answer1 == 'B') {
    printf("Wrong!\n\n");
  } else if (answer1 == 'c' || answer1 == 'C') {
    printf("Wrong!\n\n");
  } else {
    printf("Invalid input!\n\n");
  }

  printf("Question 2: How many sides does a triangle have?\n\n");
  printf("\tA) 33 , B) 3 , C) 13 = ");
  scanf("%c", &answer2);
  if (answer2 == 'a' || answer2 == 'A') {
    printf("\nWrong!\n\n");
  } else if (answer2 == 'b' || answer2 == 'B') {
    printf("Correct!\n\n");
  } else if (answer2 == 'c' || answer2 == 'C') {
    printf("Wrong!\n\n");
  } else {
    printf("Invalid input!\n\n");
  }

  printf("Question 3: 1000 + 1 = ?\n\n");
  printf("\tA) 1100 , B) 1011 , C) 1001 = ");
  scanf("%c", &answer3);
  if (answer3 == 'a' || answer3 == 'A') {
    printf("\nWrong!\n\n");
  } else if (answer3 == 'b' || answer3 == 'B') {
    printf("Wrong!\n\n");
  } else if (answer3 == 'c' || answer3 == 'C') {
    printf("Correct!\n\n");
  } else {
    printf("Invalid input!\n\n");
  }

  system("pause");
}

Next, you have to understand that %c conversion format takes the next character unconditionally (most of them skip leading white space).
So in your code, the second %c is really reading the newline from the previous question.

To test this, just type in
abc
and press enter.

To fix the problem, change the scanfs to
scanf(" %c", &answer2);
and
scanf(" %c", &answer3);
Note the leading space in the format.

Hello there,

You're question has already been answered here

C: Mutliple scanf's, when I enter in a value for one scanf it skips the second scanf. - Stack Overflow

An immediate solution would be to add a getchar() after each scanf() call.

Also, as it seems to me you need to add #include <stdlib.h> at the beginning of your code.


[Edit]:
But now that I'm reading Salem's solution after posting this, of course his solution is much simpler


Regards,
Dariyoosh

If your input is line-by-line based, then an often overlooked approach is to first read in a line and then use sscanf on the result.

Code:

#include <stdio.h>

char buf[BUFSIZ];

int main()
{
    char c='?';
    fgets(buf, BUFSIZ, stdin);
    sscanf(buf, " %c ", &c);
    printf("You entered the character '%c'\n", c);
    return 0;
}

This approach requires a little more work but to me seems a lot less error prone, because you always can restrict your attention to a single line of input. Also error handling with user input is simplified because you can check the return result of sscanf and ask the user to re-enter that line, for example. Or if the input is a file you can print out which line number the error occured on.

DON'T use fflush(stdin)
FAQ > Why fflush(stdin) is wrong - Cprogramming.com

Originally Posted by iSee

Im completely new to programming. i hope newbies are welcome...

Yes they are


Don't be offended by Salem's bluntness - A good answer is factually correct and void of any emotion.


You had a solution that you believe was correct and you shared it - That was the right thing to do.


Salem saw that your answer was not entirely correct and shared it with you - Now everyone is better off


I hope that you don't take the void of emotion as being unwelcoming (a mistake that a lot of new posters make).