Thread: Weird Turbo C based, Graphics program error

Hello,


The error that it displays is "Error: Expected )", at the 65th line. but that line (Insert function) does not have any such missing ')'

I have tried a lot of things, but haven't managed to sort out this error. Please help!

Code:

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
#include <dos.h>
#include <string.h>
#include <graphics.h>
struct node
{
int element;
struct node *left;
struct node *right;
int height;
};
typedef struct node *nodeptr;
/*void insert(int nodeptr&);
void del(int nodeptr&);
int deletemin(nodeptr &);
void find(int nodeptr &);
nodeptr findmin(nodeptr);
nodeptr findmax(nodeptr);
void makeempty(nodeptr &);
nodeptr nodecopy(nodeptr &);
void preorder(nodeptr);
void inorder(nodeptr);
void postorder(nodeptr);
int bsheight(nodeptr);
nodeptr singlerotateleft(nodeptr &);
nodeptr doublerotateleft(nodeptr &);
nodeptr singlerotateright(nodeptr &);
nodeptr doublerotateright(nodeptr &);
int max(int,int);
int nonodes(nodeptr);
*/
int gdriver=DETECT,gmode=0,errorcode;
char element[3];
int x=1,maxx,midx,xcoord,ycoord,level=320,prevlevel;
void GDisplay(nodeptr p,int xcoord,int ycoord)
{
if (p!=NULL)
{
level=level/2;
setfillstyle(1,BROWN);
setcolor(LIGHTGREEN);
if(p->left->element!=NULL)
line(xcoord,ycoord,xcoord-level,ycoord+50);
if(p->right->element!=NULL)
line(xcoord,ycoord,xcoord+level,ycoord+50);
fillellipse(xcoord,ycoord,10,10);
sprintf(element,"%d",p->element,xcoord,ycoord);
settextstyle(2,0,4);
setcolor(YELLOW);
outtextxy(xcoord-7,ycoord-7,element);
GDisplay(p->left,xcoord-(level),ycoord+50);
GDisplay(p->right,xcoord+(level),ycoord+50);
level=level*2;
}
}//end of GDisplay
void insert(int x,nodeptr& p)
{
if (p == NULL)
{
p = new node;
p->element = x;
p->left=NULL;
p->right = NULL;
p->height=0;
if (p==NULL)
{
gotoxy(4,21);
printf("Out of Space");
}
}
else
{
if (x<p->element)
{
insert(x,p->left);
//GDisplay(root,midx,50);
if ((bsheight(p->left) - bsheight(p->right))==2)
{
if (x < p->left->element)
p = singlerotateleft(p); //single rotation left
else
p = doublerotateleft(p); //double rotation left
}
}
else if (x>p->element)
{
insert(x,p->right);
//GDisplay(root,midx,50);
if ((bsheight(p->right) - bsheight(p->left))==2)
{
if (x > p->right->element)
p = singlerotateright(p); //single rotation right
else
p = doublerotateright(p); //double rotation right
}
}
else
{
gotoxy(4,21);
printf("Element Exists");
}
}
int m,n,d;
m=bsheight(p->left);
n=bsheight(p->right);
d=max(m,n);
p->height = d + 1;
}
nodeptr findmin(nodeptr p)
{
if (p==NULL)
{
gotoxy(4,21); printf("Empty Tree");
return p;
}
else
{
while(p->left !=NULL)
p=p->left;
return p;
}
}
nodeptr findmax(nodeptr p)
{
if (p==NULL)
{
gotoxy(4,21); printf("Empty Tree");
return p;
}
else
{
while(p->right !=NULL)
p=p->right;
return p;
}
}
void find(int x,nodeptr &p)
{
if (p==NULL)
{
gotoxy(4,21);
printf("Element not found");
}
else if (x < p->element)
find(x,p->left);
else if (x>p->element)
find(x,p->right);
else
{
gotoxy(4,21);
printf("Element found !");
}
}
void del(int x,nodeptr &p)
{
nodeptr d;
if (p==NULL)
{
gotoxy(4,21);
printf("Element not found");
}
else if ( x < p->element)
{
del(x,p->left);
if ((bsheight(p->left) - bsheight(p->right))==2)
{
if (x < p->left->element)
p = singlerotateleft(p);  //single rotation left
else
p = doublerotateleft(p); //double rotation left
}
}
else if (x > p->element)
{
del(x,p->right);
if ((bsheight(p->right) - bsheight(p->left))==2)
{
if (x > p->right->element)
p = singlerotateright(p); //single rotation right
else
p = doublerotateright(p); //double rotation right
}
}
else if ((p->left == NULL) && (p->right == NULL))
{
d=p;
free(d);
p=NULL;
gotoxy(4,21); printf("Element deleted !");
}
else if (p->left == NULL)
{
d=p;
free(d);
p=p->right;
gotoxy(4,21); printf("Element deleted !");
}
else if (p->right == NULL)
{
d=p;
p=p->left;
free(d);
gotoxy(4,21); printf("Element deleted !");
}
else
p->element = deletemin(p->right);
}
int deletemin(nodeptr &p)
{
int c;
gotoxy(4,21); printf("deltemin");
if (p->left == NULL)
{
c=p->element;
p=p->right;
return c;
}
else
{
c=deletemin(p->left);
return c;
}
}
void preorder(nodeptr p)
{
if (p!=NULL)
{
printf("%d-->",p->element);
preorder(p->left);
preorder(p->right);
}
}
void inorder(nodeptr p)
{
if (p!=NULL)
{
inorder(p->left);
printf("%d-->",p->element);
inorder(p->right);
}
}
void postorder(nodeptr p)
{
if (p!=NULL)
{
postorder(p->left);
postorder(p->right);
printf("%d-->",p->element);
}
}
int max(int value1, int value2)
{
if(value1 > value2)
return value1;
else
return value2;
}
int bsheight(nodeptr p)
{
int t;
if (p == NULL)
return -1;
else
{
t = p->height;
return t;
}
}
nodeptr singlerotateleft(nodeptr &p1)
{
nodeptr p2;
p2 = p1->left;
p1->left = p2->right;
p2->right = p1;
p1->height = max(bsheight(p1->left),bsheight(p1->right)) + 1;
p2->height = max(bsheight(p2->left),p1->height) + 1;
return p2;
}
nodeptr singlerotateright(nodeptr &p1)
{
nodeptr p2;
p2 = p1->right;
p1->right = p2->left;
p2->left = p1;
p1->height = max(bsheight(p1->left),bsheight(p1->right)) + 1;
p2->height = max(p1->height,bsheight(p2->right)) + 1;
return p2;
}
nodeptr doublerotateleft(nodeptr &p1)
{
p1->left = singlerotateright(p1->left);
return singlerotateleft(p1);
}
nodeptr doublerotateright(nodeptr &p1)
{
p1->right = singlerotateleft(p1->right);
return singlerotateright(p1);
}
//int count=0;
int nonodes(nodeptr p)
{ int count=0;
if (p!=NULL)
{
nonodes(p->left);
nonodes(p->right);
count++ ;
}
return count;
}
void twolinebox(int x1,int y1,int x2,int y2){
int x,y;
textcolor(WHITE);
gotoxy(x1,y1); cprintf("É"); //201
gotoxy(x2,y1); cprintf("»"); //187
for(y=y1+1;y<y2;y++){
gotoxy(x1,y); cprintf("º"); //186
gotoxy(x2,y); cprintf("º"); //186
}
gotoxy(x1,y2); cprintf("È"); //200
gotoxy(x2,y2); cprintf("¼"); //188
for(x=x1+1;x<x2;x++){
gotoxy(x,y1); cprintf("Í"); //205
gotoxy(x,y2); cprintf("Í"); //205
}
gotoxy(x1+1,y1+1);
}
void cprintxy(int x,int y,int color,char string[]){
textcolor(color);
gotoxy(x,y); cprintf("%s",string);
}
void center(int y,int color,char string[]){
int x=(80-strlen(string)+1)/2;
textcolor(color);
gotoxy(x,y);cprintf("%s",string);
}
void Temp(void){
int x,y;
clrscr();
twolinebox(1,1,80,24);
for(y=23;y>=1;y--){
sound(60*y);
center(y,YELLOW,"[Adelson-Velskii and Landis Tree]");
gotoxy(2,y+1); clreol();
twolinebox(1,1,80,24);
delay(40);
nosound();
}
center(1,YELLOW,"[Adelson-Velskii and Landis Tree]");
for(x=74;x>=3;x--){
sound(50*x);
cprintxy(x,5,RED,"Press:");clreol();
twolinebox(1,1,80,24);
center(1,YELLOW,"[Adelson-Velskii and Landis Tree]");
delay(20);
nosound();
}
twolinebox(1,1,80,12);
twolinebox(1,1,80,24);
center(1,YELLOW,"[Adelson-Velskii and Landis Tree]");
cprintxy(20,3,GREEN,"[A]- Insertion");
cprintxy(20,4,GREEN,"- Find Minimum");
cprintxy(20,5,GREEN,"[C]- Find Maximum");
cprintxy(20,6,GREEN,"[D]- Search Node");
cprintxy(20,7,GREEN,"[E]- Display Tree");
cprintxy(43,3,GREEN,"[F]- Delete Node");
cprintxy(43,4,GREEN,"[G]- Preorder");
cprintxy(43,5,GREEN,"[H]- Inorder");
cprintxy(43,6,GREEN,"- Postorder");
cprintxy(43,7,GREEN,"[J]- Height");
cprintxy(20,9,GREEN,"[any key]- Quit...");
cprintxy(20,11,LIGHTRED,"Enter your choice:   ");
}
void main()
{
nodeptr root,min,max;
int a,findele,delele,leftele,rightele,flag;
char choice,value[2];
char ch='Y';
root = NULL;
textmode(80);
Temp();
do
{
clrscr();
twolinebox(1,1,80,12);
twolinebox(1,1,80,24);
center(1,YELLOW,"[Adelson-Velskii and Landis Tree]");
cprintxy(5,3,LIGHTRED,"Press: ");
cprintxy(20,3,GREEN,"[A]- Insertion");
cprintxy(20,4,GREEN,"- Find Minimum");
cprintxy(20,5,GREEN,"[C]- Find Maximum");
cprintxy(20,6,GREEN,"[D]- Search Node");
cprintxy(20,7,GREEN,"[E]- Display Tree");
cprintxy(43,3,GREEN,"[F]- Delete Node");
cprintxy(43,4,GREEN,"[G]- Preorder");
cprintxy(43,5,GREEN,"[H]- Inorder");
cprintxy(43,6,GREEN,"- Postorder");
cprintxy(43,7,GREEN,"[J]- Height");
cprintxy(20,9,GREEN,"[any key]- Quit...");
cprintxy(20,11,LIGHTRED,"Enter your choice:\>");
       choice=getch();
       switch(toupper(choice))
{
       case 'A':
       do{
       gotoxy(4,14); printf("Enter node value: ");
       a=atoi(gets(value));
       if(atoi(value)==0)
       {
       gotoxy(4,21); printf("Error!!! Enter a valid integer value only.");
       gotoxy(4,22); printf("Press any key to continue...");
        getch();
       }
       }while(atoi(value)==0);
       insert(a,root);
       gotoxy(4,15);
       inorder(root);
       initgraph(&gdriver,&gmode,"c:\tc\bgi");
       errorcode = graphresult();
       maxx=getmaxx();
       midx=maxx/2,xcoord=midx/2,ycoord=40;
       if (errorcode != grOk)
       {
       printf("Graphics error: %d",grapherrormsg(errorcode));
       printf("Press any key to stop");
          getch();
          exit(1);
       }
       cleardevice();
       GDisplay(root,midx,50);
         getch();
       restorecrtmode();
        break;
       case 'B':
        if(root!=NULL)
       {
       min=findmin(root);
       gotoxy(4,14); printf("Min element :  %d",min->element);
       }
        break;
       case 'C':
        if(root!=NULL)
       {
        max=findmax(root);
       gotoxy(4,14); printf("Max element :  %d",max->element);
       }
        break;
       case 'D':
        gotoxy(4,14); printf("Search node :");
        scanf("%d",&findele);
        if(root!=NULL)
               find(findele,root);
        break;
       case 'E':
       initgraph(&gdriver,&gmode,"c:\tc\bgi");
        errorcode=graphresult();
        maxx=getmaxx();
        midx=maxx/2;
        xcoord=midx/2;
        ycoord=40;
         if(errorcode!=grOk)
       {
       printf("Graphics error: %d", grapherrormsg(errorcode));
       printf("Press any key to stop");
           getch();
          exit(1);
       }
       cleardevice();
       setbkcolor(LIGHTBLUE);
       settextstyle(2,0,5);
       outtextxy(20,10,"Adelson-Velskii and Landis Tree");
       GDisplay(root,midx,50);
       outtextxy(20,440,"Programmed by: Frederick Badion");
       outtextxy(20,450,"Polytechnic University of the Philippines");
       outtextxy(20,460,"2nd year Bachelor of Science in Computer Science");
       outtextxy(320,440,"A partial fulfilment for the subject: ");
         outtextxy(320,450,"Design and Analysis of Algorithm");
         outtextxy(320,460,"Prof. Ria Sagum -Chairperson BSCS-CCMITPUP-Sta.Mesa");
         getch();
          restorecrtmode();
        break;
       case 'F':
        gotoxy(4,14);printf("Delete node: ");
        scanf("%d",&delele);
        del(delele,root);
        getch();
        initgraph(&gdriver,&gmode,"c:tc\bgi");
        errorcode=graphresult();
        maxx=getmaxx();
        midx=maxx/2,xcoord=midx/2,ycoord=40;
        if(errorcode !=grOk)
       {
          printf("graphics error: %d",grapherror(errorcode));
           printf("Press any key to stop");
           getch();
           exit(1);
         }
        cleardevice();
        setbkcolor(LIGHTBLUE);
        settextstyle(2,0,5);
        outtexty(20,10,"Adelson-velskii and Landis tree");
        GDisplay(root,midx,50);
        getch();
        restorecrtmode();
        break;
      case 'G':
        gotoxy(4,14);printf("preorder printing.....");
        gotoxy(4,15);
        preorder(root);
        break;
        case 'H':
        gotoxy(4,14);printf("inorder printing....");
        gotoxy(4,15);
        inorder(root);
        break;
      case 'I':
        gotoxy(4,14);printf("postorder printing....");
        gotoxy(4,15);
        postorder(root);
         break;
       case 'J':
        gotoxy(4,14);printf("height and depth:%d",bsheight(root));
        gotoxy(4,15);printf("no of nodes:%d",nonodes(root));
         break;
       }
     gotoxy(4,22);printf("do you want to continue(y/n)?");
       ch=toupper(getch());
}
while (ch!='N');
}

Duplicate post from C++ programming.
Probably the one at C++ programming will be deleted.

@salem,

Of course not, you're just another dumb-assed copy/paste programmer who found some piece of crap code on the web.

yes, thats very true, I did find it online, but to learn, not to use in anything of my own. Yes, to you, that may seem to be "copy/paste" programming, but the truth of the matter is, that not everyone was born with C/cpp in their heads. Forgive me, but I came here to learn what was wrong with it. Not to use some other person's work. If you have nothing better to do than to creep around a forum where people come to learn, then you might as well have pointed me to the right direction, rather than pointing out the obvious.

lastly, if you have nothing constructive to say, kindly don't say anything at all.


by the way, I did sort the error out. As you said, it is a CPP code. Thats why I posted it in the CPP forum in the first place. I am not good with TurboC, and am being forced to run it in that(xp, virtualbox), as I use Linux, not windows.

Pardon my words, if harsh,
Thanks for the help, everyone, here, and in the cpp post....

I am not good with TurboC, and am being forced to run it in that(xp, virtualbox), as I use Linux, not windows.

And why are you being "forced to run it in that"? Could it be because your ass-backwards school, for which you're copying and pasting your assignment, requires it?

My guess is the problem is on line 58. That functions prototype was /* */ commented out on line 15. Try moving the /* down to line 16.

Without a prototype, Turbo C/C++ assumed int, and since there is no int, and the parameter is not an int, it believes a closing parenthesis is needed - typically a few lines late for a larger program.

Good luck. Would be a perfect time to re-write that program with good indentation, with a modern IDE and compiler.