Thread: Please Show My Mistake

Q) A program is required to input a series of at least three numbers from the keyboard. The first two numbers are to be lower and upper limit respectively. The program is require to output to the screen the total of all the following numbers which fall between those two limits, but are not equal to those limits. Use EOF to determine the end of the number sequence.
Ex: input 10, 20, 5, 12, 17, 23, 16,20
Output 45 (12+17+16)

Code:

 
#include<stdio.h>
#include<conio.h>
void main()
{
float x,y,z,sum=0;
clrscr();
printf("\n Enter atleast Three numbers:");
scanf("%f %f",&x,&y);
    {if (0<y-x)     {
        scanf("%f",&z);
            while (z==EOF){
            if(x<z && y>z)
            sum=sum+z;
            scanf("%f",&z);}
            }
        else    {
        scanf("%f",&z);
            while (z==EOF){
            if(x>z && y<z)
            sum=sum+z;
            scanf("%f",&z);}
            }
    }
    printf("\n Sum of values are :%f",sum);
getch();
}

It is

Code:

int main(void)

and not void main!!!!!!!!!!

Also when we want to handle EOF we use to have an int variable for this...

Also because an image is equal to one hundred words, take a look at the image of salem

Also it good that main returns 0 before terminating...

> scanf("%f",&z);
> while (z==EOF)
This should be
while ( scanf("%f",&z) != EOF )

This assumes the user doesn't do something stupid, like type in "hello" instead of 123.
If they do, this will just lock up.