Text file

[ulti-killer]

#include <stdio.h>
#include <ctype.h>


int main()
{
	FILE *fptr;
	char cha, vowel[11] = {"AEIOUaeiou"};
	int i, j, n_char = 0, n_let = 0, n_vow = 0, n_con = 0, letter[26] = {0};


	for (i=0; i<26; i++)
	{
		letter[i] += 65 + i;
	}


	fptr = fopen("text.txt","r");


	while ( !feof(fptr) )
	{
		fscanf(fptr,"%c",&cha);
		printf("%c", cha);
			n_char++;


		for (i=0; i<26; i++)
		{
			if ( cha == (char)letter[i] || cha == tolower( (char)letter[i]) )
			{
				n_let++;
				for (j=0; j<10; j++)
				{
					if ( cha == vowel[j] )
						n_vow++;
				}
			}
		}


		
		if ( !(cha == 'a' ||cha == 'e'|| cha == 'i'|| cha == 'o'||cha == 'u') )
			n_con++;
	
		
	}
	printf("\nTotal number of characters: %d\n", n_char);
	printf("Number of letters: %d\n", n_let);
	printf("Number of vowels: %d\n", n_vow);
	printf("Number of consonants: %d\n", n_con);
}

How to avoid the repetition of last character?

[laserlight]

Don't use feof to control the loop in that way. Instead use the return value of fscanf, e.g.,

while ( fscanf(fptr,"%c",&cha) == 1 )

The reason is that the feof call only returns a true value when the end of file condition is detected, but that condition happens only after an attempt is made to read past the end of file.

[ulti-killer]

Why number of consonants cannot get 54?

[nonoob]

You don't need to do any comparisons to count n_con. Just do n_con = n_let - n_vow;
The reason you're getting a number much higher than expected is because you are counting all letters, spaces, numbers, capitals that are not one of 'a', 'e', 'i', 'o', 'u'.

[ulti-killer]

I know can use n_con = n_let - n_vow; to do. If I dun wan use tat method, is there another solution to solve it?

*How to filter the spaces?

[AndiPersti]

Just count the stuff you want to count.
Something like:

while there is a character
    number_of_characters++
    if character is a letter
        number_of_letters++
        if character is a vowel
            number_of_vowels++
        else
            number_of_consonants++

Bye, Andreas