Shortening statements

**Mentallic** · 10-13-2012

I have this if statement

Code:

      if (strcmp(command, "p") == 0
                    || strcmp(command, "+") == 0
                    || strcmp(command, "-") == 0
                    || strcmp(command, "\n") == 0
                    || strcmp(command, ".") == 0
                    || (stringIsNum(command) == YES
                        && stringToNum(command) > 0)) {
            lineNumber = printCommand(head, command, lineNumber);
        
        }

Which is clearly getting a little ridiculous, but I'm also going to have to add a few more strcmp's later, and on top of that, I need to be able to accept a letter and its capital. Is there a way to shorten this while still making it clear, or is the way it is now the best approach?

**Salem** · 10-13-2012

For testing single letters, the first 5 could be reduced to
if ( strchr( "p+-\n.", command[0]) != NULL

> I need to be able to accept a letter and its capital.
Use toupper() or tolower() right at the start, if in general you don't care about case.

But if later on, you need "a" and "A" to be separate commands, then you might like to enforce that right at the start by saying "Not recognised P" when they should have typed p.

**Mentallic** · 10-13-2012

Originally Posted by Salem

For testing single letters, the first 5 could be reduced to
if ( strchr( "p+-\n.", command[0]) != NULL

> I need to be able to accept a letter and its capital.
Use toupper() or tolower() right at the start, if in general you don't care about case.

But if later on, you need "a" and "A" to be separate commands, then you might like to enforce that right at the start by saying "Not recognised P" when they should have typed p.

I just implemented that and it worked just as I hoped, except for one thing - it still goes into the if statement if I enter input such as px, which it shouldn't.
To fix this I'd add

Code:

if ( strchr( "p+-\n.", command[0]) != NULL && command[1] == '\0')

but I also need to accept numbers which have multiple digits into the loop.

EDIT:

Actually, all it took was some simple Boolean logic.

Code:

if ((strchr( "p+-\n.", command[0]) != NULL
                    && command[1] == '\0')
                    || (stringIsNum(command) == YES
                    && stringToNum(command) > 0))

Thanks for your help Salem

**qny** · 10-13-2012

Replace this code

Code:

if (strcmp(command, "p") == 0
              || strcmp(command, "+") == 0
              || strcmp(command, "-") == 0
              || strcmp(command, "\n") == 0
              || strcmp(command, ".") == 0
              || (stringIsNum(command) == YES
                  && stringToNum(command) > 0)) {
      lineNumber = printCommand(head, command, lineNumber);
}

with this

Code:

if (textisvalidcommand(command)) {
    lineNumber = printCommand(head, command, lineNumber);
}

and, of course, write the proper textisvalidcommand() function.

**Mentallic** · 10-13-2012

Good idea, will do.

Thread: Shortening statements

Thread Tools

Search Thread

Display

Shortening statements

Similar Threads

shortening this short code? : binary to int casting

Shortening long if statements

Shortening the code

Here's my code, any ways in shortening it?

Shortening main