Thread: Strcmp makes pointer from integer without a cast

I keep getting an error on the lines with strcmp that passing argument 3 of binsearch makes pointer from integer without a cast.
How can I fix this?

Code:

void binsearch(char *dictionary, int wordnum, char string[]) {

   //Establish low and high points
    int low = 0;
    int high = wordnum - 1;

    //Adjust midpoint as necessary
    while (low <= high) {
    int mid = (low + high)/2;
    if (strcmp(string, dictionary[mid])<0)
        high = mid - 1;
    else if (strcmp(string, dictionary[mid]) > 0)
        low = mid + 1;

    //Print out correct permutation matches
    else if (strcmp(string, dictionary[mid]) == 0){
        fprintf(ofp, "A permutation of the current word that is valid is %s.\n", string);
        break;
     }
    }

So do I just put a * in front of dictionary[mid]?

Ok, thank you.
Now am I using the bin search in the correct way?

Code:

for (j=k; j<strlen(str); j++) {
                ExchangeCharacters(str, k, j);
                binsearch((str), k, j);
                RecursivePermute(str, k+1);
                ExchangeCharacters(str, j, k);
                binsearch((str), k, j);

Here is my full function, I am still getting a few errors when I try to compile

Code:

void binsearch(char *dictionary[], int wordnum, char string[]);

Code:

void binsearch(char *dictionary[], int wordnum, char string[]) {

   //Establish low and high points
    int low = 0;
    int high = wordnum - 1;

    //Adjust midpoint as necessary
    while (low <= high) {
    int mid = (low + high)/2;
    if (strcmp(string,dictionary[mid])<0)
        high = mid - 1;
    else if (strcmp(string,dictionary[mid]) > 0)
        low = mid + 1;

    //Print out correct permutation matches
    else if (strcmp(string,dictionary[mid]) == 0){
        printf("A permutation of the current word that is valid is %s.\n", string);
        fprintf(ofp, "A permutation of the current word that is valid is %s.\n", string);
    }
    else {
        printf("This word has no permutations\n");
    }
        break;

    }
}

any suggestions, I cannot figure it out

|In function 'main':|
|41|warning: format '%s' expects type 'char *', but argument 2 has type 'char (*)[20]'|
||In function 'RecursivePermute':|

|69|warning: comparison between signed and unsigned integer expressions|

|71|warning: passing argument 1 of 'binsearch' from incompatible pointer type|
|9|note: expected 'char **' but argument is of type 'char *'|

|71|warning: passing argument 3 of 'binsearch' makes pointer from integer without a cast|

|9|note: expected 'char *' but argument is of type 'int'|

C|74|warning: passing argument 1 of 'binsearch' from incompatible pointer type|

|9|note: expected 'char **' but argument is of type 'char *'|

|74|warning: passing argument 3 of 'binsearch' makes pointer from integer without a cast|

9|note: expected 'char *' but argument is of type 'int'|
||=== Build finished: 0 errors, 6 warnings ===|

Code:

void binsearch(char *dictionary[], int wordnum, char string[]);

Code:

for (j=k; j<strlen(str); j++)
 {    
        ExchangeCharacters(str, k, j);
        binsearch((str), k, j);

You define binsearch() to take an array of pointers to char (i.e. pointer to pointer to char aka char **), an int and an array of char (i.e. pointer to char aka char *).
But you call it with a string "str" (i.e. char *), an int "k" and another int "j". (the variable types are my guesses based on your earlier usage).

Do you see your problem? Do you understand the warning messages now?

Bye, Andreas