Thread: Code giving undesired output..

/*Toggle-Case : If lower-case character entered, then change to upper-case and vice-verse :*/

Code:

#include<stdio.h>
#include<conio.h>
#include<ctype.h>

void main()

{

   clrscr();

   int a,b;
   char ch;

   do

   {
     printf("\n\n Enter any alphabet : ");
     a=getchar();

     if(a>=65&&a<=90)

      {

    b=tolower(a);
    printf("\n\n The lower-case for %c is : %c ",a,b);

      }

     else if(a>=97&&a<=122)

      {

    b=toupper(a);
    printf("\n\n The upper-case for %c is : %c ",a,b);

      }

    else

      printf("\n\n Wrong Input..!!! Alphabet ONLY ");

    printf("\n\n Do you want to continue ? (y/n) : ");

    ch=getche();

   }while(ch=='y'||ch=='Y');

    getch();

 }

Originally Posted by somali.cc

/*Toggle-Case : If lower-case character entered, then change to upper-case and vice-verse :*/

Code:

#include<stdio.h>
#include<conio.h>
#include<ctype.h>

void main()

{

   clrscr();

   int a,b;
   char ch;

   do

   {
     printf("\n\n Enter any alphabet : ");
     a=getchar();

     if(a>=65&&a<=90)

      {

    b=tolower(a);
    printf("\n\n The lower-case for %c is : %c ",a,b);

      }

     else if(a>=97&&a<=122)

      {

    b=toupper(a);
    printf("\n\n The upper-case for %c is : %c ",a,b);

      }

    else

      printf("\n\n Wrong Input..!!! Alphabet ONLY ");

    printf("\n\n Do you want to continue ? (y/n) : ");

    ch=getche();

   }while(ch=='y'||ch=='Y');

    getch();

 }

Welcome to the forum, somali.cc!

I like that you used an int variable for getchar() - nice.

But there is an easier way to do this, and technically, you haven't changed the entered letter to the other case -- you have made another variable, into the other case.

That is, "a" is still in the original (wrong) case.

I know, picky, picky!

if you were to use:

Code:

a=toupper(a);

on lower case letter 'a', what would that do?

And lastly, using the ascii values for the letters, is not preferred. Use 'A' and 'Z' or 'a' and 'z', instead. Same meaning, (usually), but it's more portable, and it makes our code more clear.

Hi Adak, thnx for replying me.

Using a=tolower(a); cud have been used, but then i cudnt have printed :- The lower-case for A is : a

And yes, i wl definitely go by ur suggestion of using 'a' /'A' instead of ASCII values..

But the code that i have provided is giving me an errorneous output when I m entering 'y'/'Y' in ' Do You want to continue ? (y/n) ' statement. Any suggestion on that ?

When you enter a value, you put two things into the keyboard buffer (the input stream in most cases): the value, AND the '\n' (newline) char, (when you hit the enter key). With integers, it's usually not a problem, or with strings, but with a char it's a BIG problem! The newline char stays in the keyboard buffer, until it reaches the getch(), and THEN you get the newline char, see? And that's NOT what you want.

There are many ways to get a newline off the keyboard buffer. In your case, a simple getchar(), before the getche(), will do it for you. I know it sounds "weird", but try it.

Thank U Adak..Thanx soo much for the explanation and solution...U rock man..!!

@Salem : True, main() always returns integer value.

What if I want a function not to return anything ?

Shud it not be preceede by the keyword void or add another statement : return(0);

pls correct me if i'm wrong as I m new to C-Programming.