Hi
this code is crashing, what did I do wrong in here?
Code:#include <stdio.h> #include <string.h> #define MAXLINES 100 char *arrFilename[MAXLINES]; void getFilenames(char **arrFilename, int limit) { strcpy(arrFilename[0],"test"); } int main (void) { getFilenames(arrFilename,MAXLINES ); printf("%s", arrFilename[0]); }
I think I fixed the issue, I am getting these errors now, how can I correct this?
c:\Nick\C projects\portal>cl filename2.c
Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.30319.01 for 80x86
Copyright (C) Microsoft Corporation. All rights reserved.
filename2.c
filename2.c(28) : warning C4047: '=' : 'char **' differs in levels of indirection from 'int'
filename2.c(32) : warning C4047: '=' : 'char *' differs in levels of indirection from 'int'
Microsoft (R) Incremental Linker Version 10.00.30319.01
Copyright (C) Microsoft Corporation. All rights reserved.
/out:filename2.exe
filename2.obj
Code:#include <stdio.h> #include <string.h> #define MAXLINES 100 #define MAXSTRING 300 char **arrFilename; void getFilenames(char **arrFilename, int limit) { strcpy(arrFilename[0],"test"); strcpy(arrFilename[1],"test test test"); } int main (void) { int i; // allocate space for sting array arrFilename = malloc( MAXLINES * sizeof(char *)); for ( i = 0; i < MAXLINES; i++) { // allocate space for each line arrFilename[i] = malloc(MAXSTRING * sizeof(char)); } getFilenames(arrFilename,MAXLINES ); printf("%s\n", arrFilename[0]); printf("%s\n", arrFilename[1]); }
You need to include <stdlib.h> for malloc's prototype. Otherwise it's assumed to return an int, which is the source of the errors. You should turn up your compiler warning level. For gcc:
gcc -Wall -Wextra yourprog.c
The cost of software maintenance increases with the square of the programmer's creativity. - Robert D. Bliss
thx, but if I forgot to include malloc function, why did it work anyway,
You didn't forget to include the malloc "function". You forgot to include the malloc "prototype". Without the prototype, the implementation makes an assumption that the function returns an int, issues a warning and compiles the code anyway. In this case (on your machine) the char* and char** pointers are the same size as an int, so the generated code worked.Originally Posted by *nick
The cost of software maintenance increases with the square of the programmer's creativity. - Robert D. Bliss
Undefined behaviour - which is what your code exhibited without the <stdlib.h> - is like that.
Within the realm of undefined behaviour, anything is allowed to happen. One of the possibilities included within "anything" is behaviour that you interpret as "working". Other behaviours are possible as well.
You could start by posting the actual code that gives you those warnings. Your code has only 30 lines but one of the warnings is for line 32.
I also compiled with GCC with all warnings enabled and got a single warning (since you're not returning a value from main).
that was the actual code minus top comments
Then you couldn't have had all warnings enabled since you should also have gotten:
warning: unused parameter 'limit'
and
warning: implicit declaration of function 'malloc'
The cost of software maintenance increases with the square of the programmer's creativity. - Robert D. Bliss
Removing the top comments screwed up the line numbering. Still, the error lines were obvious.
The cost of software maintenance increases with the square of the programmer's creativity. - Robert D. Bliss
Ah yes, I guess they should have been obvious to me. Too much coding makes me not see to well. :/
