Pointing at a string gave me segmentation fault

[hzcodec]

I'm trying to figure out how to use pointers and strings. I get segmentation fault when I run this program. I just don't understand why. I'm using gcc version 4.4.3 (Ubuntu).

#include <stdio.h>

char *my_strcpy(char *destination, char *source) {

  char *p = destination;

  while (*source != '\n') {
    *p++ = *source++;
  }
  *p = '\0';
  return destination;
}

char strA[80] = "Test string";
char strB[80];

int main(void) {

  char *pA;     // a pointer to type character
  char *pB;
  char *pC;

  pA = strA;    // point pA at string A
  pB = strB;

  pC = my_strcpy(strB,strA);
  
  return 0;
}

[christop]

Where is the newline character in your source string?

[hzcodec]

Newline? I'm not sure what you mean here. Do you mean "\n" at row 10?

[anduril462]

Yes, the '\n'. That is what stops your loop, when it finds a newline in the source string. But if there's no newline, you have an infinite loop. Why not stop when you find the null character in source? That is what officially ends a string in C anyhow.

[pablo9891]

Try to do this on line 7, at the end of a string goes a '\0'

while (*source != '\0') {

[hzcodec]

Ahhh. Of course pablo9891. Typo at row 7. I'm blind. Thank you for all your help.