EOF detection

**rsnair2** · 05-29-2012

Hey guys,

This is my first thread here, so I apologize in advance for breaking any conventions

. Anyways, I have been having the most horrible time getting this to work and I know that I have done something similar before. So the gist of it is, I have a small peice of code to read a bunch of numbers on a text file, and store it to a dynamicly sized array. But, I am simply unable to get it to stop at the EOF. This peice of code just gets into an infinite loop. If I replace the num[i-1] with i<= 10, it reads the 10 numbers fine. Any help would really really be appretiated. Thanks in advance.

Code:

         for (i = 1; num[i-2] != EOF; i++)    {

            if (i == x-2)    {
            x += 10;
            num = realloc (num, sizeof (int) * x);
            } 

            fscanf (infile, "%d\n", &num [i-1]);
            printf ("%d\n", num[i-1]);
        
        }

**laserlight** · 05-29-2012

I suggest an approach like this:

Code:

int temp;
while (fscanf(infile, "%d", &temp) == 1) {
    if (size == capacity) {
        /* increase capacity */
    }
    num[size++] = temp;
}

where size is the number of elements in use in the dynamic array and capacity is the number of elements for which space has been allocated.

Note that for realloc, you should by right assign to another pointer to avoid overwriting your num pointer in case realloc returns NULL. If realloc does not return NULL, then you assign this pointer to num, otherwise you handle the error.

**rsnair2** · 05-29-2012

Thanks, that worked like a charm and thanks for the tips about realloc as well. I sometimes tend to assume that the functions I call will always work!! But out of curiosity, is there any reason the EOF method should not work? I mean is there any error in the code that I came along with. Shouldn't it work and the loop terminate when EOF is hit?

**ssharish2005** · 05-29-2012

Well clearly what your thinking isn't right on you can read the EOF. You wont be reading EOF into the num array. fscanf functin will return EOF as soon it hit the EOF. Therefore checking the num array to check if it has EOF is not going to work cleary!

ssharish

**rsnair2** · 05-29-2012

Ahhh!!! Thanks, that makes a lot of sense.

Thread: EOF detection

Thread Tools

Search Thread

Display

EOF detection

Similar Threads

object detection

Better key detection?

PCI Bus Detection

internet detection

key detection

Tags for this Thread