Thread: struct and strcpy

hello!
i'm trying to implement a function which build struct by adding each struct at a certain postion which been set by "number of flight"

the struct build like this:

Code:

typedef struct flight_{
int number;
char* date;
char* origin;
char* destination;
struct passengerslist* passengers;
}flight;

typedef struct flightslist{
flight* info;
struct flightslist* next;
}flights_list;

the prototype of this function is the following:
flights_list* add_flight(flights_list* flights, int number,char* date, char*
origin, char* destination)

i got trouble when i'm trying to copy the strings such date, origin and so
to certain struct.

i use strcpy.

this is my code.

Code:

flights_list* add_flight(flights_list* flights, int number,char* date, char* origin, char* destination){
	
	flights_list *temp, *newCell, *head;
	flight *temp_info;
	
	temp_info=(flight*)malloc(sizeof(flight));
	newCell=(flights_list*)malloc(sizeof(flights_list));

	

	strcpy(temp_info->date,date);
	strcpy(temp_info->destination,destination);
	strcpy(temp_info->origin,origin);
	temp_info->number=number;
	newCell->info=temp_info;

	if(flights==NULL){
		newCell->next=flights;
		return newCell;
	}
	
	head=flights;
	while(head != NULL || newCell->info->number > head->info->number){
		temp=head;
		newCell->next=head;
		temp->next=newCell;
		head=head->next;
	}
	head=temp;
	return head;
}

Your struct only contain pointers, you can not copy a string to a pointer unless it points to some memory that you own. Either allocate enough for each string, or if you have strdup() available use that, it will allocate enough memory and copy the string for you. If you don't have it, it might make sense to make such a function yourself.

ok, so it can be sloved like this:
temp_info->date=(char*)malloc(sizeof(255));
and so on??

Originally Posted by orid

ok, so it can be sloved like this:
temp_info->date=(char*)malloc(sizeof(255));
and so on??

Sizeof(255) is probably not doing what you think, it makes more sense to use strlen(date) +1, for malloc, then you can use strcpy(). But as you do this more than once in a row, you can wrap both the strlen(), malloc() and strcpy() in a function that takes a string as argument and return a fresh new string.