Help needed in validation please.

[caz0026]

Can someone please help me with this code:

int validateSectionLetter(char c)
{
    
    if (!isalpha(c))
    {
        printf("\n** You entered an invalid section. Please enter a section from A to Y. **\n\n");    
        return 0;
    }
    else if ((c = 'Z') || (c= 'z'))
    {
        printf("\n** You entered an invalid section. Please enter a section from A to Y. **\n\n");    
        return 0;
    }


    return c;
}


char enterSectionLetter()
{
    char  c = 0;
    
    do
    {
        printf("Enter Section [A - Y]: ");
        scanf("%d", &c);   
    }


    while(!validateSectionLetter(c));
    
    printf("The section is: %c", &c);
    return c;    
}

When I compile, if I enter a wrong character it will loop and writing the appropriate message, but when I enter a correct character like 'a' the .exe goes crazy.

Thank you in advance.

[dpitz]

Attention, you're using the "=" sign to compare two chars, and using "%d" in the scanf.

[caz0026]

Thank you dpitz! Didn't notice it there, the .exe stopped going crazy but I'm still not getting my intended output. Enter section [A-Y] is being printed twice, and the section is returns garbage. :/

[dpitz]

Your function must return an int, and you return a char.

The "Enter section [A-Y]" is printed not only twice, but as many characters you type plus one (the '\n' character), so it means that each character is tested in your validateSectionLetter function (I don't know if this is what you want). Look what happens when you type "zzz" and "zaz", for example.

You'd better use getchar() to scan a char, not scanf. Take a look at this link: www . gidnetwork . com/b-60 . html

[caz0026]

Thank you very much, I did what you said but I'm still not getting the result I'm expecting. The program is asking me to enter section from A to Y as usual, when I enter A it says invalid choice and loops back , I enter A again and the program continues :s

This is my code so far:

int validateSectionLetter(char c)
{
	
	if ((!isalpha(c)) || (c == 'Z') || (c == 'z'))
	{
		printf("\n** You entered an invalid section. Please enter a section from A to Y. **\n\n");	
		return 0;
	}
	
	return c;
}


char enterSectionLetter()
{
	char  c = 0;
	
	do
	{
		printf("Enter Section [A - Y]: ");
		c = getchar();
		while (getchar() != '\n');   
	}
	
	while(!validateSectionLetter(c));
	return c;	
}

[dpitz]

It works here, I typed this into main:

char a = enterSectionLetter();
printf("\nChar is: %c", a);

If I execute the program and type A it gives "Char is A".