Thread: program won't exit

I am pretty new to C programming and this is a homework assignment.
I do not understand why my program will not exit. I looked at a previous program I wrote for this same class and it literally looks the exact same but the old one works and this one does not. Here is my code. Everything except the quit works. Whenever I choose option 4 for quit I get the default statement for some reason and then it loops and shows the menu over and over again.

Code:

#include <stdio.h>
#include <stdlib.h>
#include "boolean.h"
#include "stack.h"
 

int menu(void);
 

int main(void){
 

boolean quit=FALSE;
int selection, num;
stack top;
 

init_stack(&top);
menu();
 

  while (!quit){
    scanf("%d", &selection);
    switch (selection){
 case 1:
 if (is_full()){
 printf("Cannot add another value. It is already full\n");
 }
 else{
 printf("Please enter the number you would like to add\n");
 scanf("%d", &num);
 push(&top, num);
 }
 break;
 case 2:
 if (is_empty(top)){
 printf("Cannot remove a value. There are none to remove.\n");
        }
 else{
 num = pop(&top);
        printf("%d has been removed from the stack\n", num);
        }
 break;
 case 3:
        if (is_empty(top)){
        printf("There is nothing to print\n");
        }
        else{
        print_stack(top);
        }
 break;
 case '4':
 quit = TRUE;
 break;
        default:
        printf("Error: that is not a valid selection. Please try again.\n");
        break;
}
if (!quit){
menu();
}
}
printf("Have a nice day!");
}
 
int menu(){
printf("Please select from one of the following options:\n");
printf("1. Push\n2. Pop\n3. Print\n4. Quit\n\n");
printf("Please enter your selection ");
}

Thank you for any help!

Programs that are menu-driven usually have a do-while structure in main, example in pseudocode:

Code:

int user_menu (void)
{
    /* here you get the user selection and parse it with the switch statement */
    if (user_input == quit) {
        return -1;
    return 0;
}

int main(void)
{
    do {
         
    } while (user_menu() > 0);
}

You might want to re-structure your program accordingly.

Thank you very much for the reply, but my teacher wants us to use a while loop for our menu like I have it, so I cannot change the structure of the menu.

Well, to fix the problem of it not exiting, you could put a "return;" after you call menu() if QUIT is true.

she actually mentioned something like that. She said she doesn't want us to use a "forced" exit like a return statement or an exit statement. Thank you for the reply though. Can anyone see why my while loop is not ending when quit is switched to TRUE? that is the answer I am looking for if anyone sees it... Thank you!

Heh, you'll kick yourself.....

Code:

 case '4':
 quit = TRUE;

Your "4" is in single quotes, meaning the character 4 not the number.

Originally Posted by smokeyangel

Heh, you'll kick yourself.....

Code:

 case '4':
 quit = TRUE;

Your "4" is in single quotes, meaning the character 4 not the number.

Wow... lol.. Thank you! That was it!