Thread: string compare

i want the user to enter 50 names. i want to see if there is a match using strcmp but it wont work. any suggestions?

Code:

#include <stdio.h>
#include<string.h>


int main()
{
    char string[50];
    char strcmp[50];
    int i;
    printf("enter 50 names\n");
    for(i=1;i<=50;i++)
    {
        scanf("%s",&string);
    }
    strcmp();


    if(strcmp==0)
    {
        printf("we have a match");
    }
    return 0;
}

Originally Posted by ledow

The first example I pulled out - you're calling a variable with the same name as the function. Your compiler should have gone mad about this and put up lots of errors.
The second example - you're calling strcmp with no parameters at all. What's it supposed to be comparing to what? You also don't do ANYTHING with the return value of it. Your compiler should have gone mad about this and put up lots of errors.
The third example - you're calling strcmp with no parameters at all again, but at least you do try to do something with the results. However, guess what, Your compiler should have gone mad about this and put up lots of errors!


Even if you fix those errors, your program does basically nothing at the moment. Your scanf is completely ridiculous and reads in 50 strings into the same variable, that can only hold one of length 50 (without bothering to check their length, etc. either), each time overwriting the previous.

Even if you fix that and enter 50 names, you then do ONE check of two strings (which two I have no idea, neither does your compiler, because of the above problems). Surely you would need to check the new name against ALL the names previously entered ?

You haven't even tried at all to compile this, let alone write it properly.

ye basically everything i wrote there is garbage ha i only read strcmp's today and gave it a shot. suprisingly there were like 3 errors. but your complete enialation of my programme actually had me laughing at how studiply it is written ha "your scanf fucnction is completely ridiculous".thanks anyway

oh yes ill try that tanks

Somethings here...

1. You cannot have a variable name the same as a function name. The compiler will not know how to handle/or work with them.
2. Look up how strcmp() is used, strcmp(3): compare two strings - Linux man page

And follow what ledow has said.

i just dont know how to get the user to enter several names and then compare them using arrays