Linked list program, don't understand it fully

[pwnsyoshi33]

my program doesn't work like it should. I know whats not working, I just don't know how to fix it. In the program I keep replacing start with temp. I'm new to the concept and pretty confused.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
main()
{
    struct node
    {    
        int value;
        
        node *next;
    };   
       
      node * temp;
      node * start;
      node * end;
            
      temp = new node;
      temp ->value =5;
      temp ->next = NULL;
      
      start = temp;
          
      temp = new node;
      temp ->value =2;
      temp ->next = NULL;
      
            
      start = temp;
     
      temp = new node;
      temp ->value =7;
      temp ->next = NULL;
      
      start ->next = temp;
          
          for(node *s = start; s; s = s->next)
            {
                
              printf("Number : %d\n", s->value);
            }
 
      system("pause");  
      
}

I am aware I don't use "end" in the program. I have been changing things and haven't used it in the current version.

[anduril462]

I know whats not working, I just don't know how to fix it.

And you chose to keep this info from us? It's hard for us to find your problem if you don't explain what is wrong. What output do you get? What output are you expecting? In a linked list, all the nodes need to be linked. Why are you setting temp->next to NULL?

[pwnsyoshi33]

After I create a new value, I place it in start. I just don't know how to link it together.

as in my code

temp = new node;      temp ->value =5;
      temp ->next = NULL;
       
      start = temp;
           
      temp = new node;
      temp ->value =2;
      temp ->next = NULL;
       
             
      start = temp;

I assign the new values to start. I don't know how to link the values together.

[anduril462]

Mods, please move.

Ugh. This is C++ (using new instead of malloc()), and it's in the C forum. Out of the 4 threads you started, 3 were in the wrong forum, and one was a duplicate. You've failed pretty hard at basic forum use so far. Please read the following:
Announcements - C Programming
How To Ask Questions The Smart Way

Learn to use the forums properly if you want help.

You need to link the nodes like so:

// first node -- assumes you allocated and set it's value
temp->next = NULL  // set it's next element to NULL, i.e. the last node in the list
start = temp;  // set start to the start of the list

// all subsequent nodes -- assumes you allocated and set it's value
temp->next = start;  // prepend new node to beginning of list
start = temp;  // set start to the new beginning

That builds your list by adding nodes to the beginning. Adding them to the end is a bit more tricky, so given the troubles you were having in your previous post, I think you need to play with linked lists this way before moving on.

[laserlight]

Indeed. pwnsyoshi33, do you intend to write this program in C or C++?