Thread: my array prints out junk...Help..its a movie ticket and pop corn redemption program

First up all, Do not attach any file in this forum. Read the Rules.
I do not know what is the logic behind the below line.
Anyway I found out some small things. Red color means changes, Green Color means new addition on your code

Code:

printf("Admin No.\t\tTickets\t\tPop_corn\t\tPoints\n");
for(int row=0;row<=4; row=row+1)
{
for( int column=0; column<=3; column=column+1)
printf("%d\t\t\t%d\t\t\t%d\t\t\t%d\n",admin[column],no_of_mo vie_tickets,no_of_pop_corn_packs,points);
}

Attaching files is not against the rules.

Originally Posted by whiteflags

Attaching files is not against the rules.

Then what is the purpose of Code Tags?
Announcements - General Programming Boards

That has ABSOLUTELY NOTHING to do with whether or not attachments are okay.

Originally Posted by ArunS

First up all, Do not attach any file in this forum. Read the Rules.
I do not know what is the logic behind the below line.
Anyway I found out some small things. Red color means changes, Green Color means new addition on your code

Code:

printf("Admin No.\t\tTickets\t\tPop_corn\t\tPoints\n");
for(int row=0;row<=4; row=row+1)
{
for( int column=0; column<=3; column=column+1)
printf("%d\t\t\t%d\t\t\t%d\t\t\t%d\n",admin[column],no_of_mo vie_tickets,no_of_pop_corn_packs,points);
}

i've tried it the program block shuts after keying in all the data???

I don't understand what you're saying.

i've tried it the program block shuts after keying in all the data???

what do you mean?

Although I have to say, the bit below would make a lot more sense if the results where in some kind of matrix. I can see that you were thinking about that in your code, but if the data is not actually in a matrix, then you shouldn't really think about output in terms of rows and columns. You will end up printing too much stuff. You only have four data points anyway.

Code:

for(int row=0;row<=4; row=row+1)
{
for( int column=0; column<=3; column=column+1)
printf("%d\t\t\t%d\t\t\t%d\t\t\t%d",admin,no_of_mo vie_tickets,no_of_pop_corn_packs,points);

}

If it were me I would put every variable in the point formula in a structure and call that my redemption structure. That organizes the data. Then you can either process the points one at a time or build an array of structures. When you go to print a structure, simply output each member with printf...

Originally Posted by whiteflags

Although I have to say, the bit below would make a lot more sense if the results where in some kind of matrix. I can see that you were thinking about that in your code, but if the data is not actually in a matrix, then you shouldn't really think about output in terms of rows and columns. You will end up printing too much stuff. You only have four data points anyway.

Code:

for(int row=0;row<=4; row=row+1)
{
for( int column=0; column<=3; column=column+1)
printf("%d\t\t\t%d\t\t\t%d\t\t\t%d",admin,no_of_mo vie_tickets,no_of_pop_corn_packs,points);

}

If it were me I would put every variable in the point formula in a structure and call that my redemption structure. That organizes the data. Then you can either process the points one at a time or build an array of structures. When you go to print a structure, simply output each member with printf...

what exactly do u mean by putting every variable in point formula?Do i make these 3 variable to a main variable?

basically..what i meant was..when i run it( adding yr green code to admin), it was running smoothly then suddenly, the arraying cause the program to force close..and the program pops out and restarts again....

Originally Posted by smeraldan

what exactly do u mean by putting every variable in point formula?Do i make these 3 variable to a main variable?

In your code, you did this

Code:

points = no_of_movie_tickets * 125 + no_of_pop_corn_packs * 75;

You got those three variables from the user. I want you to make all three of those into a struct like this

Code:

struct redemption
{
   int no_of_movie_tickets;
   int no_of_pop_corn_packs;
   int admin;
};

/* in main: */
struct redemption example;
example.no_of_movie_tickets = 2;
example.no_of_pop_corn_packs = 1;
example.admin = 12345;

Then you make four of them in an array, since you want the user to enter four; unless you want to process one redemption at a time, then you can get away with one instance and using it over and over.

Suddenly you know exactly what to get and exactly what to print because all of the data for one redemption is together. And you don't have to worry about using a matrix like this:

Code:

char Results[4][3]

which a lot of the code you wrote suggests you were trying to do to solve the problem. If you forget about writing matrix code and rewrite some things, you'll fix your problem.

Have you tried only admin[column] or what exactly did changes on your code?
Post your changed code only and also post the results

Originally Posted by smeraldan

basically..what i meant was..when i run it( adding yr green code to admin), it was running smoothly then suddenly, the arraying cause the program to force close..and the program pops out and restarts again....

What is the exact output do you want?

Originally Posted by ArunS

What is the exact output do you want?

i want the output to print out all the items i've keyed in, the admin no, the no_of_movie_tickets,the no_of_pop_corn and total points 1 column for each....