need help with a program

[David_Baratheon]

Hi everyone. A bit stuck on a program. Im trying to make the basic structure of a prgram but it doesnt seem to work. Can anyone check it and tell me what im doing wrong? Once its working I intend to start putting some meat onto the program but first want the basic shell working:

#include<stdio.h>
void 1();
void 2();
void main()
{
char 3;
char repeat;
do
{
printf("Please press 'b' if you have a something and you wish to do\n or\n please press 'v' if you have something else you wish to do ");
scanf("%c",&3);
if (3='b')
{
2();
}
else
{
if (3='v')
{
1();
}
printf("Do you wish to repeat the program? (y/n)");
scanf("%c",&repeat);
}
while(repeat=='y');
}
　
　
　
　
　
void 1()
{

printf("it works");
}
　
　
　
　
void 2()
{

printf("it works");
}

due to time constraints Im not looking to increase the functionality of the code, I just want it to work. If we ca get it to print "it works" when I choose that function then that'd be great. i know there are issues with this program but dont have time to make it better, just need a basic functioning program. thanks for your help

also, as its an assignment ive had to change the details, so that I can see the principles and techniques without risking getting done for plagurism or something.

I edited important names and replaced them with 1, 2 or 3 so please bare in minf they arent actually 1, 2 and 3 in my program they are sensibly named variables and functions

[rogster001]

your entire post is littered with textbook "we won't help you with that" sentences, its a sorry mess and you should consider a different course if you really cant be arsed to work.

[kcpilot]

your "naming convention" for functions needs some help. Try naming your functions starting with a letter, like "my_1()". I doubt if this program even compiles, much less execute.

And I agree with the first poster --- try reading a book on 'C' first

[David_Baratheon]

your entire post is littered with textbook "we won't help you with that" sentences, its a sorry mess and you should consider a different course if you really cant be arsed to work.

I dont understand what you mean by that. Ive seen many others post up some code here and get some help with their errors, is there a problem with mypost?

what do you mean by textbook "we wont help you with that sentences"?

[David_Baratheon]

your "naming convention" for functions needs some help. Try naming your functions starting with a letter, like "my_1()". I doubt if this program even compiles, much less execute.

And I agree with the first poster --- try reading a book on 'C' first

I have other names in the actual program but I risk plagurism if I post it exactly the same so deleted them and rpelaced them with numbers. I jave sensible naming conventions in my actual programs. I just need to know in principle wh this program wouldnt work if the naming conventions were correct. Im at university studying electrical and electronic engineering, we have studied some basic c, hello world, variables, loops, if statements and functions and now we have to use them for a simple program but mine isnt working so just needed to get some help with it if thats ok

[rogster001]

ok maybe i was a bit harsh, it just looks as if you are writing 'oh dear i ran out of time and now i just want something, anything that works, and i dont care what it is'! One error you have is you should use == for comparison, not ' = ' also get some good habits and indent your code properly, and dont worry about renaming fucntions with daft things like 1 ,2 ,3, we are not the KGB, you should use your original code, with the, as you suggest, sensible proper naming conventions, then you wont get people erroneously giving you grief as above. :->

[memcpy]

I dont understand what you mean by that. Ive seen many others post up some code here and get some help with their errors, is there a problem with mypost?

Yeah, it's annoyingly difficult to read your post because it's strife with error.

I'm not talking about your code, but at first glance, I see a bunch of obvious errors with that too. (just look at the "if" statements).

[David_Baratheon]

no problems, thanks for your response. regarding the naming conventions, as I understand it, the university has a plagurism system which searches online so if my exact program comes up it could look bad. I appreciate noone on the site would compromise my studies but just in case the university misunderstands and think i pulled it from the net or something id rather keep the code generic and get general pointers to my errors like the good advice you've already given.

Definitely we are in agreement on the need for good indentation etc i my actual program. Concerning the ==, which bits need one that ive neglected?

[David_Baratheon]

Yeah, it's annoyingly difficult to read your post because it's strife with error.

I'm not talking about your code, but at first glance, I see a bunch of obvious errors with that too. (just look at the "if" statements).

i appreciate that, I did try and tidy it up so hopefully there arent too many errors in there now. Thanks

could you specify exactly what is wrong with the if statements if thats ok?

[rogster001]

Why will you get done for plagarism? Its your own work after all?? And if the tutor had supplied names like GetFooBar() in the question, then why would there be any harm in using that? The only possible plagarism is in the implementation, the name is entirely subjective.

[rogster001]

you write
if suchAndSuch = x
it should be
if suchAndSuch == x

[David_Baratheon]

please note tht while i think conventions and better practice are important, at this stage im only looking at the things that will stop it working altogether. If if will still work but isnt good practice then it is something I plan to improve in the long run but nee to prioritise things that will completely stop the program working such as one = instead of == or something like this

[David_Baratheon]

Why will you get done for plagarism? Its your own work after all?? And if the tutor had supplied names like GetFooBar() in the question, then why would there be any harm in using that? The only possible plagarism is in the implementation, the name is entirely subjective.

its not that im committing plagurism its that i might get suspected of plagurism if my exact code is found online. Just saving myself a potential headache by playing it a bit safe. please be understanding of this, it would ruin my life if I got kicked out of uni for plagurism and know people who got kicked out for it, so i just feel more comportable to do it this way just in case

[rogster001]

please note tht while i think conventions and better practice are important, at this stage im only looking at the things that will stop it working altogether. If if will still work but isnt good practice then it is something I plan to improve in the long run but nee to prioritise things that will completely stop the program working such as one = instead of == or something like this

Mate your thinking is all wrong, if you keep on with that 'mend and make do' attitude then you will only ever produce ugly, cobbled together hacked workaround programming

[David_Baratheon]

you write
if suchAndSuch = x
it should be
if suchAndSuch == x

ok great thanks, thats cut a couple of errors out. Still getting some though, can u see any other obvious errors?