Thread: scanf lock the gets?

if i use scanf() the program do not work by gets it"s work

Code:

#include <stdio.h>
#include <stdlib.h>
 int main()
 {
    char *ptr;
   char a[6]="mohsn";
gets(a);
puts(a);
scanf("%s",ptr);        //if i use gets(ptr);program will be work  
puts(ptr);
ptr=a;
gets(ptr);    //this gets do not get the new value ?
puts(ptr);
 return (1);
 }

First, read these links:
FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com
FAQ > Get a line of text from the user/keyboard (C) - Cprogramming.com

Then, you need to explain exactly how scanf isn't working. What input do you give? What output do you get? What output do you think you should get?

In your program ptr doesn't point to valid memory, so trying to store a string in ptr, whether with scanf or gets, will result in undefined behavior, meaning anything can happen. Don't do it. Make it point to valid memory first, by malloc'ing some memory or pointing it at a valid char array like a. You should put a length limiter in scanf, like "%5s" to avoid overflowing a.

I'm not sure what you mean by "this gets do not get the new value ?", please be more clear. And again, don't use gets.

Also, you should return 0 from main to indicate successful completion of your program. Non-zero values typically signify some error.

Originally Posted by anduril462

First, read these links:

Then, you need to explain exactly how scanf isn't working. What input do you give? What output do you get? What output do you think you should get?



I'm not sure what you mean by "this gets do not get the new value ?", please be more clear. And again, don't use gets.

Also, you should return 0 from main to indicate successful completion of your program. Non-zero values typically signify some error.

hi
if use scanf & gets in both sutation it s worked but the last gets() do not take a new string
the last puts() show the older ptr (ptr=a). give three different string to the program but the last sting will not show on the screen

What's with the giant, bold font. Please just use the regular font from now on.

I think I understand your problem now. When you use scanf with %s to read input, it stops at the first white space, which includes a new line. After you type your string and hit enter, scanf takes the string out of the input buffer but leaves the new line. Then the next gets looks at the input buffer and sees a new line. It thinks you pressed enter without typing anything. scanf is often not the best option for user input, but gets is worse. Never, ever use or ask or think about gets again. It is a dirty, nasty, horrible function that never should have been invented. Read the links (the red text -- click it) from my first post. It will explain how to use fgets to read a line of input. That's your best bet in this case.

Really thank you anduril.