If else if stament help

[langamer101]

from what I understand of this this code I created using if else if statement (assignment) seems correct to me.
but for some reason it is not printing L or

#include<stdio.h>
#include<conio.h>
main()
{
    clrscr();
    int x,y,z,l;
    printf("Enter value for x: ");
    scanf("%d",&x);
    printf("Enter value for y: ");
    scanf("%d",&y);
    printf("Enter value for z: ");
    scanf("%d",&z);
    if (x>y)
        l = x;
    else if (y>z)
        l = y;
    else if (z>x)
        l = z;
    else
        printf("The large number is %d", l);
    getch();
    return(0);
}

[ledow]

Why have you put the printf inside the else? It will only get executed if x <= y and y <= z and z <= x (i.e. it will never print unless they all the same number).

Scrap the else (that said, I have no idea why you've used if/else to do... what? Find the largest number?)

[stahta01]

You either set the value of "l" or output the value of "l".
Please show the sequence that results in both setting the value and outputting it.

Tim S.

[langamer101]

so I don't put printf inside else. ok let me try

[langamer101]

seems to me that I have no idea of putting printf outside of else @ledow so I will try @stahta01 suggestion.

[langamer101]

for some reason if i put printf inside "else if" it dont work just goes directly to else? what the heck.

[ArunS]

If x,y and z are equal, it will go to else part.

[langamer101]

so i redo everything here is code
it works but still there is problem in y or z
if i input in x as 1, y as 32, z as 3
the output goes directly to z or 3. wth?

#include<stdio.h>
#include<conio.h>
main()
{
    clrscr();
    int x,y,z;
    printf("Enter value for x: ");
    scanf("%d",&x);
    printf("Enter value for y: ");
    scanf("%d",&y);
    printf("Enter value for z: ");
    scanf("%d",&z);
    if (x>y)
        printf("The large number is %d", x);
    else if (z>x)
        printf("The large number is %d", z);
    else if (y>x)
        printf("The large number is %d", y);
    else
        printf("all values are the same");
        getch();
    return(0);
}

[Tibo-88]

Your problem is what you want, is for example to print the value of x if x is the biggest number, not only if x is bigger than y (same for the other conditions). So what you should test, is if x is bigger than y AND bigger than z, which would make it the biggest number between x, y and z.

[ArunS]

Recheck your logic which you implemented.
For i/p: x=10; y=5; z=15;
what will be the o/p of your program?

[langamer101]

It seems Tibo-88 suggestion worked for me thanks and thanks for all the help guys
so here is code redone
so I tried calculating true or false and saw that "z > x" and "y > x" was wrong.

#include<stdio.h>
#include<conio.h>
main()
{
    clrscr();
    int x,y,z,l;
    printf("Enter value for x: ");
    scanf("%d",&x);
    printf("Enter value for y: ");
    scanf("%d",&y);
    printf("Enter value for z: ");
    scanf("%d",&z);
    if (x>y)
        printf("The large number is %d", x);
    else if (z>y)
        printf("The large number is %d", z);
    else if (y>x)
        printf("The large number is %d", y);
    else
        printf("All values are the same %d", l);
        getch();
        return(0);
}

[Tibo-88]

I'm happy if you succeed to make it work, but it seems like the code you just posted is exactly the same than before !

[langamer101]

Its looks exactly the same but its not in logic.
so basically i started looking where would the large number go if true or false
if x > y it would print x if false goes to next else if
if z > y it would print z if false goes to next else if
if y > x it would print y if false goes to x. but thats how I solved it.
the program now works.

[Tibo-88]

I'm sorry to disappoint you, but the logic is still not good. What if x > y but z > x? Then your program will print x, even if z is bigger than x.

[ArunS]

Its looks exactly the same but its not in logic.
so basically i started looking where would the large number go if true or false
if x > y it would print x if false goes to next else if
if z > y it would print z if false goes to next else if
if y > x it would print y if false goes to x. but thats how I solved it.
the program now works.

what will be the o/p of for the below conditions, as per your logic?
i/p: x=10; y=5; z=15;
Recheck your logic as per post#9