Thread: Fgets,finding end of file without using eof feof

Why don't you want to use EOF? That is the standard way of detecting end of file conditions. In the pre-DOS world control Z was used by some operating systems to indicate the end of file, but most modern operating systems (Including MSDOS) do not use any character as an end of file marker. You are using fgetc() which returns EOF when the end of file is reached, so use that.

Also the loop following your calloc() is not doing what you think it is.

Jim

I didn't say anything was wrong with your calloc call I said the loop following that call is probably incorrect.

Jim

That is the code and look the output.I think i found what is the end of file

Code:

#include <stdio.h> 
#include <ctype.h> 
#include <stdlib.h> 




//***********MY FGETS FUNCTION**************
char *Tomgets(FILE *filex,char *filename)
{
char *p;
char c;
int i=0;
int len=-1;  //abc\0  0 1 2 3




    for(i=0;c!=EOF;i++)
    { 
        c=(fgetc(filex));
        //printf("%c",c);
        len++;
    }
    fclose(filex);
//-------------closed and reopened file to start fgetc from beginning to the end-------------
    filex=fopen(filename,"r");
    p=(char *)malloc(len*sizeof(char));
        for(i=0;i<len;i++)
        {
            c=(fgetc(filex));
            p[i]=c;
        }
        //p[i]='æ';
        printf("length_file=%d\n\n",len);
         printf("%c\n\n",p[i]);
return p;
}
 //****************************************
int main(void) {
   int i=0;
   FILE *fp;
   char *content;
   char namex[]="t.txt";






   if((fp=fopen(namex, "r")) == NULL) 
   {
      perror("Error: unable to open the input file");
      return 0;
   }
   content=Tomgets(fp,namex);//if i do this, i dont have to do the memory allocation of content.
   printf("*%s*",content);
   printf("\n\n");
   fclose(fp);
   return 0;
}

The end of file is 4 times of Square symbol?

Code:

for(i=0;c!=EOF;i++)
{
    c=(fgetc(filex));
    printf("%c",c);
    len++;
}

When this loop finishes c will contain the value EOF and you don't get to use any of the previous values of c in the following loop in your code.

Code:

for(i=0;i<len;i++) p[i]=c;

You should fill p as you get characters from filex.

c is also the wrong data type. fgetc returns an integer. This is by design: the value of EOF is guaranteed to be outside the range of char.

i ordered my code , and made new one , could you look my previous post please?

I looked at your previous post, my advice is the same.

The end of file is 4 times of Square symbol?

The end of the file is the end of the file. If you did a correct job, you should not see anything on the screen that is not in the file.

Could you try this code?
if the 2222 was the garbages of the memory,yes you are right and it is not the symbol of the end of file,
while you trying on your machine, if it gives same result, i can say it is the symbol of the EOF.

The following snippet:

Code:

    for(i=0;c!=EOF;i++)
    {
        c=(fgetc(filex));
        //printf("%c",c);
        len++;
    }

Why are you using a for loop? This loop really should be a while() loop. You never use the variable i so why even use it. Something more like:

Code:

        while(fgetc(filex) != EOF);
            len++;

Also you should read the FAQ as to why you should not use EOF to control a loop. Also this FAQ on EOF may also be useful.

Also you should not be casting the return value of your malloc() call, also a FAQ entry


Jim

Originally Posted by rac1

Could you try this code?
if the 2222 was the garbages of the memory,yes you are right and it is not the symbol of the end of file,
while you trying on your machine, if it gives same result, i can say it is the symbol of the EOF.

No you can't. For one thing, I know better, and EOF is not actually stored in a file. It is only relevant to files from the digital dark age known as MS-DOS which I assume you don't want to support. It's older than I am.

For another thing, if I fix your program I get this as the output.

Code:

C:\Documents and Settings\User\My Documents>a
length of file = 55
*alican 99 sirvan aq
osman
xzaaaaaa
r
r
r
t
v
t
r
 a e t*

C:\Documents and Settings\User\My Documents>

There is no magic EOF value for anyone to see.

Thanks for helping Jim and Whiteflags.
you are right.I understood that i must use feof or eof to save the file content onto an array.But in here as you see, if i used fgets, i shouldn't allocate my memory meanly.I should do for example
char content[100];
.
.
fgets(content,100,fp); // where is FILE *fp.
i could get error, because the text file can have more than 100 chars, but it maynot be, so if there is 1 char, other 99 is unnecessary.Please dont say me ,"he is mad" i wrote my own fgets because of this.
THank you very much again.

Well I'm not sure what prompted that response.

fgets(content,100,fp); // where is FILE *fp.
i could get error, because the text file can have more than 100 chars, but it maynot be, so if there is 1 char, other 99 is unnecessary.Please dont say me ,"he is mad" i wrote my own fgets because of this.

I hope you accomplished your actual goal, whatever it is. While I can look at (a fixed version of) your function and say it is memory efficient, fgets isn't particularly memory inefficient either. In fact fgets works differently. The same call to fgets will store a line of at most 100 characters in content. Now, if we look at t.txt, most of the file content is on separate lines. While most of your lines are short, fgets has to also handle the longest lines in your file. If 100 characters could be the longest line in your file, then that isn't mean.

That's not to say that writing something like what you wrote isn't valuable in its own right: there is a function in python called glob that returns the file content as an array of strings, one string for each line, but it seems like the idea for your whole function came from a misconception of how fgets works.