Undeclared Variable Error

**greendragons** · 12-21-2011

Hello,
I am writing a query for database
here is the code..

Code:

char *create_query(char *name, int perc)
 43 {
 44    char *defl = "INSERT INTO student_profile VALUES ('";
 45    char *def2 = "',";
 46    char *def3 = ");";
 47    char buf[33];
 48    char *query = (char *)malloc(300);
 49    strcat(query,def1);
 50    strcat(query, name);
 51    strcat(query, def2);
 52 
 53    itoa(perc, buf, 10);
 54 
 55    strcat(query, buf);
 56    strcat(query, def3);
 57 
 58    return query;
 59 }

I am getting error

03_Insert_into_Table.c: In function ‘create_query’:
03_Insert_into_Table.c:49:2: warning: incompatible implicit declaration of built-in function ‘strcat’
03_Insert_into_Table.c:49:15: error: ‘def1’ undeclared (first use in this function)
03_Insert_into_Table.c:49:15: note: each undeclared identifier is reported only once for each function it appears in

Even though i have declared def1 as char *, why im getting that error...
also what is wrong with strcat....

Thxn!!

**jimblumberg** · 12-21-2011

For the first error it looks like a spelling error, look closely at the last character. For the second error it looks like you need to include a couple of include files for the functions you are using. Show what include files you are currently including. Also you should not be casting the return value of malloc().

Jim

**greendragons** · 12-21-2011

here are the header file
#include<my_global.h>
#include<mysql.h>
#include<stdlib.h>
#include<string.h>

I think the malloc cast is fine as it returns void * and i need to operate on char * in strcat..
i solved strcat problem by including string.h...
But def1 problem is still there....

**rags_to_riches** · 12-21-2011

defl (lowercase L) is not the same as def1 (numeral one)

I think the malloc cast is fine as it returns void * and i need to operate on char * in strcat..

No, you never need to cast the return value of malloc in C.

and your first strcat should really be a strcpy.

You can do all of what you're doing with a simple snprintf.

Code:

char *create_query(const char *name, int perc)
 {
     const char * const queryFormat = "INSERT INTO student_profile VALUES ('%s', %d)";
     char *query = malloc(300);
     if (query) {
         snprintf(query, 300, queryFormat, name, perc);
     }
     return query;
 }

**greendragons** · 12-21-2011

gosh!! how can i miss that.. thnx alot rags....

**greendragons** · 12-21-2011

Originally Posted by rags_to_riches

defl (lowercase L) is not the same as def1 (numeral one)

No, you never need to cast the return value of malloc in C.

and your first strcat should really be a strcpy.

Yes your right it should be strcpy... can u please explain me why i dnt need to cast return poiner of malloc as i have been doing it in lot of programs... wht is wrong with it..
I know we don't require that in C but in C++ cast is mandatory... but if i do cast i dnt think anything is wrong with it....

**rags_to_riches** · 12-21-2011

If you're using C, and compiling as C, then there is no reason to cast it, and you should not do it. See the FAQ.

**stahta01** · 12-21-2011

FAQ > Casting malloc - Cprogramming.com

**greendragons** · 12-21-2011

Thnx alot!! i didn't know that....

Thread: Undeclared Variable Error

Thread Tools

Search Thread

Display

Undeclared Variable Error

Similar Threads

undeclared variable problem

error: undeclared (need some help)

Undeclared/un-initialized variable

undeclared indentifier error

Compiler error error C2065: '_beginthreadex; : undeclared identifier

Tags for this Thread