Problem with looking for MIN,MAX in Array

[ToNy_]

I have a code . Looking for Min,Max in a Array . I can find Min in array
but Max display garbage. Please tell me why .

#include<stdio.h>
#include<conio.h>
int main()
{
    int number[25];
    int i,j,n,min,max;

    printf("Input total object in array: ");
    scanf("%d",&n);

    printf("Please input each object:");
    for(i=0;i<n;i++)
    {
        printf("Object %d \n:",i+1);
        scanf("%d",&number[i]);
    }

     for(i=0;i<n;i++)
    {
        if(number[i]<min)
        min=number[i];
    }
    printf("\n Min number in array is: %d",min);

    for(j=0;j<n-1;j++)
    {
        if(number[j]>max)
        max=number[j];
    }
    printf("\n Max number in array is : : %d",max);
    return 0;
}

[CommonTater]

You are using both min and max in an uninitialzed state...
Ask what are their values right before the start of their respective loops?

Also it wouldn't be much of a problem to combine those two loops...

[grumpy]

Your code never initialises max and min before using them. Accessing the value of any uninitialised variable gives undefined behaviour.

The lines

    if (number[i] < min)

and

    if (number[j] > max)

both give undefined behaviour, because both max and min are uninitialised the first time through the respective loop, and these statements access their values.

You just got lucky in having your calculation of min appearing to be correct. The calculation is still wrong.

Upshot: you need to initialise max and min before using them.

[ToNy_]

Thanks a lot CommonTater, vs Grumpy . I was correct it and it don't have problem . But i till don't know when we must initialize value of variable .
This is my code :

#include<stdio.h>
#include<conio.h>
int main()
{
    int number[25];
    int i,n;
    int min;
    int max;

    printf("Input total object in array: ");
    scanf("%d",&n);

    printf("Please input each object:");
    for(i=0;i<n;i++)
    {
        printf("\nObject %d:",i+1);
        scanf("%d",&number[i]);
    }
     max = number[0];
     min = number[0];
     for(i=0;i<n;i++)
    {
        if(number[i]<min) min=number[i];
        if(number[i]>max) max=number[i];
    }
    printf("\n Min number in array is: %d",min);
    printf("\n Max number in array is : : %d",max);
    return 0;
}

Don't need two the loops.

[CommonTater]

Thanks a lot CommonTater, vs Grumpy . I was correct it and it don't have problem . But i till don't know when we must initialize value of variable .

That's easy .... Always.

We have to because C doesn't.

[ToNy_]

That's easy .... Always.

We have to because C doesn't.

Ok . I'm will do it.