Thread: Most spaces

I want to create program which count longest series of spaces. Here is my code. I always shows 0 no matter how many spaces consist. I am only starting learning c programming so where is the problem?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    char string[20];
    int count = 0;
    int spaces=0, before=0, max=0;
    int ch;
    printf("enter string\n");
    gets(string);

while (1) {
        ch = getchar();
        if (ch == EOF)
            break;
        if (ch==' ')
        {
            if (before=0)
            
                spaces=1;
                before=1;
                  
            if (spaces>max) max=spaces;
            spaces=0;
            before=0;
        }
      
    printf("Longest serie of spaces %d\n", max);
    while (strlen(string)!=0);
    system("PAUSE");
    return (0); 
}
}

Code:

 #include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    char string[20];
    int count = 0;

    int spaces=0, before=0, max=0;

    int ch;

    printf("enter string\n");

    gets(string);

 

while (1) {        

        if (ch == EOF)

            break;
        if (ch==' ')
        {

            if (before==0)

             

                spaces=1;

                before=1;

                   

            if (spaces>max) max=spaces;

            spaces=0;

            before=0;

        }

       

    printf("Longest serie of spaces %d\n", max);    

    system("PAUSE");

    return (0); 

}

}

Now it looks like this but still output is always 0

This code has some problems:

Code:

            if (before==0)

             

                spaces=1;  //<<== is subordinate to if()

                before=1;   //<<==is NOT subordinate to if()

                   

            if (spaces>max) max=spaces;

            spaces=0;

            before=0;

the spaces and before assignment lines of code, following the upper if statement, appear through the indentation, to be equal in level of subordination - and they are not equal. Only spaces=1 is suborordinate and will be executed when the if() statement tests out as true.

That's why indentation in code is very important.

I'm not saying this logic is any better than yours, but intuitively, it seems easiest to just use another nested while() loop:

Code:

     space=0;       //prime the while pump
     while(char is a space) 
         spaces++;
     if(spaces > maxSpaces)
         maxSpaces=spaces;

Tightly coupled logic like that while loop ^^^ is easy to get right, imo.

I wonder how many people in America today, have ever pumped water from a hand pump well, that had to be primed?

Not many I'd guess, but while() loops frequently need some "priming" to set up the variable values it will use.

Maybe I ask to much but maybe you can write how it have to look because I still cannot get a right result then I will have an example for the future.

You don't need the "before" variable or logic based on it. Just step through the string, char by char, from the first char, to the last one. When you hit a space, let the while loop I showed you above, do it's work, counting the spaces for as long as they go on.

When it hits a non-space letter, then the while loop I showed you will quit, and the outer while loop will start working again:

Code:

while(there is another letter) {  //the outer while loop you have

   while(the letter is a space)  {  //the inner while loop I showed you
         //code to count the spaces
    }
    if(spaces > max_spaces)
        assign spaces to max_spaces
}

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    char string[20];
    int count = 0;
    int spaces=0, max=0;
    int ch;
    printf("enter string\n");
    gets(string);
 
while (1) {
        
        if (ch == EOF)
            break;
        {
            spaces=0; 
            }      
while (ch==' ') ;
      }        
    spaces++;
if(spaces > max);
    max=spaces;
        
    printf("Longest serie of spaces %d\n", max);
    
    system("PAUSE");
    return (0);
}

Now my code looks like this but i enter the string and don/t get any output. So what i'm doing wrong now?

Can you fix this code? Because i working on it several days then i will have example for the future

anyone?

And another cross-posting "do my work for me" person appears

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    char string[100];
    int count = 0;
    int max=0;

    printf("enter string\n");
    gets(string);
 int i=0;

while (string[i+1]!='\0') {
     if(string[i+1]==' ')++count;
     if((string[i]=' ' && string[i+1]!=' ')&& count>max)max=count,count=0;
     ++i;
}
    printf("Longest serie of spaces %d\n", max);
    while (strlen(string)!=0);
    system("PAUSE");
    return (0);

}

Originally Posted by Salem

Did you spot the use of = rather than == as well?

And read post #2 again.

sorry it is my mistake